From: Colin Ian King <colin.king@canonical.com>
To: Peter Rosin <peda@axentia.se>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michal Simek <michal.simek@xilinx.com>,
Johan Hovold <johan@kernel.org>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next][V2] i2c: xiic: fix indentation issue
Date: Tue, 28 Jan 2020 23:10:59 +0000 [thread overview]
Message-ID: <3b287fb5-e344-c13a-2803-09c2958b9b0d@canonical.com> (raw)
In-Reply-To: <35ed6501-3b26-36a9-d332-d4ed3366ebd8@axentia.se>
On 28/01/2020 21:45, Peter Rosin wrote:
> On 2020-01-27 13:08, Colin Ian King wrote:
>> On 27/01/2020 12:05, Dan Carpenter wrote:
>>> On Mon, Jan 27, 2020 at 12:03:02PM +0100, Michal Simek wrote:
>>>> On 27. 01. 20 11:23, Colin King wrote:
>>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>>
>>>>> There is a statement that is indented one level too deeply, remove
>>>>> the extraneous tab.
>>>>>
>>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>>> ---
>>>>> V2: fix type in commit message
>>>>> ---
>>>>> drivers/i2c/busses/i2c-xiic.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
>>>>> index b17d30c9ab40..90c1c362394d 100644
>>>>> --- a/drivers/i2c/busses/i2c-xiic.c
>>>>> +++ b/drivers/i2c/busses/i2c-xiic.c
>>>>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
>>>>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
>>>>> if (time_after(jiffies, timeout)) {
>>>>> dev_err(i2c->dev, "Failed to clear rx fifo\n");
>>>>> - return -ETIMEDOUT;
>>>>> + return -ETIMEDOUT;
>>>>> }
>>>>> }
>>>>>
>>>>>
>>>>
>>>> As was suggested by Peter you should also add Fixes: <sha1> ("patch
>>>> subject")
>>>>
>>>
>>> It's not really a bugfix, it's just a cleanup.
>>
>> I'm surprised i wasn't asked for a bug number too.
>
> Very funny.
Apologies for being flippant. I didn't mean to offend. My bad #1.
>
> I realize that you, the three complainers (Johan, Dan and Colin), together
> have almost 10000 commits. So, I feel a bit outranked.
>
> However, this ridicule is unfair.
>
> The problem here is that Colin sent a v2, ignoring my suggestion to add
> a fixes-tag without mentioning that my suggestion was in fact ignored
> (and why). That is a sure way to invite someone else to point out what
> seemed like an omission. Which happened. And then this farce ensued.
I can only apologize for not adding the fixes tag because I honestly
didn't see the fixes tag request until after the follow-ups. I didn't
indent to rile anyone on this and I didn't want to offend anyone by
purposely ignoring their requires. My bad #2.
>
> So, Colin, take a long look in the mirror and direct your sarcasm in
> whatever direction you feel appropriate.
I did. And I was wrong. My bad #3.
>
> I also maintain that noone writes code like this on purpose (at least
> not without some ulterior motive). This is the kind of stuff that cause
> problems and wastes time later when someone mis-reads the code. You three
> people, with all those commits, should know that. My point is that this
> is more than just cleanup and is indeed fixing a bug. Claiming otherwise
> is just silly. The compiler is not the only consumer of the code.
Whatever is needed to get fixes into the kernel. Some say it's a bug,
others don't. As long as it's fixed then I'm happy. If in the process I
did the wrong thing I can only apologize profoundly and profusely.
Colin
>
> Cheers,
> Peter
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-28 23:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 10:23 [PATCH][next][V2] i2c: xiic: fix indentation issue Colin King
2020-01-27 11:03 ` Michal Simek
2020-01-27 11:11 ` Johan Hovold
2020-01-27 12:05 ` Dan Carpenter
2020-01-27 12:08 ` Colin Ian King
2020-01-27 12:11 ` Michal Simek
2020-01-28 21:45 ` Peter Rosin
2020-01-28 23:10 ` Colin Ian King [this message]
2020-01-28 23:48 ` Joe Perches
2020-01-29 9:31 ` Peter Rosin
2020-01-29 8:06 ` Peter Rosin
2020-01-27 11:17 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b287fb5-e344-c13a-2803-09c2958b9b0d@canonical.com \
--to=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).