Re: [PATCH] bluetooth: realtek: devicetree: Add device tree description to bluetooth rtl drivers

[David Summers <beagleboard@davidjohnsummers.uk>]

And just looking at my patch, I remember I wrote this a month or so ago, 
thought it had been checked - but a couple of changes didn't make it in:

1) "bluetoooth" is spelled "bluetooth"
2) The realtek compatible should be wrapped in a "#ifdef 
CONFIG_BT_HCIUART_RTL" as hci_h5 needs that to have the realtek links in

I'll make these changes in a few days, but leave this patch here - in 
case there are any other comments.

Would hope to get basic nod by next week (yes know bad time for people 
over Christmas), as its free time I have to do the device tree that 
needs these in ...

Regards,

David.

On 29/12/2018 11:55, David Summers wrote:
> This patch add the relevent device tree handles to the bluetooth driver
> for serial realtek devices.
>
> Specifically it takes all devices listed in btrtk.c identifes from the
> realtek web site which are serial devices (this invariably means
> devices that end with and "s" in the device name).
>
> Most of these devices are dual wifi and bluetooth, with wifi on and
> sdio connection, and bluetooth on a serial uart. As these two
> interfaces will need independent listings in the device tree, the
> nodes here have "-bluetooth" added. The only exception is the
> rtl8761atv device, which is bluetooth only - and only has a uart
> interface.
>
> Can devicetree people revive the naming scheme used here, and confirm
> it is acceptable.
>
> Marcel, if the device tree people are happy can you apply to the
> bluetooth tree.
>
> Thanks,
>
> David.
>
> Signed-off-by: David Summers <beagleboard@davidjohnsummers.uk>
> ---
>   drivers/bluetooth/hci_h5.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_h5.c b/drivers/bluetooth/hci_h5.c
> index 8eede1197cd2..61c9e729efc1 100644
> --- a/drivers/bluetooth/hci_h5.c
> +++ b/drivers/bluetooth/hci_h5.c
> @@ -925,6 +925,20 @@ static struct h5_vnd rtl_vnd = {
>   };
>   #endif
>   
> +#ifdef CONFIG_OF
> +static const struct of_device_id h5_of_match[] = {
> +       { .compatible = "realtek,rtl8723as-bluetoooth"},
> +       { .compatible = "realtek,rtl8723bs-bluetoooth"},
> +       { .compatible = "realtek,rtl8723ds-bluetoooth"},
> +       { .compatible = "realtek,rtl8761atv"},
> +       { .compatible = "realtek,rtl8821as-bluetoooth"},
> +       { .compatible = "realtek,rtl8821cs-bluetoooth"},
> +       { .compatible = "realtek,rtl8822bs-bluetoooth"},
> +       { }
> +};
> +MODULE_DEVICE_TABLE(of, h5_of_match);
> +#endif
> +
>   #ifdef CONFIG_ACPI
>   static const struct acpi_device_id h5_acpi_match[] = {
>   #ifdef CONFIG_BT_HCIUART_RTL



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel