linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Georgi Djakov <georgi.djakov@linaro.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>,
	robh@kernel.org, shawnguo@kernel.org, festevam@gmail.com,
	catalin.marinas@arm.com, will@kernel.org, cdleonard@gmail.com
Cc: devicetree@vger.kernel.org, kernel@puri.sm,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de,
	Leonard Crestez <leonard.crestez@nxp.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes
Date: Tue, 1 Dec 2020 14:56:46 +0200	[thread overview]
Message-ID: <4d089936-65fe-8601-73e7-0424d363b6f2@linaro.org> (raw)
In-Reply-To: <20201201123932.12312-2-martin.kepplinger@puri.sm>

Hi Martin,

Thank you for sending the patches.

On 1.12.20 14:39, Martin Kepplinger wrote:
> From: Leonard Crestez <leonard.crestez@nxp.com>
> 
> Add initial support for dynamic frequency scaling of main NOC.
> 
> Make DDRC the parent of the NOC (using passive governor) so that the
> main NOC is automatically scaled together with DDRC by default.
> 
> Support for proactive scaling via interconnect will come on top.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm> (imx8mq)

As you are sending this, i believe that it should have your signed-off 
line (please check Documentation/process/submitting-patches.rst).

Also please give people some time to look into this (at least 1-2 weeks) 
before submitting a new version.

Thanks,
Georgi

> ---
>   arch/arm64/boot/dts/freescale/imx8mm.dtsi | 22 ++++++++++++++++++++++
>   arch/arm64/boot/dts/freescale/imx8mn.dtsi | 22 ++++++++++++++++++++++
>   arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
>   3 files changed, 66 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c824f2615fe8..835b19f0ea42 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -921,6 +921,28 @@
>   
>   		};
>   
> +		noc: interconnect@32700000 {
> +			compatible = "fsl,imx8mm-noc", "fsl,imx8m-noc";
> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MM_CLK_NOC>;
> +			devfreq = <&ddrc>;
> +			operating-points-v2 = <&noc_opp_table>;
> +
> +			noc_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-150M {
> +					opp-hz = /bits/ 64 <150000000>;
> +				};
> +				opp-375M {
> +					opp-hz = /bits/ 64 <375000000>;
> +				};
> +				opp-750M {
> +					opp-hz = /bits/ 64 <750000000>;
> +				};
> +			};
> +		};
> +
>   		aips4: bus@32c00000 {
>   			compatible = "fsl,aips-bus", "simple-bus";
>   			reg = <0x32c00000 0x400000>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index a06d2a6268e6..8e2d413f97d4 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -772,6 +772,28 @@
>   
>   		};
>   
> +		noc: interconnect@32700000 {
> +			compatible = "fsl,imx8mn-noc", "fsl,imx8m-noc";
> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MN_CLK_NOC>;
> +			devfreq = <&ddrc>;
> +			operating-points-v2 = <&noc_opp_table>;
> +
> +			noc_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-100M {
> +					opp-hz = /bits/ 64 <100000000>;
> +				};
> +				opp-600M {
> +					opp-hz = /bits/ 64 <600000000>;
> +				};
> +				opp-800M {
> +					opp-hz = /bits/ 64 <800000000>;
> +				};
> +			};
> +		};
> +
>   		aips4: bus@32c00000 {
>   			compatible = "fsl,aips-bus", "simple-bus";
>   			reg = <0x32c00000 0x400000>;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index a841a023e8e0..d139a46ee8ce 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1158,6 +1158,28 @@
>   			};
>   		};
>   
> +		noc: interconnect@32700000 {
> +			compatible = "fsl,imx8mq-noc", "fsl,imx8m-noc";
> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MQ_CLK_NOC>;
> +			devfreq = <&ddrc>;
> +			operating-points-v2 = <&noc_opp_table>;
> +
> +			noc_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-133M {
> +					opp-hz = /bits/ 64 <133333333>;
> +				};
> +				opp-400M {
> +					opp-hz = /bits/ 64 <400000000>;
> +				};
> +				opp-800M {
> +					opp-hz = /bits/ 64 <800000000>;
> +				};
> +			};
> +		};
> +
>   		bus@32c00000 { /* AIPS4 */
>   			compatible = "fsl,aips-bus", "simple-bus";
>   			reg = <0x32c00000 0x400000>;
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-01 12:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01 12:39 [PATCH v2 0/7] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes Martin Kepplinger
2020-12-01 12:56   ` Georgi Djakov [this message]
2020-12-02  8:14   ` Krzysztof Kozlowski
2020-12-01 12:39 ` [PATCH v2 2/7] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 3/7] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 4/7] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2020-12-01 13:46   ` Guido Günther
2020-12-01 12:39 ` [PATCH v2 5/7] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 6/7] arm64: defconfig: updates for 5.10 Martin Kepplinger
2020-12-02  8:30   ` Georgi Djakov
2020-12-01 12:39 ` [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-01 13:10   ` Georgi Djakov
2020-12-01 13:15     ` Martin Kepplinger
2020-12-02  8:03       ` Krzysztof Kozlowski
2020-12-02  8:05         ` Krzysztof Kozlowski
2020-12-02 11:27           ` Martin Kepplinger
2020-12-02 12:23             ` Krzysztof Kozlowski
2020-12-02  8:02   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d089936-65fe-8601-73e7-0424d363b6f2@linaro.org \
    --to=georgi.djakov@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=cdleonard@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).