From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@pengutronix.de, cdleonard@gmail.com,
devicetree@vger.kernel.org, shawnguo@kernel.org,
linux-pm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-imx@nxp.com, festevam@gmail.com, catalin.marinas@arm.com,
will@kernel.org, Georgi Djakov <georgi.djakov@linaro.org>,
linux-arm-kernel@lists.infradead.org, kernel@puri.sm
Subject: Re: [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq
Date: Wed, 2 Dec 2020 14:23:34 +0200 [thread overview]
Message-ID: <CAJKOXPc6BEw3A+pO9HOK4h59jZ2_TEfKcz79f7PbkPhJdPhE_w@mail.gmail.com> (raw)
In-Reply-To: <226e76a8-011e-ece5-d8fa-b52dbc81787b@puri.sm>
On Wed, 2 Dec 2020 at 13:30, Martin Kepplinger
<martin.kepplinger@puri.sm> wrote:
> >>>>> -CONFIG_INTERCONNECT=y
> >>>>
> >>>> Why are you removing this line?
> >>>
> >>> savedefconfig removes it. INTERCONNECT_IMX below depends on it.
> >>
> >> It's save to remove it as other Interconnect options are directly
> >> dependant.
> >
> > Ugh, my bad, it is not allowed to remove it. My review was too fast.
> > INTERCONNECT_IMX depends on it, so the INTERCONNECT must stay,
> >
> > It is selected by TEGRA_MC which is independent here, so you should keep it.
> >
>
> thanks for reviewing! Just to be clear: We're talking about defconfig,
> so if I keep INTERCONNECT that means that I do `make savedefconfig`
> which removes it (it's of course still enabled, just redundant in
> defconfig output), and then *manually* add INTERCONNECT. That would
> indicate that there's a Kconfig bug.
I don't get the point. You should not send the savedefconfig output as
is, without any adjustments and checks. You can run savedefconfig
because it nicely puts your entries in the proper place, but it's not
a bug that it removes features which we *want to keep*. Where is a
bug in Kconfig?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-02 12:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:39 [PATCH v2 0/7] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes Martin Kepplinger
2020-12-01 12:56 ` Georgi Djakov
2020-12-02 8:14 ` Krzysztof Kozlowski
2020-12-01 12:39 ` [PATCH v2 2/7] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 3/7] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 4/7] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2020-12-01 13:46 ` Guido Günther
2020-12-01 12:39 ` [PATCH v2 5/7] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 6/7] arm64: defconfig: updates for 5.10 Martin Kepplinger
2020-12-02 8:30 ` Georgi Djakov
2020-12-01 12:39 ` [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-01 13:10 ` Georgi Djakov
2020-12-01 13:15 ` Martin Kepplinger
2020-12-02 8:03 ` Krzysztof Kozlowski
2020-12-02 8:05 ` Krzysztof Kozlowski
2020-12-02 11:27 ` Martin Kepplinger
2020-12-02 12:23 ` Krzysztof Kozlowski [this message]
2020-12-02 8:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPc6BEw3A+pO9HOK4h59jZ2_TEfKcz79f7PbkPhJdPhE_w@mail.gmail.com \
--to=krzk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cdleonard@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).