From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: robh@kernel.org, kernel@pengutronix.de, cdleonard@gmail.com,
devicetree@vger.kernel.org, shawnguo@kernel.org,
linux-pm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-imx@nxp.com, festevam@gmail.com, catalin.marinas@arm.com,
will@kernel.org, Georgi Djakov <georgi.djakov@linaro.org>,
linux-arm-kernel@lists.infradead.org, kernel@puri.sm
Subject: Re: [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq
Date: Wed, 2 Dec 2020 10:05:12 +0200 [thread overview]
Message-ID: <CAJKOXPcAbmugB9k-1Ldo=Q1J0CbOcxMtgC005w=DmWukThVcWA@mail.gmail.com> (raw)
In-Reply-To: <20201202080321.GB6087@kozik-lap>
On Wed, 2 Dec 2020 at 10:03, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Dec 01, 2020 at 02:15:04PM +0100, Martin Kepplinger wrote:
> > On 01.12.20 14:10, Georgi Djakov wrote:
> > > On 1.12.20 14:39, Martin Kepplinger wrote:
> > > > Enable INTERCONNECT_IMX8MQ in order to make interconnect more widely
> > > > available for testing.
> > >
> > > I hope that it's not just for testing, but using it.
> >
> > sure, I just think that most people will use their own config for production
> > but that's a different story. I can rephrase.
> >
> > >
> > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > > > ---
> > > > arch/arm64/configs/defconfig | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > > > index 1fed16950a7c..830c26a95b3d 100644
> > > > --- a/arch/arm64/configs/defconfig
> > > > +++ b/arch/arm64/configs/defconfig
> > > > @@ -1023,7 +1023,8 @@ CONFIG_OPTEE=y
> > > > CONFIG_MUX_MMIO=y
> > > > CONFIG_SLIM_QCOM_CTRL=m
> > > > CONFIG_SLIM_QCOM_NGD_CTRL=m
> > > > -CONFIG_INTERCONNECT=y
> > >
> > > Why are you removing this line?
> >
> > savedefconfig removes it. INTERCONNECT_IMX below depends on it.
>
> It's save to remove it as other Interconnect options are directly
> dependant.
Ugh, my bad, it is not allowed to remove it. My review was too fast.
INTERCONNECT_IMX depends on it, so the INTERCONNECT must stay,
It is selected by TEGRA_MC which is independent here, so you should keep it.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-02 8:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 12:39 [PATCH v2 0/7] imx8mq: updates for the interconnect fabric Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 1/7] arm64: dts: imx8m: Add NOC nodes Martin Kepplinger
2020-12-01 12:56 ` Georgi Djakov
2020-12-02 8:14 ` Krzysztof Kozlowski
2020-12-01 12:39 ` [PATCH v2 2/7] arm64: dts: imx8mq: Add interconnect provider property Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 3/7] arm64: dts: imx8mq: Add interconnect for lcdif Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 4/7] dt-bindings: mxsfb: Add interconnect bindings for LCDIF path Martin Kepplinger
2020-12-01 13:46 ` Guido Günther
2020-12-01 12:39 ` [PATCH v2 5/7] interconnect: imx8mq: Use icc_sync_state Martin Kepplinger
2020-12-01 12:39 ` [PATCH v2 6/7] arm64: defconfig: updates for 5.10 Martin Kepplinger
2020-12-02 8:30 ` Georgi Djakov
2020-12-01 12:39 ` [PATCH v2 7/7] arm64: defconfig: Enable interconnect for imx8mq Martin Kepplinger
2020-12-01 13:10 ` Georgi Djakov
2020-12-01 13:15 ` Martin Kepplinger
2020-12-02 8:03 ` Krzysztof Kozlowski
2020-12-02 8:05 ` Krzysztof Kozlowski [this message]
2020-12-02 11:27 ` Martin Kepplinger
2020-12-02 12:23 ` Krzysztof Kozlowski
2020-12-02 8:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPcAbmugB9k-1Ldo=Q1J0CbOcxMtgC005w=DmWukThVcWA@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cdleonard@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).