* [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang
[not found] <cover.1605896059.git.gustavoars@kernel.org>
@ 2020-11-20 18:37 ` Gustavo A. R. Silva
2020-11-23 7:00 ` Michal Simek
2020-11-24 14:25 ` Ulf Hansson
2020-11-20 18:37 ` [PATCH 099/141] mt76: mt7615: " Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 104/141] mtd: rawnand: stm32_fmc2: " Gustavo A. R. Silva
2 siblings, 2 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-20 18:37 UTC (permalink / raw)
To: Michal Simek, Adrian Hunter, Ulf Hansson
Cc: Gustavo A. R. Silva, linux-mmc, linux-kernel, linux-arm-kernel,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding multiple break statements instead of
letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/mmc/host/sdhci-of-arasan.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
index 829ccef87426..1f7e42b6ced5 100644
--- a/drivers/mmc/host/sdhci-of-arasan.c
+++ b/drivers/mmc/host/sdhci-of-arasan.c
@@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
case MMC_TIMING_MMC_HS200:
/* For 200MHz clock, 8 Taps are available */
tap_max = 8;
+ break;
default:
break;
}
@@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees)
case MMC_TIMING_MMC_HS200:
/* For 200MHz clock, 30 Taps are available */
tap_max = 30;
+ break;
default:
break;
}
@@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
case MMC_TIMING_MMC_HS200:
/* For 200MHz clock, 8 Taps are available */
tap_max = 8;
+ break;
default:
break;
}
@@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees)
case MMC_TIMING_MMC_HS200:
/* For 200MHz clock, 30 Taps are available */
tap_max = 30;
+ break;
default:
break;
}
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang
2020-11-20 18:37 ` [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2020-11-23 7:00 ` Michal Simek
2020-11-23 22:59 ` Gustavo A. R. Silva
2020-11-24 14:25 ` Ulf Hansson
1 sibling, 1 reply; 9+ messages in thread
From: Michal Simek @ 2020-11-23 7:00 UTC (permalink / raw)
To: Gustavo A. R. Silva, Michal Simek, Adrian Hunter, Ulf Hansson
Cc: linux-mmc, linux-kernel, linux-arm-kernel, linux-hardening
On 20. 11. 20 19:37, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 829ccef87426..1f7e42b6ced5 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 8 Taps are available */
> tap_max = 8;
> + break;
> default:
> break;
> }
> @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 30 Taps are available */
> tap_max = 30;
> + break;
> default:
> break;
> }
> @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 8 Taps are available */
> tap_max = 8;
> + break;
> default:
> break;
> }
> @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 30 Taps are available */
> tap_max = 30;
> + break;
> default:
> break;
> }
>
No problem with it.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang
2020-11-23 7:00 ` Michal Simek
@ 2020-11-23 22:59 ` Gustavo A. R. Silva
0 siblings, 0 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-23 22:59 UTC (permalink / raw)
To: Michal Simek
Cc: Ulf Hansson, linux-mmc, Adrian Hunter, linux-kernel,
linux-hardening, linux-arm-kernel
On Mon, Nov 23, 2020 at 08:00:35AM +0100, Michal Simek wrote:
>
>
> On 20. 11. 20 19:37, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> > warnings by explicitly adding multiple break statements instead of
> > letting the code fall through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > drivers/mmc/host/sdhci-of-arasan.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> > index 829ccef87426..1f7e42b6ced5 100644
> > --- a/drivers/mmc/host/sdhci-of-arasan.c
> > +++ b/drivers/mmc/host/sdhci-of-arasan.c
> > @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
> > case MMC_TIMING_MMC_HS200:
> > /* For 200MHz clock, 8 Taps are available */
> > tap_max = 8;
> > + break;
> > default:
> > break;
> > }
> > @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees)
> > case MMC_TIMING_MMC_HS200:
> > /* For 200MHz clock, 30 Taps are available */
> > tap_max = 30;
> > + break;
> > default:
> > break;
> > }
> > @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
> > case MMC_TIMING_MMC_HS200:
> > /* For 200MHz clock, 8 Taps are available */
> > tap_max = 8;
> > + break;
> > default:
> > break;
> > }
> > @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees)
> > case MMC_TIMING_MMC_HS200:
> > /* For 200MHz clock, 30 Taps are available */
> > tap_max = 30;
> > + break;
> > default:
> > break;
> > }
> >
>
> No problem with it.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks, Michal.
--
Gustavo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang
2020-11-20 18:37 ` [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-23 7:00 ` Michal Simek
@ 2020-11-24 14:25 ` Ulf Hansson
2020-11-24 14:36 ` Gustavo A. R. Silva
1 sibling, 1 reply; 9+ messages in thread
From: Ulf Hansson @ 2020-11-24 14:25 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: linux-mmc, Linux Kernel Mailing List, Michal Simek,
linux-hardening, Adrian Hunter, Linux ARM
On Fri, 20 Nov 2020 at 19:37, Gustavo A. R. Silva <gustavoars@kernel.org> wrote:
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> warnings by explicitly adding multiple break statements instead of
> letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-of-arasan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 829ccef87426..1f7e42b6ced5 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -627,6 +627,7 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 8 Taps are available */
> tap_max = 8;
> + break;
> default:
> break;
> }
> @@ -695,6 +696,7 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 30 Taps are available */
> tap_max = 30;
> + break;
> default:
> break;
> }
> @@ -760,6 +762,7 @@ static int sdhci_versal_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 8 Taps are available */
> tap_max = 8;
> + break;
> default:
> break;
> }
> @@ -831,6 +834,7 @@ static int sdhci_versal_sampleclk_set_phase(struct clk_hw *hw, int degrees)
> case MMC_TIMING_MMC_HS200:
> /* For 200MHz clock, 30 Taps are available */
> tap_max = 30;
> + break;
> default:
> break;
> }
> --
> 2.27.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang
2020-11-24 14:25 ` Ulf Hansson
@ 2020-11-24 14:36 ` Gustavo A. R. Silva
0 siblings, 0 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-24 14:36 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-mmc, Linux Kernel Mailing List, Michal Simek,
linux-hardening, Adrian Hunter, Linux ARM
On Tue, Nov 24, 2020 at 03:25:32PM +0100, Ulf Hansson wrote:
> On Fri, 20 Nov 2020 at 19:37, Gustavo A. R. Silva <gustavoars@kernel.org> wrote:
> >
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
> > warnings by explicitly adding multiple break statements instead of
> > letting the code fall through to the next case.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> Applied for next, thanks!
Thank you, Uffe.
--
Gustavo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 099/141] mt76: mt7615: Fix fall-through warnings for Clang
[not found] <cover.1605896059.git.gustavoars@kernel.org>
2020-11-20 18:37 ` [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2020-11-20 18:37 ` Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 104/141] mtd: rawnand: stm32_fmc2: " Gustavo A. R. Silva
2 siblings, 0 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-20 18:37 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Ryder Lee, Kalle Valo,
David S. Miller, Jakub Kicinski, Matthias Brugger
Cc: netdev, linux-wireless, linux-kernel, Gustavo A. R. Silva,
linux-mediatek, linux-hardening, linux-arm-kernel
In preparation to enable -Wimplicit-fallthrough for Clang, fix a
warning by replacing a /* fall through */ comment with the new
pseudo-keyword macro fallthrough; instead of letting the code fall
through to the next case.
Notice that Clang doesn't recognize /* fall through */ comments as
implicit fall-through markings.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
index f4756bb946c3..9a9685e5ab84 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
@@ -127,7 +127,7 @@ mt7615_eeprom_parse_hw_band_cap(struct mt7615_dev *dev)
break;
case MT_EE_DBDC:
dev->dbdc_support = true;
- /* fall through */
+ fallthrough;
default:
dev->mt76.cap.has_2ghz = true;
dev->mt76.cap.has_5ghz = true;
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 104/141] mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang
[not found] <cover.1605896059.git.gustavoars@kernel.org>
2020-11-20 18:37 ` [PATCH 098/141] mmc: sdhci-of-arasan: Fix fall-through warnings for Clang Gustavo A. R. Silva
2020-11-20 18:37 ` [PATCH 099/141] mt76: mt7615: " Gustavo A. R. Silva
@ 2020-11-20 18:37 ` Gustavo A. R. Silva
2020-11-23 8:33 ` Miquel Raynal
2 siblings, 1 reply; 9+ messages in thread
From: Gustavo A. R. Silva @ 2020-11-20 18:37 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra,
Maxime Coquelin, Alexandre Torgue
Cc: Gustavo A. R. Silva, linux-kernel, linux-mtd, linux-hardening,
linux-stm32, linux-arm-kernel
In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
of warnings by explicitly adding a couple of fallthrough pseudo-keywords
instead of letting the code fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
index 550bda4d1415..002fa521036f 100644
--- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
@@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
switch (b % 4) {
case 2:
bit_position += shifting;
+ fallthrough;
case 1:
break;
default:
@@ -546,6 +547,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
switch (b % 4) {
case 2:
byte_addr += shifting;
+ fallthrough;
case 1:
break;
default:
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 104/141] mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang
2020-11-20 18:37 ` [PATCH 104/141] mtd: rawnand: stm32_fmc2: " Gustavo A. R. Silva
@ 2020-11-23 8:33 ` Miquel Raynal
2021-02-08 15:15 ` Gustavo A. R. Silva
0 siblings, 1 reply; 9+ messages in thread
From: Miquel Raynal @ 2020-11-23 8:33 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel, linux-mtd,
linux-hardening, Maxime Coquelin, linux-stm32, linux-arm-kernel,
Alexandre Torgue
Hi Gustavo,
"Gustavo A. R. Silva" <gustavoars@kernel.org> wrote on Fri, 20 Nov 2020
12:37:48 -0600:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
> of warnings by explicitly adding a couple of fallthrough pseudo-keywords
> instead of letting the code fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> index 550bda4d1415..002fa521036f 100644
> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
> @@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
> switch (b % 4) {
> case 2:
> bit_position += shifting;
> + fallthrough;
In patch 100, 101, 102, 103 you 'break' in this case (when the
statement falls into the empty following statement which itself
breaks). Please make it consistent and use break here, below, and in
patch 132.
LGTM otherwise.
> case 1:
> break;
> default:
> @@ -546,6 +547,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
> switch (b % 4) {
> case 2:
> byte_addr += shifting;
> + fallthrough;
> case 1:
> break;
> default:
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 104/141] mtd: rawnand: stm32_fmc2: Fix fall-through warnings for Clang
2020-11-23 8:33 ` Miquel Raynal
@ 2021-02-08 15:15 ` Gustavo A. R. Silva
0 siblings, 0 replies; 9+ messages in thread
From: Gustavo A. R. Silva @ 2021-02-08 15:15 UTC (permalink / raw)
To: Miquel Raynal, Gustavo A. R. Silva
Cc: Vignesh Raghavendra, Richard Weinberger, linux-kernel, linux-mtd,
linux-hardening, Maxime Coquelin, linux-stm32, linux-arm-kernel,
Alexandre Torgue
Hi Miquel,
On 11/23/20 02:33, Miquel Raynal wrote:
> Hi Gustavo,
>
> "Gustavo A. R. Silva" <gustavoars@kernel.org> wrote on Fri, 20 Nov 2020
> 12:37:48 -0600:
>
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple
>> of warnings by explicitly adding a couple of fallthrough pseudo-keywords
>> instead of letting the code fall through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> index 550bda4d1415..002fa521036f 100644
>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
>> @@ -531,6 +531,7 @@ static int stm32_fmc2_nfc_ham_correct(struct nand_chip *chip, u8 *dat,
>> switch (b % 4) {
>> case 2:
>> bit_position += shifting;
>> + fallthrough;
>
> In patch 100, 101, 102, 103 you 'break' in this case (when the
> statement falls into the empty following statement which itself
> breaks). Please make it consistent and use break here, below, and in
> patch 132.
I'll address this and send separate patches.
> LGTM otherwise.
Thanks!
--
Gustavo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread