From: "Andreas Färber" <afaerber@suse.de>
To: James Tai <james.tai@realtek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir
Date: Tue, 19 Nov 2019 10:11:39 +0100 [thread overview]
Message-ID: <6182b89f-cd7e-ce7c-56f7-e2f500321cde@suse.de> (raw)
In-Reply-To: <43B123F21A8CFE44A9641C099E4196FFCF920024@RTITMBSVM04.realtek.com.tw>
Hi James,
Am 08.11.19 um 16:36 schrieb James Tai:
>> Is the UART no longer behind an IRQ mux on RTD1619, or is the above the IRQ
>> mux interrupt as a workaround for lack of in-tree irqchip driver?
>>
> Yes, the UART no longer behind an IRQ mux on RTD1619.
This conflicts with what I see in BSP irq mux code here:
https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/drivers/irqchip/irq-rtd16xx.h
That does show UR0 as bit 2 for the iso irq mux, as for previous SoCs.
Is that code wrong, or does the same UART0 IP block have two alternative
interrupts for backwards compatibility? I therefore held back RTD1619
irq mux patches from my irqchip v4 series [1].
The BSP DT does assign non-mux interrupts to the UART node like you did:
https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/arch/arm64/boot/dts/realtek/rtd16xx/rtd-16xx.dtsi
And I obviously trust that you tested your DT to produce serial output.
Also note how there are UR1_TO and UR2_TO (TO = timeout?) in addition to
regular UR1 and UR2 interrupts in the mux above, just as for RTD1295 and
RTD1195 (UR1/UR1_TO only). From my irqmux v4 series posted last night I
had to drop those additional interrupts property values from the DT [2],
as they violate mainline's DesignWare DT schema's maxItems 1 and would
require a new compatible string (and a driver patch to make use of it).
https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/drivers/irqchip/irq-rtd119x.h
https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/drivers/irqchip/irq-rtd129x.h
https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/drivers/irqchip/irq-rtd139x.h
Regards,
Andreas
[1] https://patchwork.kernel.org/cover/11250643/
[2] https://patchwork.kernel.org/patch/11250645/
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-19 9:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 8:00 [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir James Tai
2019-11-06 8:28 ` Andreas Färber
2019-11-08 15:36 ` James Tai
2019-11-08 17:17 ` Andreas Färber
2019-11-11 2:58 ` James Tai
2019-11-15 1:08 ` Andreas Färber
2019-11-17 15:39 ` James Tai
2019-11-22 9:43 ` Marc Zyngier
2019-11-22 12:48 ` Andreas Färber
2019-11-23 8:40 ` James Tai
2019-11-11 3:09 ` Andreas Färber
2019-11-19 9:11 ` Andreas Färber [this message]
2019-11-20 7:58 ` James Tai
2019-11-22 3:03 ` Andreas Färber
2019-11-23 8:51 ` James Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6182b89f-cd7e-ce7c-56f7-e2f500321cde@suse.de \
--to=afaerber@suse.de \
--cc=james.tai@realtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).