From: "Andreas Färber" <afaerber@suse.de>
To: James Tai <james.tai@realtek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-realtek-soc@lists.infradead.org"
<linux-realtek-soc@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir
Date: Fri, 22 Nov 2019 04:03:01 +0100 [thread overview]
Message-ID: <6d44e7f8-1ae5-ed3d-ac3c-0ee7903d660b@suse.de> (raw)
In-Reply-To: <993d5da60a87443995347ee2a4c74959@realtek.com>
Hi James,
Am 20.11.19 um 08:58 schrieb James Tai:
>> This conflicts with what I see in BSP irq mux code here:
>> https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/drivers/ir
>> qchip/irq-rtd16xx.h
>>
>> That does show UR0 as bit 2 for the iso irq mux, as for previous SoCs.
>> Is that code wrong, or does the same UART0 IP block have two alternative
>> interrupts for backwards compatibility? I therefore held back RTD1619 irq mux
>> patches from my irqchip v4 series [1].
>>
> It is code wrong. The UR0 should remove from "irq-rtd16xx.h".
Actually, I just tested that UR0 works! (rev A01) So we shouldn't remove
it from the irqchip driver, given the mapping changes requested for v5.
RTD1619 driver support and DT nodes pushed to my rtd1295-next branch.
>> The BSP DT does assign non-mux interrupts to the UART node like you did:
>> https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/master/linux-rtk/arch/arm
>> 64/boot/dts/realtek/rtd16xx/rtd-16xx.dtsi
>> And I obviously trust that you tested your DT to produce serial output.
We should obviously leave the new GIC interrupts in the DT.
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-22 3:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 8:00 [PATCH] arm64: dts: realtek: Add Realtek rtd1619 and mjolnir James Tai
2019-11-06 8:28 ` Andreas Färber
2019-11-08 15:36 ` James Tai
2019-11-08 17:17 ` Andreas Färber
2019-11-11 2:58 ` James Tai
2019-11-15 1:08 ` Andreas Färber
2019-11-17 15:39 ` James Tai
2019-11-22 9:43 ` Marc Zyngier
2019-11-22 12:48 ` Andreas Färber
2019-11-23 8:40 ` James Tai
2019-11-11 3:09 ` Andreas Färber
2019-11-19 9:11 ` Andreas Färber
2019-11-20 7:58 ` James Tai
2019-11-22 3:03 ` Andreas Färber [this message]
2019-11-23 8:51 ` James Tai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d44e7f8-1ae5-ed3d-ac3c-0ee7903d660b@suse.de \
--to=afaerber@suse.de \
--cc=james.tai@realtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-realtek-soc@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).