From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: David Virag <virag.david003@gmail.com>
Cc: Sam Protsenko <semen.protsenko@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC
Date: Mon, 31 Jan 2022 16:35:16 +0100 [thread overview]
Message-ID: <7941a6b8-4bca-797e-2fa9-ebd82bed70fa@canonical.com> (raw)
In-Reply-To: <20211206153124.427102-8-virag.david003@gmail.com>
On 06/12/2021 16:31, David Virag wrote:
> Add initial Exynos7885 device tree nodes with dts for the Samsung Galaxy
> A8 (2018), a.k.a. "jackpotlte", with model number "SM-A530F".
> Currently this includes some clock support, UART support, and I2C nodes.
>
> Signed-off-by: David Virag <virag.david003@gmail.com>
> ---
> Changes in v2:
> - Remove address-cells, and size-cells from dts, since they are
> already in the dtsi.
> - Lower case hex in memory node
> - Fix node names with underscore instead of hyphen
> - Fix line breaks
> - Fix "-key" missing from gpio keys node names
> - Use the form without "key" in gpio key labels on all keys
> - Suffix pin configuration node names with "-pins"
> - Remove "fimc_is_mclk" nodes from pinctrl dtsi for now
> - Use macros for "samsung,pin-con-pdn", and "samsung,pin-con-pdn"
> - Add comment about Arm PMU
> - Rename "clock-oscclk" to "osc-clock"
> - Include exynos-syscon-restart.dtsi instead of rewriting its contents
>
> Changes in v3:
> - Fix typo (seperate -> separate)
>
> Changes in v4:
> - Fixed leading 0x in clock-controller nodes
> - Actually suffixed pin configuration node names with "-pins"
> - Seperated Cortex-A53 and Cortex-A73 PMU
>
Hi David,
I hope you are well and did not get discouraged with this patchset. The
clock changes got merged, so if you fix the comments pointed here, I
could merge it.
One more change will be needed - use "-gpio-bank" suffix, like here:
https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=for-v5.18/dt-pinctrl&id=71b8d1253b7fe0be0ecf79a7249389c8711f0f94
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-31 15:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 15:31 [PATCH v4 0/7] Initial Samsung Galaxy A8 (2018) support David Virag
2021-12-06 15:31 ` [PATCH v4 1/7] dt-bindings: clock: Add bindings definitions for Exynos7885 CMU David Virag
2021-12-07 18:15 ` Sam Protsenko
2021-12-10 21:26 ` Rob Herring
2021-12-12 18:39 ` Krzysztof Kozlowski
2021-12-20 9:40 ` Krzysztof Kozlowski
2021-12-19 22:52 ` Sylwester Nawrocki
2021-12-06 15:31 ` [PATCH v4 2/7] dt-bindings: clock: Document Exynos7885 CMU bindings David Virag
2021-12-07 18:23 ` Sam Protsenko
2021-12-10 21:28 ` Rob Herring
2021-12-06 15:31 ` [PATCH v4 3/7] dt-bindings: arm: samsung: document jackpotlte board binding David Virag
2021-12-07 18:26 ` Sam Protsenko
2021-12-10 21:30 ` Rob Herring
2021-12-15 16:21 ` (subset) " Krzysztof Kozlowski
2021-12-19 14:53 ` David Virag
2021-12-20 9:38 ` Krzysztof Kozlowski
2021-12-06 15:31 ` [PATCH v4 4/7] clk: samsung: Make exynos850_register_cmu shared David Virag
2021-12-07 9:32 ` Krzysztof Kozlowski
2021-12-07 18:53 ` Sam Protsenko
2021-12-06 15:31 ` [PATCH v4 5/7] clk: samsung: clk-pll: Add support for pll1417x David Virag
2021-12-07 19:00 ` Sam Protsenko
2021-12-08 8:50 ` Krzysztof Kozlowski
2021-12-06 15:31 ` [PATCH v4 6/7] clk: samsung: Add initial Exynos7885 clock driver David Virag
2021-12-07 9:33 ` Krzysztof Kozlowski
2021-12-07 19:14 ` Sam Protsenko
2021-12-06 15:31 ` [PATCH v4 7/7] arm64: dts: exynos: Add initial device tree support for Exynos7885 SoC David Virag
2021-12-07 9:39 ` Krzysztof Kozlowski
2021-12-07 19:42 ` Marc Zyngier
2021-12-19 14:36 ` David Virag
2021-12-20 8:44 ` Marc Zyngier
2021-12-07 20:19 ` Sam Protsenko
2021-12-07 22:29 ` David Virag
2021-12-08 0:55 ` Chanho Park
2021-12-08 9:05 ` Krzysztof Kozlowski
2021-12-08 15:37 ` Sam Protsenko
2021-12-08 16:28 ` Krzysztof Kozlowski
2021-12-08 16:51 ` Sam Protsenko
2022-01-31 15:35 ` Krzysztof Kozlowski [this message]
2022-02-01 0:47 ` David Virag
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7941a6b8-4bca-797e-2fa9-ebd82bed70fa@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=virag.david003@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).