* [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard
@ 2021-04-09 7:11 Michael Kao
2021-04-09 7:16 ` Hsin-Yi Wang
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kao @ 2021-04-09 7:11 UTC (permalink / raw)
To: michael.kao, fan.chen, Zhang Rui, Daniel Lezcano, linux-pm,
srv_heupstream
Cc: Eduardo Valentin, Rob Herring, Mark Rutland, Matthias Brugger,
hsinyi, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek
Add Tboard thermal sensor settings.
pull-up voltage: 1800 mv
pull-up resistor: 75K
Vsense = pull-up voltage * Rntc / ( pull-up resistor + Rntc )
AuxIn = Vsense * 4096 / 1500
TEST=boot kukui
check /sys/class/thermal/thermal_zone*/type
check /sys/class/thermal/thermal_zone*/temp
Signed-off-by: Michael Kao <michael.kao@mediatek.com>
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index bf2ad1294dd3..202acb542b12 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -801,6 +801,20 @@
status = "okay";
};
+&thermal_zones {
+ Tboard1 {
+ polling-delay = <1000>; /* milliseconds */
+ polling-delay-passive = <0>; /* milliseconds */
+ thermal-sensors = <&tboard_thermistor1>;
+ };
+
+ Tboard2 {
+ polling-delay = <1000>; /* milliseconds */
+ polling-delay-passive = <0>; /* milliseconds */
+ thermal-sensors = <&tboard_thermistor2>;
+ };
+};
+
&u3phy {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 1ad0a1d55d53..f0719dbef249 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -673,7 +673,7 @@
nvmem-cell-names = "calibration-data";
};
- thermal-zones {
+ thermal_zones: thermal-zones {
cpu_thermal: cpu_thermal {
polling-delay-passive = <100>;
polling-delay = <500>;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard
2021-04-09 7:11 [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard Michael Kao
@ 2021-04-09 7:16 ` Hsin-Yi Wang
2021-05-06 5:11 ` Michael Kao
0 siblings, 1 reply; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-04-09 7:16 UTC (permalink / raw)
To: Michael Kao
Cc: fan.chen, Zhang Rui, Daniel Lezcano, Linux PM, srv_heupstream,
Eduardo Valentin, Rob Herring, Mark Rutland, Matthias Brugger,
Devicetree List, lkml,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support
On Fri, Apr 9, 2021 at 3:12 PM Michael Kao <michael.kao@mediatek.com> wrote:
>
> Add Tboard thermal sensor settings.
>
> pull-up voltage: 1800 mv
> pull-up resistor: 75K
>
> Vsense = pull-up voltage * Rntc / ( pull-up resistor + Rntc )
> AuxIn = Vsense * 4096 / 1500
>
> TEST=boot kukui
> check /sys/class/thermal/thermal_zone*/type
> check /sys/class/thermal/thermal_zone*/temp
the TEST lines can be removed.
>
> Signed-off-by: Michael Kao <michael.kao@mediatek.com>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> ---
Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>
This removes following error:
[ 10.882325] generic-adc-thermal thermal-sensor1: Thermal zone
sensor register failed: -19
[ 10.911912] generic-adc-thermal thermal-sensor2: Thermal zone
sensor register failed: -19
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index bf2ad1294dd3..202acb542b12 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -801,6 +801,20 @@
> status = "okay";
> };
>
> +&thermal_zones {
> + Tboard1 {
> + polling-delay = <1000>; /* milliseconds */
> + polling-delay-passive = <0>; /* milliseconds */
> + thermal-sensors = <&tboard_thermistor1>;
> + };
> +
> + Tboard2 {
> + polling-delay = <1000>; /* milliseconds */
> + polling-delay-passive = <0>; /* milliseconds */
> + thermal-sensors = <&tboard_thermistor2>;
> + };
> +};
> +
> &u3phy {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 1ad0a1d55d53..f0719dbef249 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -673,7 +673,7 @@
> nvmem-cell-names = "calibration-data";
> };
>
> - thermal-zones {
> + thermal_zones: thermal-zones {
> cpu_thermal: cpu_thermal {
> polling-delay-passive = <100>;
> polling-delay = <500>;
> --
> 2.18.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard
2021-04-09 7:16 ` Hsin-Yi Wang
@ 2021-05-06 5:11 ` Michael Kao
0 siblings, 0 replies; 3+ messages in thread
From: Michael Kao @ 2021-05-06 5:11 UTC (permalink / raw)
To: Hsin-Yi Wang, Daniel Lezcano, Ben.Tseng
Cc: fan.chen, Zhang Rui, Daniel Lezcano, Linux PM, srv_heupstream,
Eduardo Valentin, Rob Herring, Mark Rutland, Matthias Brugger,
Devicetree List, lkml,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support
Hi Maintainers,
Gentle pin for this patch.
Thanks
On Fri, 2021-04-09 at 15:16 +0800, Hsin-Yi Wang wrote:
> On Fri, Apr 9, 2021 at 3:12 PM Michael Kao <michael.kao@mediatek.com>
> wrote:
> >
> > Add Tboard thermal sensor settings.
> >
> > pull-up voltage: 1800 mv
> > pull-up resistor: 75K
> >
> > Vsense = pull-up voltage * Rntc / ( pull-up resistor + Rntc )
> > AuxIn = Vsense * 4096 / 1500
> >
> > TEST=boot kukui
> > check /sys/class/thermal/thermal_zone*/type
> > check /sys/class/thermal/thermal_zone*/temp
>
> the TEST lines can be removed.
>
> >
> > Signed-off-by: Michael Kao <michael.kao@mediatek.com>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> > ---
>
> Tested-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> This removes following error:
> [ 10.882325] generic-adc-thermal thermal-sensor1: Thermal zone
> sensor register failed: -19
> [ 10.911912] generic-adc-thermal thermal-sensor2: Thermal zone
> sensor register failed: -19
>
> > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
> > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
> > 2 files changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > index bf2ad1294dd3..202acb542b12 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> > @@ -801,6 +801,20 @@
> > status = "okay";
> > };
> >
> > +&thermal_zones {
> > + Tboard1 {
> > + polling-delay = <1000>; /* milliseconds */
> > + polling-delay-passive = <0>; /* milliseconds */
> > + thermal-sensors = <&tboard_thermistor1>;
> > + };
> > +
> > + Tboard2 {
> > + polling-delay = <1000>; /* milliseconds */
> > + polling-delay-passive = <0>; /* milliseconds */
> > + thermal-sensors = <&tboard_thermistor2>;
> > + };
> > +};
> > +
> > &u3phy {
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 1ad0a1d55d53..f0719dbef249 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -673,7 +673,7 @@
> > nvmem-cell-names = "calibration-data";
> > };
> >
> > - thermal-zones {
> > + thermal_zones: thermal-zones {
> > cpu_thermal: cpu_thermal {
> > polling-delay-passive = <100>;
> > polling-delay = <500>;
> > --
> > 2.18.0
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-06 5:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-09 7:11 [PATCH 1/1] arm64: dts: mt8183-kukui: Enable thermal Tboard Michael Kao
2021-04-09 7:16 ` Hsin-Yi Wang
2021-05-06 5:11 ` Michael Kao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).