From: Rajendra Nayak <rnayak@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Doug Anderson <dianders@chromium.org>,
Rob Herring <robh@kernel.org>
Cc: Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
freedreno <freedreno@lists.freedesktop.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Viresh Kumar <vireshk@kernel.org>
Subject: Re: [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes
Date: Fri, 21 Dec 2018 10:22:34 +0530 [thread overview]
Message-ID: <7e310416-78d3-b7e5-5013-0bcc8bfd0351@codeaurora.org> (raw)
In-Reply-To: <154534136449.79149.14097954220921296509@swboyd.mtv.corp.google.com>
On 12/21/2018 2:59 AM, Stephen Boyd wrote:
> Quoting Rob Herring (2018-12-19 15:47:25)
>> On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson <dianders@chromium.org> wrote:
>>> On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson <dianders@chromium.org> wrote:
>>>> On Wed, Dec 19, 2018 at 12:09 PM Rob Herring <robh@kernel.org> wrote:
>>>> ...but it does have a frequency, doesn't it?
>>>>
>>>> + compatible = "operating-points-v2-qcom-level";
>>>> +
>>>> + opp-710000000 {
>>>> + opp-hz = /bits/ 64 <710000000>;
>>>> + qcom,level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
>>>> + };
>>>
>>> Ah, I perhaps see the confusion. So Rajendra's usage of
>>> "operating-points-v2-qcom-level" [1] doesn't have a frequency but
>>> Jordan's do. So I guess it makes sense that Jordan's have the
>>> fallback compatible but Rajendra's don't?
>>
>> Is having it useful to s/w that doesn't understand
>> "operating-points-v2-qcom-level"? If so, then add
>> "operating-points-v2". If not, then don't.
>
> The only benefit I see in having "operating-points-v2" is that we don't
> need to update the of_skipped_node_table[] in drivers/platform/of.c to
> have all the variants of operating-points-v2-* when they decide to not
> use anything from the "base" binding.
>
> If that fails to work because opp-hz is required for the
> "operating-points-v2" binding but sometimes
> operating-points-v2-qcom-level doesn't require it I guess we need to
> update the skip table or make some generic property like
> 'this-is-not-a-device' that these various data tables in DT can be
> marked with so we don't make platform devices for them.
>
> Regardless of the above, we should update the binding for
> operating-points-v2-qcom-level to say that opp-hz isn't always required
> when the qcom-level compatible is present. It looks like it just says
> that it builds on top of the opp binding so that's not obvious.
Sure, I can respin with those details added in.
So I am guessing the conclusion is to use a fallback "operating-points-v2"
compatible *only* when we do have opp-hz along with qcom,level (as in the
case with gpu) and not have a fallback compatible in cases when we don't
have opp-hz (as in the case of rpm power domains)?
That seems a little inconsistent, and given Rob said either way is fine,
just do one way or the other and not both, I am inclined to think we should
just have a "operating-points-v2-qcom-level" and no fallback compatible.
Does that make sense?
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-21 4:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 21:18 [PATCH v6 0/2] arm64: dts: Add sdm845 GPU/GMU and SMMU Jordan Crouse
2018-12-12 21:18 ` [PATCH v6 1/2] dt-bindings: drm/msm/a6xx: Document GMU and update GPU bindings Jordan Crouse
2018-12-13 18:39 ` Doug Anderson
2018-12-17 21:20 ` Rob Herring
2018-12-17 22:01 ` Jordan Crouse
2018-12-12 21:18 ` [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes Jordan Crouse
2018-12-13 18:40 ` Doug Anderson
2018-12-14 4:40 ` Viresh Kumar
2018-12-14 17:04 ` Doug Anderson
2018-12-17 7:06 ` Viresh Kumar
2018-12-18 0:34 ` Doug Anderson
2018-12-18 18:40 ` Stephen Boyd
2018-12-18 19:05 ` Doug Anderson
2018-12-19 4:49 ` Viresh Kumar
2018-12-19 20:08 ` Rob Herring
2018-12-19 20:40 ` Doug Anderson
2018-12-19 22:40 ` Doug Anderson
2018-12-19 23:47 ` Rob Herring
2018-12-20 21:29 ` Stephen Boyd
2018-12-21 4:52 ` Rajendra Nayak [this message]
2018-12-29 1:29 ` Stephen Boyd
2019-01-03 8:45 ` Rajendra Nayak
2019-01-04 20:59 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e310416-78d3-b7e5-5013-0bcc8bfd0351@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).