* [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property
@ 2022-09-29 14:04 Johan Jonker
2022-09-30 19:55 ` Rob Herring
2022-10-03 7:49 ` Johan Jonker
0 siblings, 2 replies; 3+ messages in thread
From: Johan Jonker @ 2022-09-29 14:04 UTC (permalink / raw)
To: heiko
Cc: thierry.reding, u.kleine-koenig, robh+dt, krzysztof.kozlowski+dt,
sebastian.reichel, wxt, kever.yang, linux-pwm, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
The Rockchip SoCs have 4 or more built-in PWM channels.
Configurable to operate in capture mode.
Measures the high/low polarity effective cycles of this input waveform
Generates a single interrupt at the transition of input waveform polarity
Configurable to operate in continuous mode or one-shot mode.
One-shot operation will produce N + 1 periods of the waveform,
where N is the repeat counter value, and generates a single interrupt at
the end of operation.
Continuous mode generates the waveform continuously and
do not generates any interrupts.
Older SoCs have an interrupt for each node.
Newer models share an interrupt.
Add interrupts property to the pwm-rockchip.yaml file.
DT describes hardware. Rockchip PWM driver support for
interrupts might not available.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
index f2d1dc7e7..f7634069d 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
@@ -37,6 +37,9 @@ properties:
reg:
maxItems: 1
+ interrupts:
+ maxItems: 1
+
clocks:
minItems: 1
maxItems: 2
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property
2022-09-29 14:04 [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property Johan Jonker
@ 2022-09-30 19:55 ` Rob Herring
2022-10-03 7:49 ` Johan Jonker
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-09-30 19:55 UTC (permalink / raw)
To: Johan Jonker
Cc: linux-pwm, thierry.reding, linux-rockchip, u.kleine-koenig,
krzysztof.kozlowski+dt, wxt, linux-kernel, heiko, robh+dt,
devicetree, kever.yang, sebastian.reichel, linux-arm-kernel
On Thu, 29 Sep 2022 16:04:00 +0200, Johan Jonker wrote:
> The Rockchip SoCs have 4 or more built-in PWM channels.
>
> Configurable to operate in capture mode.
> Measures the high/low polarity effective cycles of this input waveform
> Generates a single interrupt at the transition of input waveform polarity
>
> Configurable to operate in continuous mode or one-shot mode.
> One-shot operation will produce N + 1 periods of the waveform,
> where N is the repeat counter value, and generates a single interrupt at
> the end of operation.
> Continuous mode generates the waveform continuously and
> do not generates any interrupts.
>
> Older SoCs have an interrupt for each node.
> Newer models share an interrupt.
>
> Add interrupts property to the pwm-rockchip.yaml file.
> DT describes hardware. Rockchip PWM driver support for
> interrupts might not available.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property
2022-09-29 14:04 [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property Johan Jonker
2022-09-30 19:55 ` Rob Herring
@ 2022-10-03 7:49 ` Johan Jonker
1 sibling, 0 replies; 3+ messages in thread
From: Johan Jonker @ 2022-10-03 7:49 UTC (permalink / raw)
To: heiko
Cc: thierry.reding, u.kleine-koenig, robh+dt, krzysztof.kozlowski+dt,
sebastian.reichel, wxt, kever.yang, linux-pwm, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On 9/29/22 16:04, Johan Jonker wrote:
> The Rockchip SoCs have 4 or more built-in PWM channels.
>
> Configurable to operate in capture mode.
> Measures the high/low polarity effective cycles of this input waveform
> Generates a single interrupt at the transition of input waveform polarity
>
> Configurable to operate in continuous mode or one-shot mode.
> One-shot operation will produce N + 1 periods of the waveform,
> where N is the repeat counter value, and generates a single interrupt at
> the end of operation.
> Continuous mode generates the waveform continuously and
> do not generates any interrupts.
>
> Older SoCs have an interrupt for each node.
> Newer models share an interrupt.
As mentioned by Robin the common interrupt status registers are located outside the PWM node reg range.
The Rockchip PWM driver is only focused on continuous mode, while these interrupts only for "Capture mode" and "One-shot mode" and need a different handling.
Interrupts without reg resources is not going to work well,
so I think this patch can go in the garbage bin.
>
> Add interrupts property to the pwm-rockchip.yaml file.
> DT describes hardware. Rockchip PWM driver support for
> interrupts might not available.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> index f2d1dc7e7..f7634069d 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> @@ -37,6 +37,9 @@ properties:
> reg:
> maxItems: 1
>
> + interrupts:
> + maxItems: 1
> +
> clocks:
> minItems: 1
> maxItems: 2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-03 7:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 14:04 [RFC PATCH v1 1/2] dt-bindings: pwm: rockchip: add interrupts property Johan Jonker
2022-09-30 19:55 ` Rob Herring
2022-10-03 7:49 ` Johan Jonker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).