* [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells
@ 2023-01-12 18:48 Andy Shevchenko
2023-01-12 18:48 ` [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Andy Shevchenko
2023-01-12 19:28 ` [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Baruch Siach
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-01-12 18:48 UTC (permalink / raw)
To: Linus Walleij, Jianlong Huang, Andy Shevchenko, linux-gpio,
linux-kernel, linux-arm-kernel
Cc: Baruch Siach
The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/pinctrl-digicolor.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
index cc3546fc4610..05213261b8a4 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap)
chip->set = dc_gpio_set;
chip->base = -1;
chip->ngpio = PINS_COUNT;
- chip->of_gpio_n_cells = 2;
spin_lock_init(&pmap->lock);
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency
2023-01-12 18:48 [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
@ 2023-01-12 18:48 ` Andy Shevchenko
2023-01-12 19:30 ` Baruch Siach
2023-01-16 14:06 ` Linus Walleij
2023-01-12 19:28 ` [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Baruch Siach
1 sibling, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-01-12 18:48 UTC (permalink / raw)
To: Linus Walleij, Jianlong Huang, Andy Shevchenko, linux-gpio,
linux-kernel, linux-arm-kernel
Cc: Baruch Siach
The driver doesn't depend on the OF to be complied. Hence
the proper header to use is mod_devicetable.h. Replace of*.h with
the above mentioned and drop redundant dependency.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/Kconfig | 2 +-
drivers/pinctrl/pinctrl-digicolor.c | 9 +++++----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 476f3cbbdce0..1e44708201ad 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -170,7 +170,7 @@ config PINCTRL_DA9062
config PINCTRL_DIGICOLOR
bool
- depends on OF && (ARCH_DIGICOLOR || COMPILE_TEST)
+ depends on ARCH_DIGICOLOR || COMPILE_TEST
select PINMUX
select GENERIC_PINCONF
diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
index 05213261b8a4..a0423172bdd6 100644
--- a/drivers/pinctrl/pinctrl-digicolor.c
+++ b/drivers/pinctrl/pinctrl-digicolor.c
@@ -11,18 +11,19 @@
* - Pin pad configuration (pull up/down, strength)
*/
+#include <linux/gpio/driver.h>
#include <linux/init.h>
-#include <linux/platform_device.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
#include <linux/io.h>
-#include <linux/gpio/driver.h>
+#include <linux/mod_devicetable.h>
+#include <linux/platform_device.h>
#include <linux/spinlock.h>
+
#include <linux/pinctrl/machine.h>
#include <linux/pinctrl/pinconf.h>
#include <linux/pinctrl/pinconf-generic.h>
#include <linux/pinctrl/pinctrl.h>
#include <linux/pinctrl/pinmux.h>
+
#include "pinctrl-utils.h"
#define DRIVER_NAME "pinctrl-digicolor"
--
2.39.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells
2023-01-12 18:48 [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-12 18:48 ` [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Andy Shevchenko
@ 2023-01-12 19:28 ` Baruch Siach
1 sibling, 0 replies; 5+ messages in thread
From: Baruch Siach @ 2023-01-12 19:28 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Jianlong Huang, linux-gpio, linux-kernel,
linux-arm-kernel
Hi Andy,
On Thu, Jan 12 2023, Andy Shevchenko wrote:
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
baruch
> ---
> drivers/pinctrl/pinctrl-digicolor.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index cc3546fc4610..05213261b8a4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -248,7 +248,6 @@ static int dc_gpiochip_add(struct dc_pinmap *pmap)
> chip->set = dc_gpio_set;
> chip->base = -1;
> chip->ngpio = PINS_COUNT;
> - chip->of_gpio_n_cells = 2;
>
> spin_lock_init(&pmap->lock);
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency
2023-01-12 18:48 ` [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Andy Shevchenko
@ 2023-01-12 19:30 ` Baruch Siach
2023-01-16 14:06 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Baruch Siach @ 2023-01-12 19:30 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Jianlong Huang, linux-gpio, linux-kernel,
linux-arm-kernel
Hi Andy,
On Thu, Jan 12 2023, Andy Shevchenko wrote:
> The driver doesn't depend on the OF to be complied. Hence
> the proper header to use is mod_devicetable.h. Replace of*.h with
> the above mentioned and drop redundant dependency.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
baruch
> ---
> drivers/pinctrl/Kconfig | 2 +-
> drivers/pinctrl/pinctrl-digicolor.c | 9 +++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 476f3cbbdce0..1e44708201ad 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -170,7 +170,7 @@ config PINCTRL_DA9062
>
> config PINCTRL_DIGICOLOR
> bool
> - depends on OF && (ARCH_DIGICOLOR || COMPILE_TEST)
> + depends on ARCH_DIGICOLOR || COMPILE_TEST
> select PINMUX
> select GENERIC_PINCONF
>
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index 05213261b8a4..a0423172bdd6 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -11,18 +11,19 @@
> * - Pin pad configuration (pull up/down, strength)
> */
>
> +#include <linux/gpio/driver.h>
> #include <linux/init.h>
> -#include <linux/platform_device.h>
> -#include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/io.h>
> -#include <linux/gpio/driver.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/platform_device.h>
> #include <linux/spinlock.h>
> +
> #include <linux/pinctrl/machine.h>
> #include <linux/pinctrl/pinconf.h>
> #include <linux/pinctrl/pinconf-generic.h>
> #include <linux/pinctrl/pinctrl.h>
> #include <linux/pinctrl/pinmux.h>
> +
> #include "pinctrl-utils.h"
>
> #define DRIVER_NAME "pinctrl-digicolor"
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency
2023-01-12 18:48 ` [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Andy Shevchenko
2023-01-12 19:30 ` Baruch Siach
@ 2023-01-16 14:06 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2023-01-16 14:06 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jianlong Huang, linux-gpio, linux-kernel, linux-arm-kernel, Baruch Siach
On Thu, Jan 12, 2023 at 7:48 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The driver doesn't depend on the OF to be complied. Hence
> the proper header to use is mod_devicetable.h. Replace of*.h with
> the above mentioned and drop redundant dependency.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Both patches applied!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-16 14:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-12 18:48 [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-12 18:48 ` [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Andy Shevchenko
2023-01-12 19:30 ` Baruch Siach
2023-01-16 14:06 ` Linus Walleij
2023-01-12 19:28 ` [PATCH v1 1/2] pinctrl: digicolor: Remove duplicate assignment of of_gpio_n_cells Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).