* [PATCH] bus: arm: integrator: fix device node iterator leak
@ 2020-09-25 23:55 Tobias Jordan
2020-09-30 8:29 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Jordan @ 2020-09-25 23:55 UTC (permalink / raw)
To: Linus Walleij, linux-arm-kernel, linux-kernel
In the for_each_available_child_of_node loop of integrator_lm_populate,
add a call to of_node_put to avoid leaking the iterator if we bail out.
Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")
Signed-off-by: Tobias Jordan <kernel@cdqe.de>
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..cb6da80d1c7d 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -53,6 +53,7 @@ static int integrator_lm_populate(int num, struct device *dev)
base);
ret = of_platform_default_populate(child, NULL, dev);
if (ret) {
+ of_node_put(child);
dev_err(dev, "failed to populate module\n");
return ret;
}
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bus: arm: integrator: fix device node iterator leak
2020-09-25 23:55 [PATCH] bus: arm: integrator: fix device node iterator leak Tobias Jordan
@ 2020-09-30 8:29 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-09-30 8:29 UTC (permalink / raw)
To: Tobias Jordan, Sumera Priyadarsini; +Cc: linux-kernel, Linux ARM
On Sat, Sep 26, 2020 at 1:55 AM Tobias Jordan <kernel@cdqe.de> wrote:
> In the for_each_available_child_of_node loop of integrator_lm_populate,
> add a call to of_node_put to avoid leaking the iterator if we bail out.
>
> Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")
> Signed-off-by: Tobias Jordan <kernel@cdqe.de>
Incidentally, Sumera Priyadarsini has already fixed this.
Thanks anyway!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-30 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25 23:55 [PATCH] bus: arm: integrator: fix device node iterator leak Tobias Jordan
2020-09-30 8:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).