* [RESEND PATCH v7 0/2] Add support cbas tablet mode switch to mt8183
@ 2021-05-14 12:20 Ikjoon Jang
2021-05-14 12:20 ` [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device Ikjoon Jang
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
0 siblings, 2 replies; 7+ messages in thread
From: Ikjoon Jang @ 2021-05-14 12:20 UTC (permalink / raw)
To: devicetree, Lee Jones
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Enric Balletbo i Serra, Benson Leung, linux-input,
Hsin-Yi Wang, Jiri Kosina, Stephen Boyd, Ikjoon Jang,
Rob Herring
Adding a cbas support for kukui platforms which has a tablet mode
switch through cros-ec interface.
---
Sorry for resending v7, I found some CCs were missing
and errata in email addresses.
Changes in v7:
- remove a label in cbas node in mt8183-kukui.dtsi
- fix an erratum in commit message (table --> tablet)
- dt-binding patche merged altogether with mt8183 dts
Changes in v6:
- Remove a label for cbas node in a example of dt-binding doc
Changes in v5:
- Add missing blank lines and change the description property's position.
- Add a note to description: "this device cannot be detected at runtime."
Changes in v4:
- Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.
Ikjoon Jang (2):
mfd: google,cros-ec: add DT bindings for a baseboard's switch device
arm64: dts: mt8183: add cbas node under cros_ec
.../bindings/mfd/google,cros-ec.yaml | 20 +++++++++++++++++++
.../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
2 files changed, 24 insertions(+)
--
2.31.1.751.gd2f1c929bd-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device
2021-05-14 12:20 [RESEND PATCH v7 0/2] Add support cbas tablet mode switch to mt8183 Ikjoon Jang
@ 2021-05-14 12:20 ` Ikjoon Jang
2021-05-17 22:42 ` Stephen Boyd
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
1 sibling, 1 reply; 7+ messages in thread
From: Ikjoon Jang @ 2021-05-14 12:20 UTC (permalink / raw)
To: devicetree, Lee Jones
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Enric Balletbo i Serra, Benson Leung, linux-input,
Hsin-Yi Wang, Jiri Kosina, Stephen Boyd, Ikjoon Jang,
Rob Herring, Rob Herring
This is for ChromeOS tablets which have a 'cros_cbas' switch device
in the "Whiskers" base board. This device can be instantiated only by
device tree on ARM platforms. ChromeOS EC doesn't provide a way to
probe the device.
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v7:
- no changes from v6
Changes in v6:
- Remove a label for cbas node in a example
Changes in v5:
- Add missing blank lines and change the description property's position.
- Add a note to description: "this device cannot be detected at runtime."
Changes in v4:
Define cros-cbase bindings inside google,cros-ec.yaml instead of
a separated binding document.
.../bindings/mfd/google,cros-ec.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
index 76bf16ee27ec..929c17552d8b 100644
--- a/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
+++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
@@ -114,6 +114,22 @@ properties:
- "#address-cells"
- "#size-cells"
+ cbas:
+ type: object
+
+ description:
+ This device is used to signal when a detachable base is attached
+ to a Chrome OS tablet. This device cannot be detected at runtime.
+
+ properties:
+ compatible:
+ const: google,cros-cbas
+
+ required:
+ - compatible
+
+ additionalProperties: false
+
patternProperties:
"^i2c-tunnel[0-9]*$":
type: object
@@ -180,6 +196,10 @@ examples:
interrupts = <99 0>;
interrupt-parent = <&gpio7>;
spi-max-frequency = <5000000>;
+
+ cbas {
+ compatible = "google,cros-cbas";
+ };
};
};
--
2.31.1.751.gd2f1c929bd-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec
2021-05-14 12:20 [RESEND PATCH v7 0/2] Add support cbas tablet mode switch to mt8183 Ikjoon Jang
2021-05-14 12:20 ` [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device Ikjoon Jang
@ 2021-05-14 12:20 ` Ikjoon Jang
2021-05-14 13:23 ` Enric Balletbo i Serra
` (2 more replies)
1 sibling, 3 replies; 7+ messages in thread
From: Ikjoon Jang @ 2021-05-14 12:20 UTC (permalink / raw)
To: devicetree, Lee Jones
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Enric Balletbo i Serra, Benson Leung, linux-input,
Hsin-Yi Wang, Jiri Kosina, Stephen Boyd, Ikjoon Jang,
Rob Herring
Add a 'cbas' device node for supporting tablet mode switch in
kukui devices.
Kukui platforms with detacheable base have an additional input
device under cros-ec, which reports SW_TABLET_MODE regarding
its base state (e.g. base flipped or detached).
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
---
Changes in v7:
- remove a label in cbas node
- fix an erratum in commit message (table --> tablet)
- dt-binding patchess merged altogether with mt8183 dts
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..1512605a438e 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
compatible = "google,extcon-usbc-cros-ec";
google,usb-port-id = <0>;
};
+
+ cbas {
+ compatible = "google,cros-cbas";
+ };
};
};
--
2.31.1.751.gd2f1c929bd-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
@ 2021-05-14 13:23 ` Enric Balletbo i Serra
2021-05-17 22:43 ` Stephen Boyd
2021-05-20 9:39 ` Enric Balletbo i Serra
2 siblings, 0 replies; 7+ messages in thread
From: Enric Balletbo i Serra @ 2021-05-14 13:23 UTC (permalink / raw)
To: Ikjoon Jang, devicetree, Lee Jones
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Benson Leung, linux-input, Hsin-Yi Wang,
Jiri Kosina, Stephen Boyd, Rob Herring
Hi Ikjoon,
Thank you for the patch.
On 14/5/21 14:20, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v7:
> - remove a label in cbas node
> - fix an erratum in commit message (table --> tablet)
> - dt-binding patchess merged altogether with mt8183 dts
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..1512605a438e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> compatible = "google,extcon-usbc-cros-ec";
> google,usb-port-id = <0>;
> };
> +
> + cbas {
> + compatible = "google,cros-cbas";
> + };
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device
2021-05-14 12:20 ` [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device Ikjoon Jang
@ 2021-05-17 22:42 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-05-17 22:42 UTC (permalink / raw)
To: Ikjoon Jang, Lee Jones, devicetree
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Enric Balletbo i Serra, Benson Leung, linux-input,
Hsin-Yi Wang, Jiri Kosina, Rob Herring, Rob Herring
Quoting Ikjoon Jang (2021-05-14 05:20:49)
> This is for ChromeOS tablets which have a 'cros_cbas' switch device
> in the "Whiskers" base board. This device can be instantiated only by
> device tree on ARM platforms. ChromeOS EC doesn't provide a way to
> probe the device.
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
2021-05-14 13:23 ` Enric Balletbo i Serra
@ 2021-05-17 22:43 ` Stephen Boyd
2021-05-20 9:39 ` Enric Balletbo i Serra
2 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2021-05-17 22:43 UTC (permalink / raw)
To: Ikjoon Jang, Lee Jones, devicetree
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Enric Balletbo i Serra, Benson Leung, linux-input,
Hsin-Yi Wang, Jiri Kosina, Rob Herring
Quoting Ikjoon Jang (2021-05-14 05:20:50)
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
2021-05-14 13:23 ` Enric Balletbo i Serra
2021-05-17 22:43 ` Stephen Boyd
@ 2021-05-20 9:39 ` Enric Balletbo i Serra
2 siblings, 0 replies; 7+ messages in thread
From: Enric Balletbo i Serra @ 2021-05-20 9:39 UTC (permalink / raw)
To: Ikjoon Jang, devicetree, Lee Jones
Cc: linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel,
Guenter Roeck, Benson Leung, linux-input, Hsin-Yi Wang,
Jiri Kosina, Stephen Boyd, Rob Herring
Hi Ikjoon,
Thank you for the patch.
On 14/5/21 14:20, Ikjoon Jang wrote:
> Add a 'cbas' device node for supporting tablet mode switch in
> kukui devices.
>
> Kukui platforms with detacheable base have an additional input
> device under cros-ec, which reports SW_TABLET_MODE regarding
> its base state (e.g. base flipped or detached).
>
> Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
> Changes in v7:
> - remove a label in cbas node
> - fix an erratum in commit message (table --> tablet)
> - dt-binding patchess merged altogether with mt8183 dts
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..1512605a438e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -816,6 +816,10 @@ usbc_extcon: extcon0 {
> compatible = "google,extcon-usbc-cros-ec";
> google,usb-port-id = <0>;
> };
> +
> + cbas {
> + compatible = "google,cros-cbas";
> + };
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-20 9:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 12:20 [RESEND PATCH v7 0/2] Add support cbas tablet mode switch to mt8183 Ikjoon Jang
2021-05-14 12:20 ` [RESEND PATCH v7 1/2] mfd: google, cros-ec: add DT bindings for a baseboard's switch device Ikjoon Jang
2021-05-17 22:42 ` Stephen Boyd
2021-05-14 12:20 ` [RESEND PATCH v7 2/2] arm64: dts: mt8183: add cbas node under cros_ec Ikjoon Jang
2021-05-14 13:23 ` Enric Balletbo i Serra
2021-05-17 22:43 ` Stephen Boyd
2021-05-20 9:39 ` Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).