[PATCH -next] PM / devfreq: exynos-ppmu: remove unneeded of_node_put()

[PATCH -next] PM / devfreq: exynos-ppmu: remove unneeded of_node_put()

[weiyj_lk at 163.com]

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/devfreq/event/exynos-ppmu.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
index 845bf25..f55cf0e 100644
--- a/drivers/devfreq/event/exynos-ppmu.c
+++ b/drivers/devfreq/event/exynos-ppmu.c
@@ -406,8 +406,6 @@ static int of_get_devfreq_events(struct device_node *np,
 		of_property_read_string(node, "event-name", &desc[j].name);
 
 		j++;
-
-		of_node_put(node);
 	}
 	info->desc = desc;

[PATCH -next] PM / devfreq: exynos-ppmu: remove unneeded of_node_put()

[MyungJoo Ham]

On Fri, Jul 8, 2016 at 10:44 PM,  <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> for_each_child_of_node() performs an of_node_put() on each iteration, so
> putting an of_node_put() before a continue results in a double put.
>
> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thank you!

Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>


> ---
>  drivers/devfreq/event/exynos-ppmu.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c
> index 845bf25..f55cf0e 100644
> --- a/drivers/devfreq/event/exynos-ppmu.c
> +++ b/drivers/devfreq/event/exynos-ppmu.c
> @@ -406,8 +406,6 @@ static int of_get_devfreq_events(struct device_node *np,
>                 of_property_read_string(node, "event-name", &desc[j].name);
>
>                 j++;
> -
> -               of_node_put(node);
>         }
>         info->desc = desc;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics

[PATCH -next] PM / devfreq: exynos-ppmu: remove unneeded of_node_put()

[Rafael J. Wysocki]

On Mon, Jul 11, 2016 at 4:19 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> On Fri, Jul 8, 2016 at 10:44 PM,  <weiyj_lk@163.com> wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> for_each_child_of_node() performs an of_node_put() on each iteration, so
>> putting an of_node_put() before a continue results in a double put.
>>
>> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Thank you!
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Do you want me to apply this one directly?

Thanks,
Rafael

[PATCH -next] PM / devfreq: exynos-ppmu: remove unneeded of_node_put()

[MyungJoo Ham]

On Mon, Jul 11, 2016 at 10:08 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Mon, Jul 11, 2016 at 4:19 AM, MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
>> On Fri, Jul 8, 2016 at 10:44 PM,  <weiyj_lk@163.com> wrote:
>>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>>
>>> for_each_child_of_node() performs an of_node_put() on each iteration, so
>>> putting an of_node_put() before a continue results in a double put.
>>>
>>> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
>>>
>>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Thank you!
>>
>> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>
> Do you want me to apply this one directly?

Sure, if you would do that, it'd be great.

Thank you.



Cheers,
MyungJoo


-- 
MyungJoo Ham, Ph.D.
S/W R&D Center, Samsung Electronics