* [PATCH 1/3] ARM: visit mach-* and plat-* directories when cleaning
@ 2019-04-08 7:54 Masahiro Yamada
2019-04-08 7:54 ` [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91 Masahiro Yamada
2019-04-08 7:54 ` [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Masahiro Yamada
0 siblings, 2 replies; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-08 7:54 UTC (permalink / raw)
To: arm, Olof Johansson, Arnd Bergmann
Cc: Masahiro Yamada, Russell King, linux-arm-kernel, linux-kernel
When you run "make clean" for arm, it never visits mach-* or plat-*
directories because machine-y and plat-y are just empty.
When cleaning, all machine, plat directories are accumulated to
machine-, plat-, respectively. So, let's pass them to core- to
clean up those directories.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 807a7d06c2a0..b6693a3ddcca 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -293,6 +293,10 @@ core-y += arch/arm/crypto/
core-y += arch/arm/firmware/
core-y += $(machdirs) $(platdirs)
+# For cleaning
+core- += $(patsubst %,arch/arm/mach-%/, $(machine-))
+core- += $(patsubst %,arch/arm/plat-%/, $(plat-))
+
drivers-$(CONFIG_OPROFILE) += arch/arm/oprofile/
libs-y := arch/arm/lib/ $(libs-y)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91
2019-04-08 7:54 [PATCH 1/3] ARM: visit mach-* and plat-* directories when cleaning Masahiro Yamada
@ 2019-04-08 7:54 ` Masahiro Yamada
2019-04-15 15:14 ` Alexandre Belloni
2019-04-08 7:54 ` [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Masahiro Yamada
1 sibling, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-08 7:54 UTC (permalink / raw)
To: arm, Olof Johansson, Arnd Bergmann
Cc: Alexandre Belloni, linux-kernel, Masahiro Yamada,
Ludovic Desroches, Russell King, linux-arm-kernel
<generated/at91_pm_data-offsets.h> is only generated and included
by arch/arm/mach-at91/, so it does not need to reside in the
globally visible include/generated/.
I moved and renamed it to arch/arm/mach-at91/pm_data-offsets.h
since the prefix 'at91_' is just redundant in mach-at91/.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Can this be applied to ARM-SOC tree in a series?
(with Ack from the platform sub-maintainer.)
at91_pm_data-offsets.h header does not need to reside in
include/generated/, but you may ask
"Why must it get out of include/generated/?"
My main motivation is to avoid a race condition in the currently
proposed patch:
https://lore.kernel.org/patchwork/patch/1052763/
This patch tries to embed some build artifacts into the kernel.
If arch/arm/mach-at91/ and kernel/ are built at the same time,
it may embed a truncated file.
arch/arm/mach-at91/.gitignore | 1 +
arch/arm/mach-at91/Makefile | 5 +++--
arch/arm/mach-at91/pm_suspend.S | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
create mode 100644 arch/arm/mach-at91/.gitignore
diff --git a/arch/arm/mach-at91/.gitignore b/arch/arm/mach-at91/.gitignore
new file mode 100644
index 000000000000..2ecd6f51c8a9
--- /dev/null
+++ b/arch/arm/mach-at91/.gitignore
@@ -0,0 +1 @@
+pm_data-offsets.h
diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
index 31b61f0e1c07..de64301dcff2 100644
--- a/arch/arm/mach-at91/Makefile
+++ b/arch/arm/mach-at91/Makefile
@@ -19,9 +19,10 @@ ifeq ($(CONFIG_PM_DEBUG),y)
CFLAGS_pm.o += -DDEBUG
endif
-include/generated/at91_pm_data-offsets.h: arch/arm/mach-at91/pm_data-offsets.s FORCE
+$(obj)/pm_data-offsets.h: $(obj)/pm_data-offsets.s FORCE
$(call filechk,offsets,__PM_DATA_OFFSETS_H__)
-arch/arm/mach-at91/pm_suspend.o: include/generated/at91_pm_data-offsets.h
+$(obj)/pm_suspend.o: $(obj)/pm_data-offsets.h
targets += pm_data-offsets.s
+clean-files += pm_data-offsets.h
diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
index bfe1c4d06901..a31c1b20f3fa 100644
--- a/arch/arm/mach-at91/pm_suspend.S
+++ b/arch/arm/mach-at91/pm_suspend.S
@@ -14,7 +14,7 @@
#include <linux/linkage.h>
#include <linux/clk/at91_pmc.h>
#include "pm.h"
-#include "generated/at91_pm_data-offsets.h"
+#include "pm_data-offsets.h"
#define SRAMC_SELF_FRESH_ACTIVE 0x01
#define SRAMC_SELF_FRESH_EXIT 0x00
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-08 7:54 [PATCH 1/3] ARM: visit mach-* and plat-* directories when cleaning Masahiro Yamada
2019-04-08 7:54 ` [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91 Masahiro Yamada
@ 2019-04-08 7:54 ` Masahiro Yamada
2019-04-08 16:18 ` Tony Lindgren
1 sibling, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-08 7:54 UTC (permalink / raw)
To: arm, Olof Johansson, Arnd Bergmann
Cc: Tony Lindgren, Russell King, linux-kernel, Masahiro Yamada,
linux-omap, linux-arm-kernel
<generated/ti-pm-asm-offsets.h> is only generated and included
by arch/arm/mach-omap2/, so it does not need to reside in the
globally visible include/generated/.
I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
since the prefix 'omap2-' is just redundant in mach-omap2/.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Can this be applied to ARM-SOC tree in a series?
(with Ack from the platform sub-maintainer.)
ti-pm-asm-offsets.h does not need to reside in include/generated/,
but you may ask "Why must it get out of include/generated/?"
My main motivation is to avoid a race condition in the currently
proposed patch:
https://lore.kernel.org/patchwork/patch/1052763/
This patch tries to embed some build artifacts into the kernel.
If arch/arm/mach-omap2/ and kernel/ are built at the same time,
it may embed a truncated file.
arch/arm/mach-omap2/.gitignore | 1 +
arch/arm/mach-omap2/Makefile | 5 +++--
arch/arm/mach-omap2/sleep33xx.S | 2 +-
arch/arm/mach-omap2/sleep43xx.S | 2 +-
4 files changed, 6 insertions(+), 4 deletions(-)
create mode 100644 arch/arm/mach-omap2/.gitignore
diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore
new file mode 100644
index 000000000000..79a8d6ea7152
--- /dev/null
+++ b/arch/arm/mach-omap2/.gitignore
@@ -0,0 +1 @@
+pm-asm-offsets.h
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index 85d1b13c9215..26baeb6477af 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o
obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o
-include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE
+$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE
$(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__)
-$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h
+$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h
targets += pm-asm-offsets.s
+clean-files += pm-asm-offsets.h
diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S
index 47a816468cdb..a003769121aa 100644
--- a/arch/arm/mach-omap2/sleep33xx.S
+++ b/arch/arm/mach-omap2/sleep33xx.S
@@ -6,7 +6,6 @@
* Dave Gerlach, Vaibhav Bedia
*/
-#include <generated/ti-pm-asm-offsets.h>
#include <linux/linkage.h>
#include <linux/platform_data/pm33xx.h>
#include <linux/ti-emif-sram.h>
@@ -15,6 +14,7 @@
#include "iomap.h"
#include "cm33xx.h"
+#include "pm-asm-offsets.h"
#define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000
#define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003
diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
index 5b9343b58fc7..aa288f361c5e 100644
--- a/arch/arm/mach-omap2/sleep43xx.S
+++ b/arch/arm/mach-omap2/sleep43xx.S
@@ -6,7 +6,6 @@
* Dave Gerlach, Vaibhav Bedia
*/
-#include <generated/ti-pm-asm-offsets.h>
#include <linux/linkage.h>
#include <linux/ti-emif-sram.h>
#include <linux/platform_data/pm33xx.h>
@@ -19,6 +18,7 @@
#include "iomap.h"
#include "omap-secure.h"
#include "omap44xx.h"
+#include "pm-asm-offsets.h"
#include "prm33xx.h"
#include "prcm43xx.h"
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-08 7:54 ` [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Masahiro Yamada
@ 2019-04-08 16:18 ` Tony Lindgren
2019-04-09 4:58 ` Keerthy
0 siblings, 1 reply; 14+ messages in thread
From: Tony Lindgren @ 2019-04-08 16:18 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, Dave Gerlach, Keerthy, Russell King, linux-kernel,
arm, Olof Johansson, linux-omap, linux-arm-kernel
Hi,
* Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
> <generated/ti-pm-asm-offsets.h> is only generated and included
> by arch/arm/mach-omap2/, so it does not need to reside in the
> globally visible include/generated/.
>
> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
> since the prefix 'omap2-' is just redundant in mach-omap2/.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Can this be applied to ARM-SOC tree in a series?
> (with Ack from the platform sub-maintainer.)
>
> ti-pm-asm-offsets.h does not need to reside in include/generated/,
> but you may ask "Why must it get out of include/generated/?"
>
> My main motivation is to avoid a race condition in the currently
> proposed patch:
>
> https://lore.kernel.org/patchwork/patch/1052763/
>
> This patch tries to embed some build artifacts into the kernel.
>
> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
> it may embed a truncated file.
Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
Keerthy and Dave, can you please test this series with am3 and am4
PM code?
Regards,
Tony
> arch/arm/mach-omap2/.gitignore | 1 +
> arch/arm/mach-omap2/Makefile | 5 +++--
> arch/arm/mach-omap2/sleep33xx.S | 2 +-
> arch/arm/mach-omap2/sleep43xx.S | 2 +-
> 4 files changed, 6 insertions(+), 4 deletions(-)
> create mode 100644 arch/arm/mach-omap2/.gitignore
>
> diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore
> new file mode 100644
> index 000000000000..79a8d6ea7152
> --- /dev/null
> +++ b/arch/arm/mach-omap2/.gitignore
> @@ -0,0 +1 @@
> +pm-asm-offsets.h
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 85d1b13c9215..26baeb6477af 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o
>
> obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o
>
> -include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE
> +$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE
> $(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__)
>
> -$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h
> +$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h
>
> targets += pm-asm-offsets.s
> +clean-files += pm-asm-offsets.h
> diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S
> index 47a816468cdb..a003769121aa 100644
> --- a/arch/arm/mach-omap2/sleep33xx.S
> +++ b/arch/arm/mach-omap2/sleep33xx.S
> @@ -6,7 +6,6 @@
> * Dave Gerlach, Vaibhav Bedia
> */
>
> -#include <generated/ti-pm-asm-offsets.h>
> #include <linux/linkage.h>
> #include <linux/platform_data/pm33xx.h>
> #include <linux/ti-emif-sram.h>
> @@ -15,6 +14,7 @@
>
> #include "iomap.h"
> #include "cm33xx.h"
> +#include "pm-asm-offsets.h"
>
> #define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000
> #define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003
> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
> index 5b9343b58fc7..aa288f361c5e 100644
> --- a/arch/arm/mach-omap2/sleep43xx.S
> +++ b/arch/arm/mach-omap2/sleep43xx.S
> @@ -6,7 +6,6 @@
> * Dave Gerlach, Vaibhav Bedia
> */
>
> -#include <generated/ti-pm-asm-offsets.h>
> #include <linux/linkage.h>
> #include <linux/ti-emif-sram.h>
> #include <linux/platform_data/pm33xx.h>
> @@ -19,6 +18,7 @@
> #include "iomap.h"
> #include "omap-secure.h"
> #include "omap44xx.h"
> +#include "pm-asm-offsets.h"
> #include "prm33xx.h"
> #include "prcm43xx.h"
>
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-08 16:18 ` Tony Lindgren
@ 2019-04-09 4:58 ` Keerthy
2019-04-09 5:07 ` Masahiro Yamada
0 siblings, 1 reply; 14+ messages in thread
From: Keerthy @ 2019-04-09 4:58 UTC (permalink / raw)
To: Tony Lindgren, Masahiro Yamada
Cc: Arnd Bergmann, Dave Gerlach, Russell King, linux-kernel, arm,
Olof Johansson, linux-omap, linux-arm-kernel
On 08/04/19 9:48 PM, Tony Lindgren wrote:
> Hi,
>
> * Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
>> <generated/ti-pm-asm-offsets.h> is only generated and included
>> by arch/arm/mach-omap2/, so it does not need to reside in the
>> globally visible include/generated/.
>>
>> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
>> since the prefix 'omap2-' is just redundant in mach-omap2/.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Can this be applied to ARM-SOC tree in a series?
>> (with Ack from the platform sub-maintainer.)
>>
>> ti-pm-asm-offsets.h does not need to reside in include/generated/,
>> but you may ask "Why must it get out of include/generated/?"
>>
>> My main motivation is to avoid a race condition in the currently
>> proposed patch:
>>
>> https://lore.kernel.org/patchwork/patch/1052763/
>>
>> This patch tries to embed some build artifacts into the kernel.
>>
>> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
>> it may embed a truncated file.
>
> Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
>
> Keerthy and Dave, can you please test this series with am3 and am4
> PM code?
Tested for Deep Sleep0 on AM33xx Beaglebone-black.
Tested for Deep Sleep0 on AM437x-gp-evm.
Applied this on top of Tony's for-next with the gpio patch
required for RTC+DDR mode on am437x-gp-evm.
Tested-by: Keerthy <j-keerthy@ti.com>
>
> Regards,
>
> Tony
>
>> arch/arm/mach-omap2/.gitignore | 1 +
>> arch/arm/mach-omap2/Makefile | 5 +++--
>> arch/arm/mach-omap2/sleep33xx.S | 2 +-
>> arch/arm/mach-omap2/sleep43xx.S | 2 +-
>> 4 files changed, 6 insertions(+), 4 deletions(-)
>> create mode 100644 arch/arm/mach-omap2/.gitignore
>>
>> diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore
>> new file mode 100644
>> index 000000000000..79a8d6ea7152
>> --- /dev/null
>> +++ b/arch/arm/mach-omap2/.gitignore
>> @@ -0,0 +1 @@
>> +pm-asm-offsets.h
>> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
>> index 85d1b13c9215..26baeb6477af 100644
>> --- a/arch/arm/mach-omap2/Makefile
>> +++ b/arch/arm/mach-omap2/Makefile
>> @@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o
>>
>> obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o
>>
>> -include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE
>> +$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE
>> $(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__)
>>
>> -$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h
>> +$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h
>>
>> targets += pm-asm-offsets.s
>> +clean-files += pm-asm-offsets.h
>> diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S
>> index 47a816468cdb..a003769121aa 100644
>> --- a/arch/arm/mach-omap2/sleep33xx.S
>> +++ b/arch/arm/mach-omap2/sleep33xx.S
>> @@ -6,7 +6,6 @@
>> * Dave Gerlach, Vaibhav Bedia
>> */
>>
>> -#include <generated/ti-pm-asm-offsets.h>
>> #include <linux/linkage.h>
>> #include <linux/platform_data/pm33xx.h>
>> #include <linux/ti-emif-sram.h>
>> @@ -15,6 +14,7 @@
>>
>> #include "iomap.h"
>> #include "cm33xx.h"
>> +#include "pm-asm-offsets.h"
>>
>> #define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000
>> #define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003
>> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
>> index 5b9343b58fc7..aa288f361c5e 100644
>> --- a/arch/arm/mach-omap2/sleep43xx.S
>> +++ b/arch/arm/mach-omap2/sleep43xx.S
>> @@ -6,7 +6,6 @@
>> * Dave Gerlach, Vaibhav Bedia
>> */
>>
>> -#include <generated/ti-pm-asm-offsets.h>
>> #include <linux/linkage.h>
>> #include <linux/ti-emif-sram.h>
>> #include <linux/platform_data/pm33xx.h>
>> @@ -19,6 +18,7 @@
>> #include "iomap.h"
>> #include "omap-secure.h"
>> #include "omap44xx.h"
>> +#include "pm-asm-offsets.h"
>> #include "prm33xx.h"
>> #include "prcm43xx.h"
>>
>> --
>> 2.17.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-09 4:58 ` Keerthy
@ 2019-04-09 5:07 ` Masahiro Yamada
2019-04-09 5:14 ` Keerthy
0 siblings, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-09 5:07 UTC (permalink / raw)
To: Keerthy, Tony Lindgren, arm-soc, Olof Johansson, Arnd Bergmann
Cc: Dave Gerlach, Linux-OMAP, Russell King, linux-arm-kernel,
Linux Kernel Mailing List
On Tue, Apr 9, 2019 at 2:00 PM Keerthy <j-keerthy@ti.com> wrote:
>
>
>
> On 08/04/19 9:48 PM, Tony Lindgren wrote:
> > Hi,
> >
> > * Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
> >> <generated/ti-pm-asm-offsets.h> is only generated and included
> >> by arch/arm/mach-omap2/, so it does not need to reside in the
> >> globally visible include/generated/.
> >>
> >> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
> >> since the prefix 'omap2-' is just redundant in mach-omap2/.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> ---
> >>
> >> Can this be applied to ARM-SOC tree in a series?
> >> (with Ack from the platform sub-maintainer.)
> >>
> >> ti-pm-asm-offsets.h does not need to reside in include/generated/,
> >> but you may ask "Why must it get out of include/generated/?"
> >>
> >> My main motivation is to avoid a race condition in the currently
> >> proposed patch:
> >>
> >> https://lore.kernel.org/patchwork/patch/1052763/
> >>
> >> This patch tries to embed some build artifacts into the kernel.
> >>
> >> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
> >> it may embed a truncated file.
> >
> > Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
> >
> > Keerthy and Dave, can you please test this series with am3 and am4
> > PM code?
>
> Tested for Deep Sleep0 on AM33xx Beaglebone-black.
> Tested for Deep Sleep0 on AM437x-gp-evm.
>
> Applied this on top of Tony's for-next with the gpio patch
> required for RTC+DDR mode on am437x-gp-evm.
Was it applied to TI tree?
If so ...
Arnd, Olof,
Please just ignore this patch
since it looks it was already applied to TI tree.
Thanks.
Masahiro Yamada
> Tested-by: Keerthy <j-keerthy@ti.com>
>
> >
> > Regards,
> >
> > Tony
> >
> >> arch/arm/mach-omap2/.gitignore | 1 +
> >> arch/arm/mach-omap2/Makefile | 5 +++--
> >> arch/arm/mach-omap2/sleep33xx.S | 2 +-
> >> arch/arm/mach-omap2/sleep43xx.S | 2 +-
> >> 4 files changed, 6 insertions(+), 4 deletions(-)
> >> create mode 100644 arch/arm/mach-omap2/.gitignore
> >>
> >> diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore
> >> new file mode 100644
> >> index 000000000000..79a8d6ea7152
> >> --- /dev/null
> >> +++ b/arch/arm/mach-omap2/.gitignore
> >> @@ -0,0 +1 @@
> >> +pm-asm-offsets.h
> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> >> index 85d1b13c9215..26baeb6477af 100644
> >> --- a/arch/arm/mach-omap2/Makefile
> >> +++ b/arch/arm/mach-omap2/Makefile
> >> @@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o
> >>
> >> obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o
> >>
> >> -include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE
> >> +$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE
> >> $(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__)
> >>
> >> -$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h
> >> +$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h
> >>
> >> targets += pm-asm-offsets.s
> >> +clean-files += pm-asm-offsets.h
> >> diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S
> >> index 47a816468cdb..a003769121aa 100644
> >> --- a/arch/arm/mach-omap2/sleep33xx.S
> >> +++ b/arch/arm/mach-omap2/sleep33xx.S
> >> @@ -6,7 +6,6 @@
> >> * Dave Gerlach, Vaibhav Bedia
> >> */
> >>
> >> -#include <generated/ti-pm-asm-offsets.h>
> >> #include <linux/linkage.h>
> >> #include <linux/platform_data/pm33xx.h>
> >> #include <linux/ti-emif-sram.h>
> >> @@ -15,6 +14,7 @@
> >>
> >> #include "iomap.h"
> >> #include "cm33xx.h"
> >> +#include "pm-asm-offsets.h"
> >>
> >> #define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000
> >> #define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003
> >> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
> >> index 5b9343b58fc7..aa288f361c5e 100644
> >> --- a/arch/arm/mach-omap2/sleep43xx.S
> >> +++ b/arch/arm/mach-omap2/sleep43xx.S
> >> @@ -6,7 +6,6 @@
> >> * Dave Gerlach, Vaibhav Bedia
> >> */
> >>
> >> -#include <generated/ti-pm-asm-offsets.h>
> >> #include <linux/linkage.h>
> >> #include <linux/ti-emif-sram.h>
> >> #include <linux/platform_data/pm33xx.h>
> >> @@ -19,6 +18,7 @@
> >> #include "iomap.h"
> >> #include "omap-secure.h"
> >> #include "omap44xx.h"
> >> +#include "pm-asm-offsets.h"
> >> #include "prm33xx.h"
> >> #include "prcm43xx.h"
> >>
> >> --
> >> 2.17.1
> >>
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-09 5:07 ` Masahiro Yamada
@ 2019-04-09 5:14 ` Keerthy
2019-04-09 7:05 ` Masahiro Yamada
0 siblings, 1 reply; 14+ messages in thread
From: Keerthy @ 2019-04-09 5:14 UTC (permalink / raw)
To: Masahiro Yamada, Tony Lindgren, arm-soc, Olof Johansson, Arnd Bergmann
Cc: Dave Gerlach, Linux-OMAP, Russell King, linux-arm-kernel,
Linux Kernel Mailing List
On 09/04/19 10:37 AM, Masahiro Yamada wrote:
> On Tue, Apr 9, 2019 at 2:00 PM Keerthy <j-keerthy@ti.com> wrote:
>>
>>
>>
>> On 08/04/19 9:48 PM, Tony Lindgren wrote:
>>> Hi,
>>>
>>> * Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
>>>> <generated/ti-pm-asm-offsets.h> is only generated and included
>>>> by arch/arm/mach-omap2/, so it does not need to reside in the
>>>> globally visible include/generated/.
>>>>
>>>> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
>>>> since the prefix 'omap2-' is just redundant in mach-omap2/.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>>> ---
>>>>
>>>> Can this be applied to ARM-SOC tree in a series?
>>>> (with Ack from the platform sub-maintainer.)
>>>>
>>>> ti-pm-asm-offsets.h does not need to reside in include/generated/,
>>>> but you may ask "Why must it get out of include/generated/?"
>>>>
>>>> My main motivation is to avoid a race condition in the currently
>>>> proposed patch:
>>>>
>>>> https://lore.kernel.org/patchwork/patch/1052763/
>>>>
>>>> This patch tries to embed some build artifacts into the kernel.
>>>>
>>>> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
>>>> it may embed a truncated file.
>>>
>>> Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
>>>
>>> Keerthy and Dave, can you please test this series with am3 and am4
>>> PM code?
>>
>> Tested for Deep Sleep0 on AM33xx Beaglebone-black.
>> Tested for Deep Sleep0 on AM437x-gp-evm.
>>
>> Applied this on top of Tony's for-next with the gpio patch
>> required for RTC+DDR mode on am437x-gp-evm.
>
> Was it applied to TI tree?
>
> If so ...
>
> Arnd, Olof,
> Please just ignore this patch
> since it looks it was already applied to TI tree.
Masahiro Yamada,
No i manually applied this on top.
Regards,
Keerthy
>
> Thanks.
> Masahiro Yamada
>
>
>
>
>> Tested-by: Keerthy <j-keerthy@ti.com>
>>
>>>
>>> Regards,
>>>
>>> Tony
>>>
>>>> arch/arm/mach-omap2/.gitignore | 1 +
>>>> arch/arm/mach-omap2/Makefile | 5 +++--
>>>> arch/arm/mach-omap2/sleep33xx.S | 2 +-
>>>> arch/arm/mach-omap2/sleep43xx.S | 2 +-
>>>> 4 files changed, 6 insertions(+), 4 deletions(-)
>>>> create mode 100644 arch/arm/mach-omap2/.gitignore
>>>>
>>>> diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore
>>>> new file mode 100644
>>>> index 000000000000..79a8d6ea7152
>>>> --- /dev/null
>>>> +++ b/arch/arm/mach-omap2/.gitignore
>>>> @@ -0,0 +1 @@
>>>> +pm-asm-offsets.h
>>>> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
>>>> index 85d1b13c9215..26baeb6477af 100644
>>>> --- a/arch/arm/mach-omap2/Makefile
>>>> +++ b/arch/arm/mach-omap2/Makefile
>>>> @@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o
>>>>
>>>> obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o
>>>>
>>>> -include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE
>>>> +$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE
>>>> $(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__)
>>>>
>>>> -$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h
>>>> +$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h
>>>>
>>>> targets += pm-asm-offsets.s
>>>> +clean-files += pm-asm-offsets.h
>>>> diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S
>>>> index 47a816468cdb..a003769121aa 100644
>>>> --- a/arch/arm/mach-omap2/sleep33xx.S
>>>> +++ b/arch/arm/mach-omap2/sleep33xx.S
>>>> @@ -6,7 +6,6 @@
>>>> * Dave Gerlach, Vaibhav Bedia
>>>> */
>>>>
>>>> -#include <generated/ti-pm-asm-offsets.h>
>>>> #include <linux/linkage.h>
>>>> #include <linux/platform_data/pm33xx.h>
>>>> #include <linux/ti-emif-sram.h>
>>>> @@ -15,6 +14,7 @@
>>>>
>>>> #include "iomap.h"
>>>> #include "cm33xx.h"
>>>> +#include "pm-asm-offsets.h"
>>>>
>>>> #define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000
>>>> #define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003
>>>> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
>>>> index 5b9343b58fc7..aa288f361c5e 100644
>>>> --- a/arch/arm/mach-omap2/sleep43xx.S
>>>> +++ b/arch/arm/mach-omap2/sleep43xx.S
>>>> @@ -6,7 +6,6 @@
>>>> * Dave Gerlach, Vaibhav Bedia
>>>> */
>>>>
>>>> -#include <generated/ti-pm-asm-offsets.h>
>>>> #include <linux/linkage.h>
>>>> #include <linux/ti-emif-sram.h>
>>>> #include <linux/platform_data/pm33xx.h>
>>>> @@ -19,6 +18,7 @@
>>>> #include "iomap.h"
>>>> #include "omap-secure.h"
>>>> #include "omap44xx.h"
>>>> +#include "pm-asm-offsets.h"
>>>> #include "prm33xx.h"
>>>> #include "prcm43xx.h"
>>>>
>>>> --
>>>> 2.17.1
>>>>
>
>
>
> --
> Best Regards
> Masahiro Yamada
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-09 5:14 ` Keerthy
@ 2019-04-09 7:05 ` Masahiro Yamada
2019-04-09 14:17 ` Tony Lindgren
0 siblings, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-09 7:05 UTC (permalink / raw)
To: Keerthy
Cc: Arnd Bergmann, Dave Gerlach, Tony Lindgren, Russell King,
Linux Kernel Mailing List, arm-soc, Olof Johansson, Linux-OMAP,
linux-arm-kernel
On Tue, Apr 9, 2019 at 2:17 PM Keerthy <j-keerthy@ti.com> wrote:
>
>
>
> On 09/04/19 10:37 AM, Masahiro Yamada wrote:
> > On Tue, Apr 9, 2019 at 2:00 PM Keerthy <j-keerthy@ti.com> wrote:
> >>
> >>
> >>
> >> On 08/04/19 9:48 PM, Tony Lindgren wrote:
> >>> Hi,
> >>>
> >>> * Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
> >>>> <generated/ti-pm-asm-offsets.h> is only generated and included
> >>>> by arch/arm/mach-omap2/, so it does not need to reside in the
> >>>> globally visible include/generated/.
> >>>>
> >>>> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
> >>>> since the prefix 'omap2-' is just redundant in mach-omap2/.
> >>>>
> >>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >>>> ---
> >>>>
> >>>> Can this be applied to ARM-SOC tree in a series?
> >>>> (with Ack from the platform sub-maintainer.)
> >>>>
> >>>> ti-pm-asm-offsets.h does not need to reside in include/generated/,
> >>>> but you may ask "Why must it get out of include/generated/?"
> >>>>
> >>>> My main motivation is to avoid a race condition in the currently
> >>>> proposed patch:
> >>>>
> >>>> https://lore.kernel.org/patchwork/patch/1052763/
> >>>>
> >>>> This patch tries to embed some build artifacts into the kernel.
> >>>>
> >>>> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
> >>>> it may embed a truncated file.
> >>>
> >>> Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
> >>>
> >>> Keerthy and Dave, can you please test this series with am3 and am4
> >>> PM code?
> >>
> >> Tested for Deep Sleep0 on AM33xx Beaglebone-black.
> >> Tested for Deep Sleep0 on AM437x-gp-evm.
> >>
> >> Applied this on top of Tony's for-next with the gpio patch
> >> required for RTC+DDR mode on am437x-gp-evm.
> >
> > Was it applied to TI tree?
> >
> > If so ...
> >
> > Arnd, Olof,
> > Please just ignore this patch
> > since it looks it was already applied to TI tree.
>
> Masahiro Yamada,
>
> No i manually applied this on top.
>
> Regards,
> Keerthy
Keerthy,
Sorry, I misunderstood.
You just applied it to your local tree for testing.
Then, I still think it is better to
apply this series in a correct order.
The reason I sent this in a series was
to make sure asm-offset headers are correctly
cleaned up.
Thank you.
> >
> > Thanks.
> > Masahiro Yamada
> >
> >
> >
> >
> >> Tested-by: Keerthy <j-keerthy@ti.com>
> >>
> >>>
> >>> Regards,
> >>>
> >>> Tony
> >>>
> >>>> arch/arm/mach-omap2/.gitignore | 1 +
> >>>> arch/arm/mach-omap2/Makefile | 5 +++--
> >>>> arch/arm/mach-omap2/sleep33xx.S | 2 +-
> >>>> arch/arm/mach-omap2/sleep43xx.S | 2 +-
> >>>> 4 files changed, 6 insertions(+), 4 deletions(-)
> >>>> create mode 100644 arch/arm/mach-omap2/.gitignore
> >>>>
> >>>> diff --git a/arch/arm/mach-omap2/.gitignore b/arch/arm/mach-omap2/.gitignore
> >>>> new file mode 100644
> >>>> index 000000000000..79a8d6ea7152
> >>>> --- /dev/null
> >>>> +++ b/arch/arm/mach-omap2/.gitignore
> >>>> @@ -0,0 +1 @@
> >>>> +pm-asm-offsets.h
> >>>> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> >>>> index 85d1b13c9215..26baeb6477af 100644
> >>>> --- a/arch/arm/mach-omap2/Makefile
> >>>> +++ b/arch/arm/mach-omap2/Makefile
> >>>> @@ -236,9 +236,10 @@ obj-y += omap_phy_internal.o
> >>>>
> >>>> obj-$(CONFIG_MACH_OMAP2_TUSB6010) += usb-tusb6010.o
> >>>>
> >>>> -include/generated/ti-pm-asm-offsets.h: arch/arm/mach-omap2/pm-asm-offsets.s FORCE
> >>>> +$(obj)/pm-asm-offsets.h: $(obj)/pm-asm-offsets.s FORCE
> >>>> $(call filechk,offsets,__TI_PM_ASM_OFFSETS_H__)
> >>>>
> >>>> -$(obj)/sleep33xx.o $(obj)/sleep43xx.o: include/generated/ti-pm-asm-offsets.h
> >>>> +$(obj)/sleep33xx.o $(obj)/sleep43xx.o: $(obj)/pm-asm-offsets.h
> >>>>
> >>>> targets += pm-asm-offsets.s
> >>>> +clean-files += pm-asm-offsets.h
> >>>> diff --git a/arch/arm/mach-omap2/sleep33xx.S b/arch/arm/mach-omap2/sleep33xx.S
> >>>> index 47a816468cdb..a003769121aa 100644
> >>>> --- a/arch/arm/mach-omap2/sleep33xx.S
> >>>> +++ b/arch/arm/mach-omap2/sleep33xx.S
> >>>> @@ -6,7 +6,6 @@
> >>>> * Dave Gerlach, Vaibhav Bedia
> >>>> */
> >>>>
> >>>> -#include <generated/ti-pm-asm-offsets.h>
> >>>> #include <linux/linkage.h>
> >>>> #include <linux/platform_data/pm33xx.h>
> >>>> #include <linux/ti-emif-sram.h>
> >>>> @@ -15,6 +14,7 @@
> >>>>
> >>>> #include "iomap.h"
> >>>> #include "cm33xx.h"
> >>>> +#include "pm-asm-offsets.h"
> >>>>
> >>>> #define AM33XX_CM_CLKCTRL_MODULESTATE_DISABLED 0x00030000
> >>>> #define AM33XX_CM_CLKCTRL_MODULEMODE_DISABLE 0x0003
> >>>> diff --git a/arch/arm/mach-omap2/sleep43xx.S b/arch/arm/mach-omap2/sleep43xx.S
> >>>> index 5b9343b58fc7..aa288f361c5e 100644
> >>>> --- a/arch/arm/mach-omap2/sleep43xx.S
> >>>> +++ b/arch/arm/mach-omap2/sleep43xx.S
> >>>> @@ -6,7 +6,6 @@
> >>>> * Dave Gerlach, Vaibhav Bedia
> >>>> */
> >>>>
> >>>> -#include <generated/ti-pm-asm-offsets.h>
> >>>> #include <linux/linkage.h>
> >>>> #include <linux/ti-emif-sram.h>
> >>>> #include <linux/platform_data/pm33xx.h>
> >>>> @@ -19,6 +18,7 @@
> >>>> #include "iomap.h"
> >>>> #include "omap-secure.h"
> >>>> #include "omap44xx.h"
> >>>> +#include "pm-asm-offsets.h"
> >>>> #include "prm33xx.h"
> >>>> #include "prcm43xx.h"
> >>>>
> >>>> --
> >>>> 2.17.1
> >>>>
> >
> >
> >
> > --
> > Best Regards
> > Masahiro Yamada
> >
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-09 7:05 ` Masahiro Yamada
@ 2019-04-09 14:17 ` Tony Lindgren
2019-04-23 4:40 ` Masahiro Yamada
0 siblings, 1 reply; 14+ messages in thread
From: Tony Lindgren @ 2019-04-09 14:17 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, Dave Gerlach, Keerthy, Russell King,
Linux Kernel Mailing List, arm-soc, Olof Johansson, Linux-OMAP,
linux-arm-kernel
* Masahiro Yamada <yamada.masahiro@socionext.com> [190409 07:06]:
> On Tue, Apr 9, 2019 at 2:17 PM Keerthy <j-keerthy@ti.com> wrote:
> >
> >
> >
> > On 09/04/19 10:37 AM, Masahiro Yamada wrote:
> > > On Tue, Apr 9, 2019 at 2:00 PM Keerthy <j-keerthy@ti.com> wrote:
> > >>
> > >>
> > >>
> > >> On 08/04/19 9:48 PM, Tony Lindgren wrote:
> > >>> Hi,
> > >>>
> > >>> * Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
> > >>>> <generated/ti-pm-asm-offsets.h> is only generated and included
> > >>>> by arch/arm/mach-omap2/, so it does not need to reside in the
> > >>>> globally visible include/generated/.
> > >>>>
> > >>>> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
> > >>>> since the prefix 'omap2-' is just redundant in mach-omap2/.
> > >>>>
> > >>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > >>>> ---
> > >>>>
> > >>>> Can this be applied to ARM-SOC tree in a series?
> > >>>> (with Ack from the platform sub-maintainer.)
> > >>>>
> > >>>> ti-pm-asm-offsets.h does not need to reside in include/generated/,
> > >>>> but you may ask "Why must it get out of include/generated/?"
> > >>>>
> > >>>> My main motivation is to avoid a race condition in the currently
> > >>>> proposed patch:
> > >>>>
> > >>>> https://lore.kernel.org/patchwork/patch/1052763/
> > >>>>
> > >>>> This patch tries to embed some build artifacts into the kernel.
> > >>>>
> > >>>> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
> > >>>> it may embed a truncated file.
> > >>>
> > >>> Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
> > >>>
> > >>> Keerthy and Dave, can you please test this series with am3 and am4
> > >>> PM code?
> > >>
> > >> Tested for Deep Sleep0 on AM33xx Beaglebone-black.
> > >> Tested for Deep Sleep0 on AM437x-gp-evm.
> > >>
> > >> Applied this on top of Tony's for-next with the gpio patch
> > >> required for RTC+DDR mode on am437x-gp-evm.
> > >
> > > Was it applied to TI tree?
> > >
> > > If so ...
> > >
> > > Arnd, Olof,
> > > Please just ignore this patch
> > > since it looks it was already applied to TI tree.
> >
> > Masahiro Yamada,
> >
> > No i manually applied this on top.
> >
> > Regards,
> > Keerthy
>
> Keerthy,
> Sorry, I misunderstood.
>
> You just applied it to your local tree for testing.
>
> Then, I still think it is better to
> apply this series in a correct order.
>
> The reason I sent this in a series was
> to make sure asm-offset headers are correctly
> cleaned up.
Yes looks good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91
2019-04-08 7:54 ` [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91 Masahiro Yamada
@ 2019-04-15 15:14 ` Alexandre Belloni
2019-04-19 11:39 ` Ludovic Desroches
0 siblings, 1 reply; 14+ messages in thread
From: Alexandre Belloni @ 2019-04-15 15:14 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Arnd Bergmann, linux-kernel, Ludovic Desroches, arm,
Olof Johansson, Russell King, linux-arm-kernel
On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote:
> <generated/at91_pm_data-offsets.h> is only generated and included
> by arch/arm/mach-at91/, so it does not need to reside in the
> globally visible include/generated/.
>
> I moved and renamed it to arch/arm/mach-at91/pm_data-offsets.h
> since the prefix 'at91_' is just redundant in mach-at91/.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>
> Can this be applied to ARM-SOC tree in a series?
> (with Ack from the platform sub-maintainer.)
>
> at91_pm_data-offsets.h header does not need to reside in
> include/generated/, but you may ask
> "Why must it get out of include/generated/?"
>
> My main motivation is to avoid a race condition in the currently
> proposed patch:
>
> https://lore.kernel.org/patchwork/patch/1052763/
>
> This patch tries to embed some build artifacts into the kernel.
>
> If arch/arm/mach-at91/ and kernel/ are built at the same time,
> it may embed a truncated file.
>
>
> arch/arm/mach-at91/.gitignore | 1 +
> arch/arm/mach-at91/Makefile | 5 +++--
> arch/arm/mach-at91/pm_suspend.S | 2 +-
> 3 files changed, 5 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/mach-at91/.gitignore
>
> diff --git a/arch/arm/mach-at91/.gitignore b/arch/arm/mach-at91/.gitignore
> new file mode 100644
> index 000000000000..2ecd6f51c8a9
> --- /dev/null
> +++ b/arch/arm/mach-at91/.gitignore
> @@ -0,0 +1 @@
> +pm_data-offsets.h
> diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> index 31b61f0e1c07..de64301dcff2 100644
> --- a/arch/arm/mach-at91/Makefile
> +++ b/arch/arm/mach-at91/Makefile
> @@ -19,9 +19,10 @@ ifeq ($(CONFIG_PM_DEBUG),y)
> CFLAGS_pm.o += -DDEBUG
> endif
>
> -include/generated/at91_pm_data-offsets.h: arch/arm/mach-at91/pm_data-offsets.s FORCE
> +$(obj)/pm_data-offsets.h: $(obj)/pm_data-offsets.s FORCE
> $(call filechk,offsets,__PM_DATA_OFFSETS_H__)
>
> -arch/arm/mach-at91/pm_suspend.o: include/generated/at91_pm_data-offsets.h
> +$(obj)/pm_suspend.o: $(obj)/pm_data-offsets.h
>
> targets += pm_data-offsets.s
> +clean-files += pm_data-offsets.h
> diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> index bfe1c4d06901..a31c1b20f3fa 100644
> --- a/arch/arm/mach-at91/pm_suspend.S
> +++ b/arch/arm/mach-at91/pm_suspend.S
> @@ -14,7 +14,7 @@
> #include <linux/linkage.h>
> #include <linux/clk/at91_pmc.h>
> #include "pm.h"
> -#include "generated/at91_pm_data-offsets.h"
> +#include "pm_data-offsets.h"
>
> #define SRAMC_SELF_FRESH_ACTIVE 0x01
> #define SRAMC_SELF_FRESH_EXIT 0x00
> --
> 2.17.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91
2019-04-15 15:14 ` Alexandre Belloni
@ 2019-04-19 11:39 ` Ludovic Desroches
2019-04-19 23:10 ` Masahiro Yamada
0 siblings, 1 reply; 14+ messages in thread
From: Ludovic Desroches @ 2019-04-19 11:39 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Arnd Bergmann, linux-kernel, Masahiro Yamada, arm,
Olof Johansson, Russell King, linux-arm-kernel
On Mon, Apr 15, 2019 at 05:14:50PM +0200, Alexandre Belloni wrote:
> External E-Mail
>
>
> On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote:
> > <generated/at91_pm_data-offsets.h> is only generated and included
> > by arch/arm/mach-at91/, so it does not need to reside in the
> > globally visible include/generated/.
> >
> > I moved and renamed it to arch/arm/mach-at91/pm_data-offsets.h
> > since the prefix 'at91_' is just redundant in mach-at91/.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
>
Applied in at91-soc. Let me know if it's an issue, I plan to do the PR
soon.
Regards
Ludovic
> > ---
> >
> > Can this be applied to ARM-SOC tree in a series?
> > (with Ack from the platform sub-maintainer.)
> >
> > at91_pm_data-offsets.h header does not need to reside in
> > include/generated/, but you may ask
> > "Why must it get out of include/generated/?"
> >
> > My main motivation is to avoid a race condition in the currently
> > proposed patch:
> >
> > https://lore.kernel.org/patchwork/patch/1052763/
> >
> > This patch tries to embed some build artifacts into the kernel.
> >
> > If arch/arm/mach-at91/ and kernel/ are built at the same time,
> > it may embed a truncated file.
> >
> >
> > arch/arm/mach-at91/.gitignore | 1 +
> > arch/arm/mach-at91/Makefile | 5 +++--
> > arch/arm/mach-at91/pm_suspend.S | 2 +-
> > 3 files changed, 5 insertions(+), 3 deletions(-)
> > create mode 100644 arch/arm/mach-at91/.gitignore
> >
> > diff --git a/arch/arm/mach-at91/.gitignore b/arch/arm/mach-at91/.gitignore
> > new file mode 100644
> > index 000000000000..2ecd6f51c8a9
> > --- /dev/null
> > +++ b/arch/arm/mach-at91/.gitignore
> > @@ -0,0 +1 @@
> > +pm_data-offsets.h
> > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> > index 31b61f0e1c07..de64301dcff2 100644
> > --- a/arch/arm/mach-at91/Makefile
> > +++ b/arch/arm/mach-at91/Makefile
> > @@ -19,9 +19,10 @@ ifeq ($(CONFIG_PM_DEBUG),y)
> > CFLAGS_pm.o += -DDEBUG
> > endif
> >
> > -include/generated/at91_pm_data-offsets.h: arch/arm/mach-at91/pm_data-offsets.s FORCE
> > +$(obj)/pm_data-offsets.h: $(obj)/pm_data-offsets.s FORCE
> > $(call filechk,offsets,__PM_DATA_OFFSETS_H__)
> >
> > -arch/arm/mach-at91/pm_suspend.o: include/generated/at91_pm_data-offsets.h
> > +$(obj)/pm_suspend.o: $(obj)/pm_data-offsets.h
> >
> > targets += pm_data-offsets.s
> > +clean-files += pm_data-offsets.h
> > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> > index bfe1c4d06901..a31c1b20f3fa 100644
> > --- a/arch/arm/mach-at91/pm_suspend.S
> > +++ b/arch/arm/mach-at91/pm_suspend.S
> > @@ -14,7 +14,7 @@
> > #include <linux/linkage.h>
> > #include <linux/clk/at91_pmc.h>
> > #include "pm.h"
> > -#include "generated/at91_pm_data-offsets.h"
> > +#include "pm_data-offsets.h"
> >
> > #define SRAMC_SELF_FRESH_ACTIVE 0x01
> > #define SRAMC_SELF_FRESH_EXIT 0x00
> > --
> > 2.17.1
> >
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91
2019-04-19 11:39 ` Ludovic Desroches
@ 2019-04-19 23:10 ` Masahiro Yamada
2019-04-23 4:29 ` Masahiro Yamada
0 siblings, 1 reply; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-19 23:10 UTC (permalink / raw)
To: Alexandre Belloni, Masahiro Yamada, arm-soc, Olof Johansson,
Arnd Bergmann, linux-arm-kernel, Linux Kernel Mailing List,
Nicolas Ferre, Russell King
On Sat, Apr 20, 2019 at 4:03 AM Ludovic Desroches
<ludovic.desroches@microchip.com> wrote:
>
> On Mon, Apr 15, 2019 at 05:14:50PM +0200, Alexandre Belloni wrote:
> > External E-Mail
> >
> >
> > On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote:
> > > <generated/at91_pm_data-offsets.h> is only generated and included
> > > by arch/arm/mach-at91/, so it does not need to reside in the
> > > globally visible include/generated/.
> > >
> > > I moved and renamed it to arch/arm/mach-at91/pm_data-offsets.h
> > > since the prefix 'at91_' is just redundant in mach-at91/.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> >
>
> Applied in at91-soc. Let me know if it's an issue, I plan to do the PR
> soon.
There is one minor issue.
If you apply 2/3 (this one) alone,
arch/arm/mach-at91/pm_data-offsets.h is not cleaned.
1/3 fixes the "make clean" issue:
https://lkml.org/lkml/2019/4/8/153
That is why I sent this as a series
in order to avoid the regression of cleaning.
Thanks.
Masahiro Yamada
> Regards
>
> Ludovic
>
> > > ---
> > >
> > > Can this be applied to ARM-SOC tree in a series?
> > > (with Ack from the platform sub-maintainer.)
> > >
> > > at91_pm_data-offsets.h header does not need to reside in
> > > include/generated/, but you may ask
> > > "Why must it get out of include/generated/?"
> > >
> > > My main motivation is to avoid a race condition in the currently
> > > proposed patch:
> > >
> > > https://lore.kernel.org/patchwork/patch/1052763/
> > >
> > > This patch tries to embed some build artifacts into the kernel.
> > >
> > > If arch/arm/mach-at91/ and kernel/ are built at the same time,
> > > it may embed a truncated file.
> > >
> > >
> > > arch/arm/mach-at91/.gitignore | 1 +
> > > arch/arm/mach-at91/Makefile | 5 +++--
> > > arch/arm/mach-at91/pm_suspend.S | 2 +-
> > > 3 files changed, 5 insertions(+), 3 deletions(-)
> > > create mode 100644 arch/arm/mach-at91/.gitignore
> > >
> > > diff --git a/arch/arm/mach-at91/.gitignore b/arch/arm/mach-at91/.gitignore
> > > new file mode 100644
> > > index 000000000000..2ecd6f51c8a9
> > > --- /dev/null
> > > +++ b/arch/arm/mach-at91/.gitignore
> > > @@ -0,0 +1 @@
> > > +pm_data-offsets.h
> > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> > > index 31b61f0e1c07..de64301dcff2 100644
> > > --- a/arch/arm/mach-at91/Makefile
> > > +++ b/arch/arm/mach-at91/Makefile
> > > @@ -19,9 +19,10 @@ ifeq ($(CONFIG_PM_DEBUG),y)
> > > CFLAGS_pm.o += -DDEBUG
> > > endif
> > >
> > > -include/generated/at91_pm_data-offsets.h: arch/arm/mach-at91/pm_data-offsets.s FORCE
> > > +$(obj)/pm_data-offsets.h: $(obj)/pm_data-offsets.s FORCE
> > > $(call filechk,offsets,__PM_DATA_OFFSETS_H__)
> > >
> > > -arch/arm/mach-at91/pm_suspend.o: include/generated/at91_pm_data-offsets.h
> > > +$(obj)/pm_suspend.o: $(obj)/pm_data-offsets.h
> > >
> > > targets += pm_data-offsets.s
> > > +clean-files += pm_data-offsets.h
> > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> > > index bfe1c4d06901..a31c1b20f3fa 100644
> > > --- a/arch/arm/mach-at91/pm_suspend.S
> > > +++ b/arch/arm/mach-at91/pm_suspend.S
> > > @@ -14,7 +14,7 @@
> > > #include <linux/linkage.h>
> > > #include <linux/clk/at91_pmc.h>
> > > #include "pm.h"
> > > -#include "generated/at91_pm_data-offsets.h"
> > > +#include "pm_data-offsets.h"
> > >
> > > #define SRAMC_SELF_FRESH_ACTIVE 0x01
> > > #define SRAMC_SELF_FRESH_EXIT 0x00
> > > --
> > > 2.17.1
> > >
> >
> > --
> > Alexandre Belloni, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> >
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91
2019-04-19 23:10 ` Masahiro Yamada
@ 2019-04-23 4:29 ` Masahiro Yamada
0 siblings, 0 replies; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-23 4:29 UTC (permalink / raw)
To: Alexandre Belloni, Masahiro Yamada, arm-soc, Olof Johansson,
Arnd Bergmann, linux-arm-kernel, Linux Kernel Mailing List,
Nicolas Ferre, Russell King
On Sat, Apr 20, 2019 at 8:10 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> On Sat, Apr 20, 2019 at 4:03 AM Ludovic Desroches
> <ludovic.desroches@microchip.com> wrote:
> >
> > On Mon, Apr 15, 2019 at 05:14:50PM +0200, Alexandre Belloni wrote:
> > > External E-Mail
> > >
> > >
> > > On 08/04/2019 16:54:26+0900, Masahiro Yamada wrote:
> > > > <generated/at91_pm_data-offsets.h> is only generated and included
> > > > by arch/arm/mach-at91/, so it does not need to reside in the
> > > > globally visible include/generated/.
> > > >
> > > > I moved and renamed it to arch/arm/mach-at91/pm_data-offsets.h
> > > > since the prefix 'at91_' is just redundant in mach-at91/.
> > > >
> > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> > >
> >
> > Applied in at91-soc. Let me know if it's an issue, I plan to do the PR
> > soon.
Sorry. A more fatal issue is this breaks O= build.
Could you drop it?
Thanks.
>
>
> There is one minor issue.
>
> If you apply 2/3 (this one) alone,
> arch/arm/mach-at91/pm_data-offsets.h is not cleaned.
>
>
> 1/3 fixes the "make clean" issue:
> https://lkml.org/lkml/2019/4/8/153
>
>
> That is why I sent this as a series
> in order to avoid the regression of cleaning.
>
>
>
> Thanks.
>
> Masahiro Yamada
>
>
> > Regards
> >
> > Ludovic
> >
> > > > ---
> > > >
> > > > Can this be applied to ARM-SOC tree in a series?
> > > > (with Ack from the platform sub-maintainer.)
> > > >
> > > > at91_pm_data-offsets.h header does not need to reside in
> > > > include/generated/, but you may ask
> > > > "Why must it get out of include/generated/?"
> > > >
> > > > My main motivation is to avoid a race condition in the currently
> > > > proposed patch:
> > > >
> > > > https://lore.kernel.org/patchwork/patch/1052763/
> > > >
> > > > This patch tries to embed some build artifacts into the kernel.
> > > >
> > > > If arch/arm/mach-at91/ and kernel/ are built at the same time,
> > > > it may embed a truncated file.
> > > >
> > > >
> > > > arch/arm/mach-at91/.gitignore | 1 +
> > > > arch/arm/mach-at91/Makefile | 5 +++--
> > > > arch/arm/mach-at91/pm_suspend.S | 2 +-
> > > > 3 files changed, 5 insertions(+), 3 deletions(-)
> > > > create mode 100644 arch/arm/mach-at91/.gitignore
> > > >
> > > > diff --git a/arch/arm/mach-at91/.gitignore b/arch/arm/mach-at91/.gitignore
> > > > new file mode 100644
> > > > index 000000000000..2ecd6f51c8a9
> > > > --- /dev/null
> > > > +++ b/arch/arm/mach-at91/.gitignore
> > > > @@ -0,0 +1 @@
> > > > +pm_data-offsets.h
> > > > diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> > > > index 31b61f0e1c07..de64301dcff2 100644
> > > > --- a/arch/arm/mach-at91/Makefile
> > > > +++ b/arch/arm/mach-at91/Makefile
> > > > @@ -19,9 +19,10 @@ ifeq ($(CONFIG_PM_DEBUG),y)
> > > > CFLAGS_pm.o += -DDEBUG
> > > > endif
> > > >
> > > > -include/generated/at91_pm_data-offsets.h: arch/arm/mach-at91/pm_data-offsets.s FORCE
> > > > +$(obj)/pm_data-offsets.h: $(obj)/pm_data-offsets.s FORCE
> > > > $(call filechk,offsets,__PM_DATA_OFFSETS_H__)
> > > >
> > > > -arch/arm/mach-at91/pm_suspend.o: include/generated/at91_pm_data-offsets.h
> > > > +$(obj)/pm_suspend.o: $(obj)/pm_data-offsets.h
> > > >
> > > > targets += pm_data-offsets.s
> > > > +clean-files += pm_data-offsets.h
> > > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S
> > > > index bfe1c4d06901..a31c1b20f3fa 100644
> > > > --- a/arch/arm/mach-at91/pm_suspend.S
> > > > +++ b/arch/arm/mach-at91/pm_suspend.S
> > > > @@ -14,7 +14,7 @@
> > > > #include <linux/linkage.h>
> > > > #include <linux/clk/at91_pmc.h>
> > > > #include "pm.h"
> > > > -#include "generated/at91_pm_data-offsets.h"
> > > > +#include "pm_data-offsets.h"
> > > >
> > > > #define SRAMC_SELF_FRESH_ACTIVE 0x01
> > > > #define SRAMC_SELF_FRESH_EXIT 0x00
> > > > --
> > > > 2.17.1
> > > >
> > >
> > > --
> > > Alexandre Belloni, Bootlin
> > > Embedded Linux and Kernel engineering
> > > https://bootlin.com
> > >
>
>
>
> --
> Best Regards
> Masahiro Yamada
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2
2019-04-09 14:17 ` Tony Lindgren
@ 2019-04-23 4:40 ` Masahiro Yamada
0 siblings, 0 replies; 14+ messages in thread
From: Masahiro Yamada @ 2019-04-23 4:40 UTC (permalink / raw)
To: Tony Lindgren
Cc: Arnd Bergmann, Dave Gerlach, Keerthy, Russell King,
Linux Kernel Mailing List, arm-soc, Olof Johansson, Linux-OMAP,
linux-arm-kernel
On Tue, Apr 9, 2019 at 11:20 PM Tony Lindgren <tony@atomide.com> wrote:
>
> * Masahiro Yamada <yamada.masahiro@socionext.com> [190409 07:06]:
> > On Tue, Apr 9, 2019 at 2:17 PM Keerthy <j-keerthy@ti.com> wrote:
> > >
> > >
> > >
> > > On 09/04/19 10:37 AM, Masahiro Yamada wrote:
> > > > On Tue, Apr 9, 2019 at 2:00 PM Keerthy <j-keerthy@ti.com> wrote:
> > > >>
> > > >>
> > > >>
> > > >> On 08/04/19 9:48 PM, Tony Lindgren wrote:
> > > >>> Hi,
> > > >>>
> > > >>> * Masahiro Yamada <yamada.masahiro@socionext.com> [190408 07:56]:
> > > >>>> <generated/ti-pm-asm-offsets.h> is only generated and included
> > > >>>> by arch/arm/mach-omap2/, so it does not need to reside in the
> > > >>>> globally visible include/generated/.
> > > >>>>
> > > >>>> I moved and renamed it to arch/arm/mach-omap2/pm-asm-offsets.h
> > > >>>> since the prefix 'omap2-' is just redundant in mach-omap2/.
> > > >>>>
> > > >>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > > >>>> ---
> > > >>>>
> > > >>>> Can this be applied to ARM-SOC tree in a series?
> > > >>>> (with Ack from the platform sub-maintainer.)
> > > >>>>
> > > >>>> ti-pm-asm-offsets.h does not need to reside in include/generated/,
> > > >>>> but you may ask "Why must it get out of include/generated/?"
> > > >>>>
> > > >>>> My main motivation is to avoid a race condition in the currently
> > > >>>> proposed patch:
> > > >>>>
> > > >>>> https://lore.kernel.org/patchwork/patch/1052763/
> > > >>>>
> > > >>>> This patch tries to embed some build artifacts into the kernel.
> > > >>>>
> > > >>>> If arch/arm/mach-omap2/ and kernel/ are built at the same time,
> > > >>>> it may embed a truncated file.
> > > >>>
> > > >>> Looks like a nice improvment to me, adding Keerthy and Dave to Cc.
> > > >>>
> > > >>> Keerthy and Dave, can you please test this series with am3 and am4
> > > >>> PM code?
> > > >>
> > > >> Tested for Deep Sleep0 on AM33xx Beaglebone-black.
> > > >> Tested for Deep Sleep0 on AM437x-gp-evm.
> > > >>
> > > >> Applied this on top of Tony's for-next with the gpio patch
> > > >> required for RTC+DDR mode on am437x-gp-evm.
> > > >
> > > > Was it applied to TI tree?
> > > >
> > > > If so ...
> > > >
> > > > Arnd, Olof,
> > > > Please just ignore this patch
> > > > since it looks it was already applied to TI tree.
> > >
> > > Masahiro Yamada,
> > >
> > > No i manually applied this on top.
> > >
> > > Regards,
> > > Keerthy
> >
> > Keerthy,
> > Sorry, I misunderstood.
> >
> > You just applied it to your local tree for testing.
> >
> > Then, I still think it is better to
> > apply this series in a correct order.
> >
> > The reason I sent this in a series was
> > to make sure asm-offset headers are correctly
> > cleaned up.
>
> Yes looks good to me:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Sorry, this turned out to break the out-of-tree build.
Please do not apply this for now.
I will come back to this later when ready.
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-04-23 4:41 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 7:54 [PATCH 1/3] ARM: visit mach-* and plat-* directories when cleaning Masahiro Yamada
2019-04-08 7:54 ` [PATCH 2/3] ARM: at91: move platform-specific asm-offset.h to arch/arm/mach-at91 Masahiro Yamada
2019-04-15 15:14 ` Alexandre Belloni
2019-04-19 11:39 ` Ludovic Desroches
2019-04-19 23:10 ` Masahiro Yamada
2019-04-23 4:29 ` Masahiro Yamada
2019-04-08 7:54 ` [PATCH 3/3] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Masahiro Yamada
2019-04-08 16:18 ` Tony Lindgren
2019-04-09 4:58 ` Keerthy
2019-04-09 5:07 ` Masahiro Yamada
2019-04-09 5:14 ` Keerthy
2019-04-09 7:05 ` Masahiro Yamada
2019-04-09 14:17 ` Tony Lindgren
2019-04-23 4:40 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).