Re: [PATCH 09/17 v1] irqchip: ixp4xx: Add DT bindings

[Rob Herring <robh@kernel.org>]

On Sun, Feb 3, 2019 at 3:42 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> This adds device tree bindings for the IXP4xx interrupt
> controller. It's a standard 2-cell controller.

Not required, but writing as a schema would be great. Looks like it
would be straight forward.

> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Jason Cooper <jason@lakedaemon.net>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> irqchip maintainers: I am requesting an ACK for this once
> you're happy with the bindings, as I intend to merge all of
> this IXP4xx rework through ARM SoC.
> ---
>  .../intel,ixp4xx-interrupt.txt                | 33 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  2 files changed, 34 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/intel,ixp4xx-interrupt.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/intel,ixp4xx-interrupt.txt b/Documentation/devicetree/bindings/interrupt-controller/intel,ixp4xx-interrupt.txt
> new file mode 100644
> index 000000000000..70ee93b9a6c0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/intel,ixp4xx-interrupt.txt
> @@ -0,0 +1,33 @@
> +* Intel IXP4xx XScale Networking Processors Interrupt Controller
> +
> +This interrupt controller is found in the Intel IXP4xx processors.
> +Some processors have 32 interrupts, some have up to 64 interrupts.
> +The exact number of interrupts is determined from the compatible
> +string.
> +
> +The distinct IXP4xx families with different interrupt controller
> +variations are IXP42x, IXP43x, IXP45x and IXP46x. Those four
> +families were the only ones to reach the developer and consumer
> +market.
> +
> +Required properties:
> +- compatible: must be one of
> +  "intel,ixp42x-interrupt"
> +  "intel,ixp43x-interrupt"
> +  "intel,ixp45x-interrupt"
> +  "intel,ixp46x-interrupt"

While we normally don't allow wildcards, I'm guessing this is all so
old^W mature that it will be fine.

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel