* [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes
@ 2019-08-19 12:55 Yoshihiro Kaneko
2019-08-21 8:41 ` Simon Horman
2019-08-21 8:42 ` Geert Uytterhoeven
0 siblings, 2 replies; 4+ messages in thread
From: Yoshihiro Kaneko @ 2019-08-19 12:55 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Magnus Damm, Simon Horman, Geert Uytterhoeven, linux-arm-kernel
Sort nodes.
If node address is present
* Sort by node address, grouping all nodes with the same compat string
and sorting the group alphabetically.
Else
* Sort alphabetically
This should not have any run-time effect.
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the master branch of Geert Uytterhoeven's renesas-devel
tree.
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
index 651383c..aaa37158 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
@@ -82,13 +82,13 @@
simple-audio-card,bitclock-master = <&sndcpu>;
simple-audio-card,frame-master = <&sndcpu>;
- sndcpu: simple-audio-card,cpu {
- sound-dai = <&rcar_sound>;
- };
-
sndcodec: simple-audio-card,codec {
sound-dai = <&tda19988>;
};
+
+ sndcpu: simple-audio-card,cpu {
+ sound-dai = <&rcar_sound>;
+ };
};
vcc_sdhi0: regulator-vcc-sdhi0 {
@@ -313,16 +313,16 @@
power-source = <1800>;
};
- sound_pins: sound {
- groups = "ssi01239_ctrl", "ssi0_data";
- function = "ssi";
- };
-
sound_clk_pins: sound_clk {
groups = "audio_clkout1_a";
function = "audio_clk";
};
+ sound_pins: sound {
+ groups = "ssi01239_ctrl", "ssi0_data";
+ function = "ssi";
+ };
+
usb30_pins: usb30 {
groups = "usb30", "usb30_id";
function = "usb30";
--
1.9.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes
2019-08-19 12:55 [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes Yoshihiro Kaneko
@ 2019-08-21 8:41 ` Simon Horman
2019-08-21 8:46 ` Geert Uytterhoeven
2019-08-21 8:42 ` Geert Uytterhoeven
1 sibling, 1 reply; 4+ messages in thread
From: Simon Horman @ 2019-08-21 8:41 UTC (permalink / raw)
To: Yoshihiro Kaneko
Cc: linux-renesas-soc, Magnus Damm, Geert Uytterhoeven, linux-arm-kernel
On Mon, Aug 19, 2019 at 09:55:41PM +0900, Yoshihiro Kaneko wrote:
> Sort nodes.
>
> If node address is present
> * Sort by node address, grouping all nodes with the same compat string
> and sorting the group alphabetically.
> Else
> * Sort alphabetically
>
> This should not have any run-time effect.
>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Thanks Kaneko-san,
I think that the i2c1_pins and hscif2_pins nodes
are also out of order.
I'm not sure if Geert would prefer you to respin or fix that himself.
In any case, with that problem resolved:
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> This patch is based on the master branch of Geert Uytterhoeven's renesas-devel
> tree.
>
> arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> index 651383c..aaa37158 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts
> @@ -82,13 +82,13 @@
> simple-audio-card,bitclock-master = <&sndcpu>;
> simple-audio-card,frame-master = <&sndcpu>;
>
> - sndcpu: simple-audio-card,cpu {
> - sound-dai = <&rcar_sound>;
> - };
> -
> sndcodec: simple-audio-card,codec {
> sound-dai = <&tda19988>;
> };
> +
> + sndcpu: simple-audio-card,cpu {
> + sound-dai = <&rcar_sound>;
> + };
> };
>
> vcc_sdhi0: regulator-vcc-sdhi0 {
> @@ -313,16 +313,16 @@
> power-source = <1800>;
> };
>
> - sound_pins: sound {
> - groups = "ssi01239_ctrl", "ssi0_data";
> - function = "ssi";
> - };
> -
> sound_clk_pins: sound_clk {
> groups = "audio_clkout1_a";
> function = "audio_clk";
> };
>
> + sound_pins: sound {
> + groups = "ssi01239_ctrl", "ssi0_data";
> + function = "ssi";
> + };
> +
> usb30_pins: usb30 {
> groups = "usb30", "usb30_id";
> function = "usb30";
> --
> 1.9.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes
2019-08-19 12:55 [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes Yoshihiro Kaneko
2019-08-21 8:41 ` Simon Horman
@ 2019-08-21 8:42 ` Geert Uytterhoeven
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-08-21 8:42 UTC (permalink / raw)
To: Yoshihiro Kaneko; +Cc: Linux-Renesas, Simon Horman, Magnus Damm, Linux ARM
On Mon, Aug 19, 2019 at 2:55 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote:
> Sort nodes.
>
> If node address is present
> * Sort by node address, grouping all nodes with the same compat string
> and sorting the group alphabetically.
> Else
> * Sort alphabetically
>
> This should not have any run-time effect.
>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.4.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes
2019-08-21 8:41 ` Simon Horman
@ 2019-08-21 8:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-08-21 8:46 UTC (permalink / raw)
To: Simon Horman; +Cc: Linux-Renesas, Magnus Damm, Yoshihiro Kaneko, Linux ARM
On Wed, Aug 21, 2019 at 10:41 AM Simon Horman <horms@verge.net.au> wrote:
> On Mon, Aug 19, 2019 at 09:55:41PM +0900, Yoshihiro Kaneko wrote:
> > Sort nodes.
> >
> > If node address is present
> > * Sort by node address, grouping all nodes with the same compat string
> > and sorting the group alphabetically.
> > Else
> > * Sort alphabetically
> >
> > This should not have any run-time effect.
> >
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>
> Thanks Kaneko-san,
>
> I think that the i2c1_pins and hscif2_pins nodes
> are also out of order.
You're right.
> I'm not sure if Geert would prefer you to respin or fix that himself.
Will fix myself.
> In any case, with that problem resolved:
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-21 8:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-19 12:55 [PATCH] arm64: dts: renesas: r8a774c0-cat874: sort nodes Yoshihiro Kaneko
2019-08-21 8:41 ` Simon Horman
2019-08-21 8:46 ` Geert Uytterhoeven
2019-08-21 8:42 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).