From: Fabio Estevam <festevam@gmail.com>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option
Date: Thu, 13 May 2021 16:51:17 -0300 [thread overview]
Message-ID: <CAOMZO5AMzbpWFasWMB55E0E0UNYoyyMm95eXD43f3e42D9J7rQ@mail.gmail.com> (raw)
In-Reply-To: <20210513181216.0541f56a180febab295a755e@mail.ru>
Hi Alexander,
On Thu, May 13, 2021 at 12:12 PM Alexander Shiyan <shc_work@mail.ru> wrote:
>
> On Tue, 11 May 2021 10:37:50 +0800
> Shawn Guo <shawnguo@kernel.org> wrote:
>
> These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97),
> so AC97 parameters are not used in such cases.
Looking at imx6qdl-icore-rqs.dtsi, I see it uses the sgtl5000 audio codec.
To make the commit log clearer, you could also state that the board
uses the sgtl5000 codec connected via I2S.
Then it would become easier to understand why 'fsl,mode' could be removed.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-13 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 7:53 [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option Alexander Shiyan
2021-04-02 7:53 ` [PATCH RESEND 2/2] ARM: dts: imx6q-icore: " Alexander Shiyan
2021-05-11 2:37 ` [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option Shawn Guo
2021-05-13 15:12 ` Alexander Shiyan
2021-05-13 19:51 ` Fabio Estevam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOMZO5AMzbpWFasWMB55E0E0UNYoyyMm95eXD43f3e42D9J7rQ@mail.gmail.com \
--to=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).