* [PATCH] arm64: dts: Fix leftover entry-methods for PSCI
@ 2020-03-22 11:24 Linus Walleij
2020-03-22 11:49 ` Amit Kucheria
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2020-03-22 11:24 UTC (permalink / raw)
To: arm, soc
Cc: Fabio Estevam, Linus Walleij, Amit Kucheria, Chunyan Zhang,
Sudeep Holla, Shawn Guo, linux-arm-kernel
These two device trees were either missed or added after
the commit correcting the "entry-method" from
"arm,psci" to just "psci" as per the binding.
Fixes: commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation")
Cc: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Chunyan Zhang <chunyan.zhang@unisoc.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ARM SoC folks: if this is fine just apply it to the
tree where appropriate please.
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
arch/arm64/boot/dts/sprd/sc9863a.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 0bf375ec959b..55b71bb4baf8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -53,7 +53,7 @@
* PSCI node is not added default, U-boot will add missing
* parts if it determines to use PSCI.
*/
- entry-method = "arm,psci";
+ entry-method = "psci";
CPU_PW20: cpu-pw20 {
compatible = "arm,idle-state";
diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
index cd80756c888d..2c590ca1d079 100644
--- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi
+++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
@@ -108,7 +108,7 @@
};
idle-states {
- entry-method = "arm,psci";
+ entry-method = "psci";
CORE_PD: core-pd {
compatible = "arm,idle-state";
entry-latency-us = <4000>;
--
2.21.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: Fix leftover entry-methods for PSCI
2020-03-22 11:24 [PATCH] arm64: dts: Fix leftover entry-methods for PSCI Linus Walleij
@ 2020-03-22 11:49 ` Amit Kucheria
2020-03-22 11:56 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Amit Kucheria @ 2020-03-22 11:49 UTC (permalink / raw)
To: Linus Walleij
Cc: Fabio Estevam, Chunyan Zhang, soc, arm-soc, Sudeep Holla,
Shawn Guo, Lists LAKML
On Sun, Mar 22, 2020 at 4:55 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> These two device trees were either missed or added after
> the commit correcting the "entry-method" from
> "arm,psci" to just "psci" as per the binding.
My patch went in, in 4.18.
The FSL entry went in, in 4.20 and the spreadtrum one in 5.5.
> Fixes: commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation")
So only minor comment is that it isn't really a fix. We've tried
improving the text in the binding too but somehow people still get
confused. Converting the binding to YAML and enforcing it seems to be
the only course of action left now.
Otherwise,
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> Cc: Amit Kucheria <amit.kucheria@linaro.org>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Chunyan Zhang <chunyan.zhang@unisoc.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: if this is fine just apply it to the
> tree where appropriate please.
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +-
> arch/arm64/boot/dts/sprd/sc9863a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 0bf375ec959b..55b71bb4baf8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -53,7 +53,7 @@
> * PSCI node is not added default, U-boot will add missing
> * parts if it determines to use PSCI.
> */
> - entry-method = "arm,psci";
> + entry-method = "psci";
>
> CPU_PW20: cpu-pw20 {
> compatible = "arm,idle-state";
> diff --git a/arch/arm64/boot/dts/sprd/sc9863a.dtsi b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
> index cd80756c888d..2c590ca1d079 100644
> --- a/arch/arm64/boot/dts/sprd/sc9863a.dtsi
> +++ b/arch/arm64/boot/dts/sprd/sc9863a.dtsi
> @@ -108,7 +108,7 @@
> };
>
> idle-states {
> - entry-method = "arm,psci";
> + entry-method = "psci";
> CORE_PD: core-pd {
> compatible = "arm,idle-state";
> entry-latency-us = <4000>;
> --
> 2.21.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: Fix leftover entry-methods for PSCI
2020-03-22 11:49 ` Amit Kucheria
@ 2020-03-22 11:56 ` Linus Walleij
2020-03-24 5:55 ` Amit Kucheria
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2020-03-22 11:56 UTC (permalink / raw)
To: Amit Kucheria
Cc: Fabio Estevam, Chunyan Zhang, soc, arm-soc, Sudeep Holla,
Shawn Guo, Lists LAKML
On Sun, Mar 22, 2020 at 12:49 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> My patch went in, in 4.18.
>
> The FSL entry went in, in 4.20 and the spreadtrum one in 5.5.
>
> > Fixes: commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation")
>
> So only minor comment is that it isn't really a fix.
OK I'll resend a v2 without the Fixes and your reviewed-by.
> We've tried
> improving the text in the binding too but somehow people still get
> confused. Converting the binding to YAML and enforcing it seems to be
> the only course of action left now.
Since nothing in the kernel checks for entry-method right now, maybe
we could just add code to do that and warn in dmesg if entry-method
is set to anything else than "psci"?
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: Fix leftover entry-methods for PSCI
2020-03-22 11:56 ` Linus Walleij
@ 2020-03-24 5:55 ` Amit Kucheria
2020-03-27 21:16 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Amit Kucheria @ 2020-03-24 5:55 UTC (permalink / raw)
To: Linus Walleij
Cc: Fabio Estevam, Chunyan Zhang, soc, arm-soc, Sudeep Holla,
Shawn Guo, Lists LAKML
On Sun, Mar 22, 2020 at 5:26 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Sun, Mar 22, 2020 at 12:49 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
>
> > My patch went in, in 4.18.
> >
> > The FSL entry went in, in 4.20 and the spreadtrum one in 5.5.
> >
> > > Fixes: commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation")
> >
> > So only minor comment is that it isn't really a fix.
>
> OK I'll resend a v2 without the Fixes and your reviewed-by.
>
> > We've tried
> > improving the text in the binding too but somehow people still get
> > confused. Converting the binding to YAML and enforcing it seems to be
> > the only course of action left now.
>
> Since nothing in the kernel checks for entry-method right now, maybe
> we could just add code to do that and warn in dmesg if entry-method
> is set to anything else than "psci"?
Hi Linus,
Documentation/devicetree/bindings/arm/idle-states.yaml already
triggers an error on 'make dtbs_check'. Perhaps we just keep an eye on
these?
db845c-check-2020-02-24-222456.log:/home/amit/work/builds/build-check/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml:
idle-states: entry-method:0: 'psci' was expected
db845c-check-2020-02-24-222456.log:/home/amit/work/builds/build-check/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml:
idle-states: entry-method:0: 'psci' was expected
db845c-check-2020-02-24-222456.log:/home/amit/work/builds/build-check/arch/arm64/boot/dts/sprd/sp9863a-1h10.dt.yaml:
idle-states: entry-method:0: 'psci' was expected
Regards,
Amit
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: Fix leftover entry-methods for PSCI
2020-03-24 5:55 ` Amit Kucheria
@ 2020-03-27 21:16 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2020-03-27 21:16 UTC (permalink / raw)
To: Amit Kucheria
Cc: Fabio Estevam, Chunyan Zhang, SoC Team, arm-soc, Sudeep Holla,
Shawn Guo, Lists LAKML
On Tue, Mar 24, 2020 at 6:56 AM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> On Sun, Mar 22, 2020 at 5:26 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Sun, Mar 22, 2020 at 12:49 PM Amit Kucheria <amit.kucheria@linaro.org> wrote:
> >
> > > My patch went in, in 4.18.
> > >
> > > The FSL entry went in, in 4.20 and the spreadtrum one in 5.5.
> > >
> > > > Fixes: commit e9880240e4f4 ("arm64: dts: Fix various entry-method properties to reflect documentation")
> > >
> > > So only minor comment is that it isn't really a fix.
> >
> > OK I'll resend a v2 without the Fixes and your reviewed-by.
> >
> > > We've tried
> > > improving the text in the binding too but somehow people still get
> > > confused. Converting the binding to YAML and enforcing it seems to be
> > > the only course of action left now.
> >
> > Since nothing in the kernel checks for entry-method right now, maybe
> > we could just add code to do that and warn in dmesg if entry-method
> > is set to anything else than "psci"?
>
> Hi Linus,
>
> Documentation/devicetree/bindings/arm/idle-states.yaml already
> triggers an error on 'make dtbs_check'. Perhaps we just keep an eye on
> these?
>
> db845c-check-2020-02-24-222456.log:/home/amit/work/builds/build-check/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dt.yaml:
> idle-states: entry-method:0: 'psci' was expected
> db845c-check-2020-02-24-222456.log:/home/amit/work/builds/build-check/arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dt.yaml:
> idle-states: entry-method:0: 'psci' was expected
> db845c-check-2020-02-24-222456.log:/home/amit/work/builds/build-check/arch/arm64/boot/dts/sprd/sp9863a-1h10.dt.yaml:
> idle-states: entry-method:0: 'psci' was expected
Aha that's pretty awesome actually.
I think right now we have a bit too many warnings coming out of the
YAML schema but sooner or later we'll actually start to plow through the
backlog of warnings and fix stuff up... :)
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-27 21:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-22 11:24 [PATCH] arm64: dts: Fix leftover entry-methods for PSCI Linus Walleij
2020-03-22 11:49 ` Amit Kucheria
2020-03-22 11:56 ` Linus Walleij
2020-03-24 5:55 ` Amit Kucheria
2020-03-27 21:16 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).