Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Peng Fan <peng.fan@nxp.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	"ohad@wizery.com" <ohad@wizery.com>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	 "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH V5 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP
Date: Mon, 26 Apr 2021 23:45:49 +0000
Message-ID: <DB6PR0402MB2760B5F403FDA7EDED34B31C88429@DB6PR0402MB2760.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210426154623.GA1390475@xps15>

> Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support
> i.MX7ULP/8MN/8MP
> 
> On Fri, Apr 23, 2021 at 11:28:00PM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support
> > > i.MX7ULP/8MN/8MP
> > >
> > > On Thu, 22 Apr 2021 at 19:01, Peng Fan <peng.fan@nxp.com> wrote:
> > > >
> > > > Hi Mathieu,
> > > >
> > > > > Subject: Re: [PATCH V5 0/8] remoteproc: imx_rproc: support
> > > > > i.MX7ULP/8MN/8MP
> > > > >
> > > > > On Wed, Apr 21, 2021 at 10:20:14AM +0800, peng.fan@oss.nxp.com
> > > wrote:
> > > > > > From: Peng Fan <peng.fan@nxp.com>
> > > > > >
> > > > > > V5:
> > > > > >  Add R-b tag
> > > > > >  Move the change in detect mode of patch 5 to patch 7 Per
> > > > > > Mathieu's comments
> > > > > >
> > > > > > V4:
> > > > > >  Typo fix
> > > > > >  patch 4: take state as a check condition  patch 5: move
> > > > > > regmap lookup/attach to imx_rproc_detect_mode  patch 6: add
> > > > > > imx_rproc_clk_enable for optional clk  patch 8: use
> > > > > > switch/case in imx_rproc_detect_mode
> > > > > > V3:
> > > > > >  Add A-b tag for Patch 1/2
> > > > > >  Fix the checkpatch warning for Patch 6,8
> > > > > >
> > > > > > V2:
> > > > > >  Patch 1/8, use fsl as vendor, typo fix  Because patchset [1]
> > > > > > has
> > > > > > v2 version, patch 5,6,7,8 are adapted that  change.
> > > > > >
> > > > > > This patchset is to support i.MX7ULP/8MN/8MP, also includes a
> > > > > > patch to parse fsl,auto-boot
> > > > > >
> > > > >
> > > > > One of the request I had from the last revision was to
> > > > > explicitly list what other patchset this work depends on and
> > > > > what branch it is based of, something I can't find here.
> > > >
> > > > Sorry, that patchset has been merged, so I remove that line.
> > > > I should mention that that patchset has been merged into Linux-next
> tree.
> > > >
> > >
> > > And what branch this set should be applied to is missing.
> >
> > I take latest linux-next/master for my upstream new feature work.
> >
> > >
> > > > >
> > > > > As such I am dropping this set and won't look at another
> > > > > revision before May 22nd.
> > > >
> > > > Ah. Is it just because that the dependency patchset not been
> > > > mentioned or you have issue applying the patchset that delay the
> > > > patchset for one
> > > month?
> > > >
> > >
> > > Both.
> >
> > I replay my flow:
> > git fetch linux-next
> > git checkout linux-next/master -b master-next-4-24-2021 pwclient list
> > -w "Peng Fan (OSS)" -s New | grep V5 | awk '{print $1}' | xargs -I {}
> > pwclient git-am {}
> >
> > It could successfully apply the patchset.
> > Applying patch #12215291 using 'git am'
> > Description: [V5,1/8] dt-bindings: remoteproc: imx_rproc: add
> > fsl,auto-boot property
> > Applying: dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot
> > property Applying patch #12215293 using 'git am'
> > Description: [V5,2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP
> > support
> > Applying: dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support
> > Applying patch #12215295 using 'git am'
> > Description: [V5,3/8] dt-bindings: remoteproc: imx_rproc: support
> > i.MX8MN/P
> > Applying: dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P
> > Applying patch #12215297 using 'git am'
> > Description: [V5,4/8] remoteproc: imx_rproc: parse fsl,auto-boot
> > Applying: remoteproc: imx_rproc: parse fsl,auto-boot Applying patch
> > #12215299 using 'git am'
> > Description: [V5,5/8] remoteproc: imx_rproc: initial support for
> > mutilple start/stop method
> > Applying: remoteproc: imx_rproc: initial support for mutilple
> > start/stop method Applying patch #12215301 using 'git am'
> > Description: [V5,6/8] remoteproc: imx_rproc: make clk optional
> > Applying: remoteproc: imx_rproc: make clk optional Applying patch
> > #12215303 using 'git am'
> > Description: [V5,7/8] remoteproc: imx_rproc: support i.MX7ULP
> > Applying: remoteproc: imx_rproc: support i.MX7ULP Applying patch
> > #12215305 using 'git am'
> > Description: [V5,8/8] remoteproc: imx_rproc: support i.MX8MN/P
> > Applying: remoteproc: imx_rproc: support i.MX8MN/P
> >
> >
> > If anything wrong my work flow conflicts with Linux remoteproc
> > subsystem upstream flow, please correct me, and I'll follow.
> >
> > Thanks for your time and patience on reviewing my patches. Sorry for
> > the inconvince that I bring in.
> >
> > Anyway please share me your flow to apply patches, I will try to avoid
> > unhappy things in following patches.
> >
> 
> All I asked is that you list the branch your work is based on _and_ any
> dependencies, something you did not do.

ok, got it.

> 
> I review hundreds of patchsets every year and knowing exactly how to work
> with a series goes a long way in saving precious time, time that can be used to
> review other people's submissions.
> 
> I am not angry at you but at the same time I can't review your patches if you
> are not ready to help me do so.

Understand. Since one month is a bit long period, I'll post v6 later to avoid
potential conflicts. Or if you could help check this V5 patchset based on
Linux-next/master, that would be appreciated.

Thanks,
Peng.

> 
> > Thanks,
> > Peng.
> >
> > >
> > > > Thanks,
> > > > Peng.
> > > >
> > > > >
> > > > > > Peng Fan (8):
> > > > > >   dt-bindings: remoteproc: imx_rproc: add fsl,auto-boot property
> > > > > >   dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support
> > > > > >   dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P
> > > > > >   remoteproc: imx_rproc: parse fsl,auto-boot
> > > > > >   remoteproc: imx_rproc: initial support for mutilple start/stop
> method
> > > > > >   remoteproc: imx_rproc: make clk optional
> > > > > >   remoteproc: imx_rproc: support i.MX7ULP
> > > > > >   remoteproc: imx_rproc: support i.MX8MN/P
> > > > > >
> > > > > >  .../bindings/remoteproc/fsl,imx-rproc.yaml    |  11 +-
> > > > > >  drivers/remoteproc/imx_rproc.c                | 196
> > > > > +++++++++++++++---
> > > > > >  2 files changed, 173 insertions(+), 34 deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.30.0
> > > > > >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21  2:20 peng.fan
2021-04-21  2:20 ` [PATCH V5 1/8] dt-bindings: remoteproc: imx_rproc: add fsl, auto-boot property peng.fan
2021-04-21  2:20 ` [PATCH V5 2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support peng.fan
2021-04-21  2:20 ` [PATCH V5 3/8] dt-bindings: remoteproc: imx_rproc: support i.MX8MN/P peng.fan
2021-04-21  2:20 ` [PATCH V5 4/8] remoteproc: imx_rproc: parse fsl,auto-boot peng.fan
2021-04-21  2:20 ` [PATCH V5 5/8] remoteproc: imx_rproc: initial support for mutilple start/stop method peng.fan
2021-05-03 16:30   ` Mathieu Poirier
2021-04-21  2:20 ` [PATCH V5 6/8] remoteproc: imx_rproc: make clk optional peng.fan
2021-04-21  2:20 ` [PATCH V5 7/8] remoteproc: imx_rproc: support i.MX7ULP peng.fan
2021-05-03 16:29   ` Mathieu Poirier
2021-05-06  4:11     ` Peng Fan
2021-04-21  2:20 ` [PATCH V5 8/8] remoteproc: imx_rproc: support i.MX8MN/P peng.fan
2021-05-03 16:25   ` Mathieu Poirier
2021-04-22 16:56 ` [PATCH V5 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP Mathieu Poirier
2021-04-23  1:01   ` Peng Fan
2021-04-23 14:50     ` Mathieu Poirier
2021-04-23 23:28       ` Peng Fan
2021-04-26 15:46         ` Mathieu Poirier
2021-04-26 23:45           ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0402MB2760B5F403FDA7EDED34B31C88429@DB6PR0402MB2760.eurprd04.prod.outlook.com \
    --to=peng.fan@nxp.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=o.rempel@pengutronix.de \
    --cc=ohad@wizery.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git