From: rajesh.bhagat@nxp.com (Rajesh Bhagat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller
Date: Tue, 12 Jul 2016 03:59:14 +0000 [thread overview]
Message-ID: <HE1PR0401MB23319FBFD0D42D997A05AB34E3300@HE1PR0401MB2331.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20160711064845.GH31647@shlinux2>
> -----Original Message-----
> From: Peter Chen [mailto:hzpeterchen at gmail.com]
> Sent: Monday, July 11, 2016 12:19 PM
> To: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> Cc: linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org;
> devicetree at vger.kernel.org; Peter Chen <peter.chen@nxp.com>;
> gregkh at linuxfoundation.org; kishon at ti.com; robh+dt at kernel.org;
> shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0
> controller
>
> On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote:
> > Describes the qoriq usb 2.0 controller driver binding, currently used
> > for LS1021A and LS1012A platform.
> >
> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com>
> > ---
> > Changes in v2:
> > - Adds DT binding documentation for qoriq usb 2.0 controller
> > - Changed the compatible string to fsl,ci-qoriq-usb2
> >
> > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34
> ++++++++++++++++++++++
> > 1 file changed, 34 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > new file mode 100644
> > index 0000000..8ad7306
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt
> > @@ -0,0 +1,34 @@
> > +* Freescale QorIQ SoC USB 2.0 Controllers
> > +
> > +Required properties:
> > +- compatible: Should be "fsl,ci-qoriq-usb2"
> > + Wherever applicable, the IP version of the USB controller should
> > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y).
> > + where, X.Y is IP version of USB controller.
Hello Peter,
>
> Why you need to add IP version at compatible string?
> Does it can't be read out from ID register of Identification Registers.
>
I agree. Will drop this controller version thing in DTS in v3.
> > +- reg: Should contain registers location and length
> > +- interrupts: Should contain controller interrupt
> > +- phy-names: from the *Generic PHY* bindings
> > +- phys: from the *Generic PHY* bindings
> > +- clocks: clock provider specifier
> > +- clock-names: shall be "usb2-clock"
> > +Refer to clk/clock-bindings.txt for generic clock consumer properties
> > +
> > +Recommended properties:
> > +- dr_mode: One of "host" or "peripheral".
>
> Do you support dual-role?
>
Yes. We do support both host/peripheral mode.
Best Regards,
Rajesh Bhagat
> > +- phy_type: the type of the phy connected to the core. Should be one
> > + of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this
> > + property the PORTSC register won't be touched
> > +
> > +Examples:
> > +usb at 8600000 {
> > + compatible = "fsl,ci-qoriq-usb2",
> > + "fsl,ci-qoriq-usb2-v2.5";
> > + reg = <0x0 0x8600000 0x0 0x1000>;
> > + interrupts = <0 139 0x4>;
> > + phy-names = "usb2-phy";
> > + phys = <&usbphy0>;
> > + clock-names = "usb2-clock";
> > + clocks = <&clockgen 4 3>;
> > + dr_mode = "host";
> > + phy_type = "ulpi";
> > +};
> > --
> > 2.6.2.198.g614a2ac
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb"
> > in the body of a message to majordomo at vger.kernel.org More majordomo
> > info at http://vger.kernel.org/majordomo-info.html
>
> --
>
> Best Regards,
> Peter Chen
next prev parent reply other threads:[~2016-07-12 3:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com>
[not found] ` <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com>
2016-07-09 5:53 ` [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver kbuild test robot
2016-07-09 5:59 ` kbuild test robot
2016-07-09 6:13 ` kbuild test robot
2016-07-11 6:43 ` Peter Chen
2016-07-12 3:59 ` Rajesh Bhagat
2016-07-15 7:13 ` Peter Chen
2016-07-15 8:13 ` Rajesh Bhagat
[not found] ` <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com>
2016-07-11 6:48 ` [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Peter Chen
2016-07-12 3:59 ` Rajesh Bhagat [this message]
2016-07-15 7:15 ` Peter Chen
2016-07-15 8:13 ` Rajesh Bhagat
2016-07-16 0:28 ` Rob Herring
[not found] ` <1468038656-10345-4-git-send-email-rajesh.bhagat@nxp.com>
2016-07-11 6:54 ` [PATCH v2 3/5] drivers: usb: phy: Add qoriq usb 2.0 phy driver support Peter Chen
2016-07-12 3:59 ` Rajesh Bhagat
[not found] ` <1468038656-10345-5-git-send-email-rajesh.bhagat@nxp.com>
2016-07-16 0:35 ` [PATCH v2 4/5] phy: DT binding documentation for qoriq usb 2.0 phy Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0401MB23319FBFD0D42D997A05AB34E3300@HE1PR0401MB2331.eurprd04.prod.outlook.com \
--to=rajesh.bhagat@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).