* [PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe()
@ 2021-05-11 10:04 Zhen Lei
2021-05-12 12:03 ` Alexandre TORGUE
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-05-11 10:04 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Maxime Coquelin, Alexandre Torgue,
linux-stm32, linux-arm-kernel
Cc: Zhen Lei
When devm_ioremap_resource() fails, a clear enough error message will be
printed by its subfunction __devm_ioremap_resource(). The error
information contains the device name, failure cause, and possibly resource
information.
Therefore, remove the error printing here to simplify code and reduce the
binary size.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/irqchip/irq-stm32-exti.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index b9db90c4aa566f1..4704f2ee5797a1d 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host_data->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(host_data->base)) {
- dev_err(dev, "Unable to map registers\n");
+ if (IS_ERR(host_data->base))
return PTR_ERR(host_data->base);
- }
for (i = 0; i < drv_data->bank_nr; i++)
stm32_exti_chip_init(host_data, i, np);
--
2.26.0.106.g9fadedd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe()
2021-05-11 10:04 [PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe() Zhen Lei
@ 2021-05-12 12:03 ` Alexandre TORGUE
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre TORGUE @ 2021-05-12 12:03 UTC (permalink / raw)
To: Zhen Lei, Thomas Gleixner, Marc Zyngier, Maxime Coquelin,
linux-stm32, linux-arm-kernel
On 5/11/21 12:04 PM, Zhen Lei wrote:
> When devm_ioremap_resource() fails, a clear enough error message will be
> printed by its subfunction __devm_ioremap_resource(). The error
> information contains the device name, failure cause, and possibly resource
> information.
>
> Therefore, remove the error printing here to simplify code and reduce the
> binary size.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> ---
> drivers/irqchip/irq-stm32-exti.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index b9db90c4aa566f1..4704f2ee5797a1d 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -892,10 +892,8 @@ static int stm32_exti_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> host_data->base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(host_data->base)) {
> - dev_err(dev, "Unable to map registers\n");
> + if (IS_ERR(host_data->base))
> return PTR_ERR(host_data->base);
> - }
>
> for (i = 0; i < drv_data->bank_nr; i++)
> stm32_exti_chip_init(host_data, i, np);
>
Acked-by: Alexandre TORGUE <alexandre.torgue@foss.st.com>
thanks
alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 10:04 [PATCH 1/1] irqchip/stm32-exti: Remove redundant error printing in stm32_exti_probe() Zhen Lei
2021-05-12 12:03 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).