* sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c
@ 2019-11-26 10:42 Marc Gonzalez
2019-11-28 10:44 ` Vincenzo Frascino
0 siblings, 1 reply; 6+ messages in thread
From: Marc Gonzalez @ 2019-11-26 10:42 UTC (permalink / raw)
To: Vincenzo Frascino, Thomas Gleixner
Cc: Mark Rutland, Arnd Bergmann, Ard Biesheuvel, Catalin Marinas,
Will Deacon, Russell King, Dave Martin, Linux ARM
Hello,
Running 'make C=2' on v5.4 (arm64 defconfig) outputs:
CHECK arch/arm64/kernel/vdso/vgettimeofday.c
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:49:38: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:50:47: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:51:29: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:52:26: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:53:21: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:56:38: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:57:26: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:58:30: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:59:18: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:65:46: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:78:38: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:79:37: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:80:38: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:81:18: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:87:58: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:91:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:99:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:100:31: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:102:26: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:105:31: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:113:47: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:115:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:116:46: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:126:43: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:132:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:133:45: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:136:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:137:33: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:138:34: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:146:58: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:148:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:151:28: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:152:53: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:154:32: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:155:38: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:158:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:159:56: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:160:52: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:183:58: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:189:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:192:23: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:192:23: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:192:23: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:217:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:226:46: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:228:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:229:45: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:239:42: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:245:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:246:44: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:249:13: warning: call with no type!
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:250:33: warning: unknown expression (8 46)
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:251:34: warning: unknown expression (8 46)
arch/arm64/kernel/vdso/vgettimeofday.c:11:5: warning: symbol '__kernel_clock_gettime' was not declared. Should it be static?
arch/arm64/kernel/vdso/vgettimeofday.c:17:5: warning: symbol '__kernel_gettimeofday' was not declared. Should it be static?
arch/arm64/kernel/vdso/vgettimeofday.c:23:5: warning: symbol '__kernel_clock_getres' was not declared. Should it be static?
Are the above warnings all false positives?
Do I need to update my version of sparse maybe?
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c
2019-11-26 10:42 sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c Marc Gonzalez
@ 2019-11-28 10:44 ` Vincenzo Frascino
2019-11-28 12:24 ` Marc Gonzalez
0 siblings, 1 reply; 6+ messages in thread
From: Vincenzo Frascino @ 2019-11-28 10:44 UTC (permalink / raw)
To: Marc Gonzalez, Thomas Gleixner
Cc: Mark Rutland, Arnd Bergmann, Ard Biesheuvel, Catalin Marinas,
Will Deacon, Russell King, Dave Martin, Linux ARM
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
Hello Marc,
On 26/11/2019 10:42, Marc Gonzalez wrote:
> Hello,
>
> Running 'make C=2' on v5.4 (arm64 defconfig) outputs:
>
> CHECK arch/arm64/kernel/vdso/vgettimeofday.c
[...]
>
>
> Are the above warnings all false positives?
> Do I need to update my version of sparse maybe?
>
I downloaded the latest git of sparse and seems that the only warning I am
getting is:
linux/lib/vdso/gettimeofday.c:224:5: warning: symbol '__cvdso_clock_getres' was
not declared. Should it be static?
which seems legitimate. I am going to post a fix to it.
> Regards.
>
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c
2019-11-28 10:44 ` Vincenzo Frascino
@ 2019-11-28 12:24 ` Marc Gonzalez
2019-11-28 12:29 ` Vincenzo Frascino
0 siblings, 1 reply; 6+ messages in thread
From: Marc Gonzalez @ 2019-11-28 12:24 UTC (permalink / raw)
To: Vincenzo Frascino, Thomas Gleixner
Cc: Mark Rutland, Arnd Bergmann, Ard Biesheuvel, Catalin Marinas,
Will Deacon, Russell King, Dave Martin, Linux ARM
On 28/11/2019 11:44, Vincenzo Frascino wrote:
> On 26/11/2019 10:42, Marc Gonzalez wrote:
>
>> Running 'make C=2' on v5.4 (arm64 defconfig) outputs:
>>
>> CHECK arch/arm64/kernel/vdso/vgettimeofday.c
>
> [...]
>
>> Are the above warnings all false positives?
>> Do I need to update my version of sparse maybe?
>>
>
> I downloaded the latest git of sparse and seems that the only warning I am
> getting is:
>
> linux/lib/vdso/gettimeofday.c:224:5: warning: symbol '__cvdso_clock_getres' was
> not declared. Should it be static?
Interesting. Dunno which version I'm running, as sparse appears
to ignores the --version flag.
$ apt list --installed | grep ^sparse
sparse/bionic,now 0.5.1-2 amd64 [installed]
https://sparse.wiki.kernel.org/index.php/Main_Page
I appear to be running a 2 year old version.
Sorry for the noise. I need to figure out how to upgrade this without
breaking apt...
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c
2019-11-28 12:24 ` Marc Gonzalez
@ 2019-11-28 12:29 ` Vincenzo Frascino
2020-01-23 9:58 ` Marc Gonzalez
0 siblings, 1 reply; 6+ messages in thread
From: Vincenzo Frascino @ 2019-11-28 12:29 UTC (permalink / raw)
To: Marc Gonzalez, Thomas Gleixner
Cc: Mark Rutland, Arnd Bergmann, Ard Biesheuvel, Catalin Marinas,
Will Deacon, Russell King, Dave Martin, Linux ARM
[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]
Hi Marc,
On 28/11/2019 12:24, Marc Gonzalez wrote:
> On 28/11/2019 11:44, Vincenzo Frascino wrote:
>
>> On 26/11/2019 10:42, Marc Gonzalez wrote:
>>
>>> Running 'make C=2' on v5.4 (arm64 defconfig) outputs:
>>>
>>> CHECK arch/arm64/kernel/vdso/vgettimeofday.c
>>
>> [...]
>>
>>> Are the above warnings all false positives?
>>> Do I need to update my version of sparse maybe?
>>>
>>
>> I downloaded the latest git of sparse and seems that the only warning I am
>> getting is:
>>
>> linux/lib/vdso/gettimeofday.c:224:5: warning: symbol '__cvdso_clock_getres' was
>> not declared. Should it be static?
>
> Interesting. Dunno which version I'm running, as sparse appears
> to ignores the --version flag.
>
> $ apt list --installed | grep ^sparse
> sparse/bionic,now 0.5.1-2 amd64 [installed]
>
> https://sparse.wiki.kernel.org/index.php/Main_Page
>
> I appear to be running a 2 year old version.
>
I thought so ;)
> Sorry for the noise. I need to figure out how to upgrade this without
> breaking apt...
>
No problem. I use the latest version built from git in my dev environment and
export it in the PATH. This does not break apt. An alternative could be to
create a package and install it, but I find the first easier to update.
Hope it helps.
> Regards.
>
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c
2019-11-28 12:29 ` Vincenzo Frascino
@ 2020-01-23 9:58 ` Marc Gonzalez
2020-01-23 10:10 ` Vincenzo Frascino
0 siblings, 1 reply; 6+ messages in thread
From: Marc Gonzalez @ 2020-01-23 9:58 UTC (permalink / raw)
To: Vincenzo Frascino, Thomas Gleixner
Cc: Mark Rutland, Arnd Bergmann, Ard Biesheuvel, Catalin Marinas,
Will Deacon, Russell King, Dave Martin, Linux ARM
On 28/11/2019 13:29, Vincenzo Frascino wrote:
> On 28/11/2019 12:24, Marc Gonzalez wrote:
>
>> On 28/11/2019 11:44, Vincenzo Frascino wrote:
>>
>>> On 26/11/2019 10:42, Marc Gonzalez wrote:
>>>
>>>> Running 'make C=2' on v5.4 (arm64 defconfig) outputs:
>>>>
>>>> CHECK arch/arm64/kernel/vdso/vgettimeofday.c
>>>
>>> [...]
>>>
>>>> Are the above warnings all false positives?
>>>> Do I need to update my version of sparse maybe?
>>>>
>>>
>>> I downloaded the latest git of sparse and seems that the only warning I am
>>> getting is:
>>>
>>> linux/lib/vdso/gettimeofday.c:224:5: warning: symbol '__cvdso_clock_getres' was
>>> not declared. Should it be static?
>>
>> Interesting. Dunno which version I'm running, as sparse appears
>> to ignores the --version flag.
>>
>> $ apt list --installed | grep ^sparse
>> sparse/bionic,now 0.5.1-2 amd64 [installed]
>>
>> https://sparse.wiki.kernel.org/index.php/Main_Page
>>
>> I appear to be running a 2 year old version.
>>
>
> I thought so ;)
>
>> Sorry for the noise. I need to figure out how to upgrade this without
>> breaking apt...
>>
>
> No problem. I use the latest version built from git in my dev environment and
> export it in the PATH. This does not break apt. An alternative could be to
> create a package and install it, but I find the first easier to update.
I haven't upgraded sparse yet, but I've been playing with make W=1 lately,
using gcc 9.2. On v5.5-rc1, I see the following warnings:
CC arch/arm64/kernel/vdso/vgettimeofday.o
In file included from <command-line>:
/home/mgonzalez/linux/lib/vdso/gettimeofday.c:224:5: warning: no previous prototype for '__cvdso_clock_getres' [-Wmissing-prototypes]
224 | int __cvdso_clock_getres(clockid_t clock, struct __kernel_timespec *res)
| ^~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/vdso/vgettimeofday.c:11:5: warning: no previous prototype for '__kernel_clock_gettime' [-Wmissing-prototypes]
11 | int __kernel_clock_gettime(clockid_t clock,
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/vdso/vgettimeofday.c:17:5: warning: no previous prototype for '__kernel_gettimeofday' [-Wmissing-prototypes]
17 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv,
| ^~~~~~~~~~~~~~~~~~~~~
arch/arm64/kernel/vdso/vgettimeofday.c:23:5: warning: no previous prototype for '__kernel_clock_getres' [-Wmissing-prototypes]
23 | int __kernel_clock_getres(clockid_t clock_id,
| ^~~~~~~~~~~~~~~~~~~~~
I suppose the __cvdso_clock_getres warning is fixed in v5.6?
The other warnings might be false positives?
Regards.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c
2020-01-23 9:58 ` Marc Gonzalez
@ 2020-01-23 10:10 ` Vincenzo Frascino
0 siblings, 0 replies; 6+ messages in thread
From: Vincenzo Frascino @ 2020-01-23 10:10 UTC (permalink / raw)
To: Marc Gonzalez, Thomas Gleixner
Cc: Mark Rutland, Arnd Bergmann, Ard Biesheuvel, Catalin Marinas,
Will Deacon, Russell King, Dave Martin, Linux ARM
[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]
Hi Marc,
On 23/01/2020 09:58, Marc Gonzalez wrote:
[...]
>
> I haven't upgraded sparse yet, but I've been playing with make W=1 lately,
> using gcc 9.2. On v5.5-rc1, I see the following warnings:
>
> CC arch/arm64/kernel/vdso/vgettimeofday.o
> In file included from <command-line>:
> /home/mgonzalez/linux/lib/vdso/gettimeofday.c:224:5: warning: no previous prototype for '__cvdso_clock_getres' [-Wmissing-prototypes]
> 224 | int __cvdso_clock_getres(clockid_t clock, struct __kernel_timespec *res)
> | ^~~~~~~~~~~~~~~~~~~~
> arch/arm64/kernel/vdso/vgettimeofday.c:11:5: warning: no previous prototype for '__kernel_clock_gettime' [-Wmissing-prototypes]
> 11 | int __kernel_clock_gettime(clockid_t clock,
> | ^~~~~~~~~~~~~~~~~~~~~~
> arch/arm64/kernel/vdso/vgettimeofday.c:17:5: warning: no previous prototype for '__kernel_gettimeofday' [-Wmissing-prototypes]
> 17 | int __kernel_gettimeofday(struct __kernel_old_timeval *tv,
> | ^~~~~~~~~~~~~~~~~~~~~
> arch/arm64/kernel/vdso/vgettimeofday.c:23:5: warning: no previous prototype for '__kernel_clock_getres' [-Wmissing-prototypes]
> 23 | int __kernel_clock_getres(clockid_t clock_id,
> | ^~~~~~~~~~~~~~~~~~~~~
>
>
> I suppose the __cvdso_clock_getres warning is fixed in v5.6?
>
This should be fixed in 5.5 went via tip/urgent.
Gitweb:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=ffd08731b2d632459428612431060cf902324a8d
> The other warnings might be false positives?
>
Yes, this is correct.
> Regards.
>
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-23 10:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-26 10:42 sparse warnings for arch/arm64/kernel/vdso/vgettimeofday.c Marc Gonzalez
2019-11-28 10:44 ` Vincenzo Frascino
2019-11-28 12:24 ` Marc Gonzalez
2019-11-28 12:29 ` Vincenzo Frascino
2020-01-23 9:58 ` Marc Gonzalez
2020-01-23 10:10 ` Vincenzo Frascino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).