* [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
@ 2021-05-06 12:02 Tian Tao
2021-06-01 12:46 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Tian Tao @ 2021-05-06 12:02 UTC (permalink / raw)
To: will, mark.rutland; +Cc: linux-arm-kernel, Tian Tao
request_irq() after setting IRQ_NOAUTOEN as below
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/perf/arm_pmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index d4f7f1f..6bcfc52 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
}
irq_flags = IRQF_PERCPU |
- IRQF_NOBALANCING |
+ IRQF_NOBALANCING | IRQF_NO_AUTOEN |
IRQF_NO_THREAD;
- irq_set_status_flags(irq, IRQ_NOAUTOEN);
-
err = request_nmi(irq, handler, irq_flags, "arm-pmu",
per_cpu_ptr(&cpu_armpmu, cpu));
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
2021-05-06 12:02 [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
@ 2021-06-01 12:46 ` Will Deacon
2021-06-01 13:00 ` tiantao (H)
0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2021-06-01 12:46 UTC (permalink / raw)
To: Tian Tao; +Cc: mark.rutland, linux-arm-kernel
On Thu, May 06, 2021 at 08:02:59PM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/perf/arm_pmu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index d4f7f1f..6bcfc52 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
> }
>
> irq_flags = IRQF_PERCPU |
> - IRQF_NOBALANCING |
> + IRQF_NOBALANCING | IRQF_NO_AUTOEN |
> IRQF_NO_THREAD;
>
> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
> -
> err = request_nmi(irq, handler, irq_flags, "arm-pmu",
> per_cpu_ptr(&cpu_armpmu, cpu));
Please can you update drivers/perf/qcom_l2_pmu.c at the same time?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
2021-06-01 12:46 ` Will Deacon
@ 2021-06-01 13:00 ` tiantao (H)
0 siblings, 0 replies; 3+ messages in thread
From: tiantao (H) @ 2021-06-01 13:00 UTC (permalink / raw)
To: Will Deacon, Tian Tao; +Cc: mark.rutland, linux-arm-kernel
在 2021/6/1 20:46, Will Deacon 写道:
> On Thu, May 06, 2021 at 08:02:59PM +0800, Tian Tao wrote:
>> request_irq() after setting IRQ_NOAUTOEN as below
>> irq_set_status_flags(irq, IRQ_NOAUTOEN);
>> request_irq(dev, irq...);
>> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>>
>> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
>> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>>
>> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
>> ---
>> drivers/perf/arm_pmu.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
>> index d4f7f1f..6bcfc52 100644
>> --- a/drivers/perf/arm_pmu.c
>> +++ b/drivers/perf/arm_pmu.c
>> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
>> }
>>
>> irq_flags = IRQF_PERCPU |
>> - IRQF_NOBALANCING |
>> + IRQF_NOBALANCING | IRQF_NO_AUTOEN |
>> IRQF_NO_THREAD;
>>
>> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
>> -
>> err = request_nmi(irq, handler, irq_flags, "arm-pmu",
>> per_cpu_ptr(&cpu_armpmu, cpu));
> Please can you update drivers/perf/qcom_l2_pmu.c at the same time?
ok I will send v2.
>
> Will
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-01 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 12:02 [PATCH] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-06-01 12:46 ` Will Deacon
2021-06-01 13:00 ` tiantao (H)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).