Re: [PATCH v6 4/5] tty: serial: qcom_geni_serial: Wakeup over UART RX

From: Akash Asthana <akashast@codeaurora.org>
To: Stephen Boyd <swboyd@chromium.org>, gregkh@linuxfoundation.org
Cc: mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 4/5] tty: serial: qcom_geni_serial: Wakeup over UART RX
Date: Mon, 25 Nov 2019 12:06:01 +0000	[thread overview]
Message-ID: <0101016ea2744c4a-7adfad72-f828-4de1-b16f-e70970b3a343-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <5dd82779.1c69fb81.c1de1.90e5@mx.google.com>


On 11/22/2019 11:52 PM, Stephen Boyd wrote:
> Quoting Akash Asthana (2019-11-22 06:18:19)
>> Add system wakeup capability over UART RX line for wakeup capable UART.
>> When system is suspended, RX line act as an interrupt to wakeup system
>> for any communication requests from peer.
>>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>
> One question below.
>
>> @@ -1330,6 +1354,10 @@ static int qcom_geni_serial_remove(struct platform_device *pdev)
>>          struct uart_driver *drv = port->uport.private_data;
>>   
>>          uart_remove_one_port(drv, &port->uport);
>> +
>> +       device_init_wakeup(&pdev->dev, false);
>> +       dev_pm_clear_wake_irq(&pdev->dev);
> Should this order be swapped? Usually remove is done in reverse of probe
> order, so clear_wake_irq, init wakeup, and remove uart port. I'm not
> convinced it will actually matter though so maybe this isn't a problem.
Ok, I will update the order here.

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project