Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Akash Asthana <akashast@codeaurora.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: gregkh@linuxfoundation.org, swboyd@chromium.org,
	mgautam@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 4/5] tty: serial: qcom_geni_serial: Wakeup over UART RX
Date: Mon, 25 Nov 2019 12:06:40 +0000
Message-ID: <0101016ea274e5c0-c415ca3d-9707-481d-873a-6f23a13642e8-000000@us-west-2.amazonses.com> (raw)
In-Reply-To: <20191122191147.GO27773@google.com>


On 11/23/2019 12:41 AM, Matthias Kaehlcke wrote:
> On Fri, Nov 22, 2019 at 02:18:19PM +0000, Akash Asthana wrote:
>> Add system wakeup capability over UART RX line for wakeup capable UART.
>> When system is suspended, RX line act as an interrupt to wakeup system
>> for any communication requests from peer.
>>
>> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
>> ---
>> Changes in V6:
>>   - Rebased on top of tty-next branch.
>>   - As per stephen's comment mark devices runtime status as active
>>     irrespective of wakeup feature.
>>
>> Changes in V5:
>>   - No change.
>>
>> Changes in V4:
>>   - As per Greg's comment, removed extra dev_err logging.
>>   - As per Stephen's comment, using common code that manage wakeirq irqs for
>>     devices. Using dev_pm_set_dedicated_wake_irq API that will take care of
>>     requesting and attaching wakeup irqs for devices. Also, it sets wakeirq
>>     status to WAKE_IRQ_DEDICATED_ALLOCATED as a result enabling/disabling of
>>     wake irq will be managed by suspend/resume framework so, removed the code
>>     for enabling and disabling of wake irq from the driver.
>>
>> Changes in V3:
>>   - As per Stephen's comment, using platform_get_irq_optional API to get wakeup
>>     IRQ for device.
>>
>> Changes in V2:
>>   - As per Stephen's comment, splitted V1 patch into 2 seperate patch.
>>     a) Clean up of core IRQ registration b) Add wakeup feature.
>>
>>   drivers/tty/serial/qcom_geni_serial.c | 28 ++++++++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
>> index 634054a..b952509 100644
>> --- a/drivers/tty/serial/qcom_geni_serial.c
>> +++ b/drivers/tty/serial/qcom_geni_serial.c
>> @@ -14,6 +14,8 @@
>>   #include <linux/of.h>
>>   #include <linux/of_device.h>
>>   #include <linux/platform_device.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/pm_wakeirq.h>
>>   #include <linux/qcom-geni-se.h>
>>   #include <linux/serial.h>
>>   #include <linux/serial_core.h>
>> @@ -116,6 +118,7 @@ struct qcom_geni_serial_port {
>>   	bool brk;
>>   
>>   	unsigned int tx_remaining;
>> +	int wakeup_irq;
>>   };
>>   
>>   static const struct uart_ops qcom_geni_console_pops;
>> @@ -1302,6 +1305,9 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
>>   		return irq;
>>   	uport->irq = irq;
>>   
>> +	if (!console)
>> +		port->wakeup_irq = platform_get_irq_optional(pdev, 1);
>> +
>>   	uport->private_data = drv;
>>   	platform_set_drvdata(pdev, port);
>>   	port->handle_rx = console ? handle_rx_console : handle_rx_uart;
>> @@ -1321,6 +1327,24 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
>>   		return ret;
>>   	}
>>   
>> +	/*
>> +	 * Set pm_runtime status as ACTIVE so that wakeup_irq gets
>> +	 * enabled/disabled from dev_pm_arm_wake_irq  during  system
> nit: remove one of the two blanks before/after 'during'.
ok
>
>> +	 * suspend/resume respectively.
>> +	 */
>> +	pm_runtime_set_active(&pdev->dev);
>> +
>> +	if (port->wakeup_irq > 0) {
>> +		device_init_wakeup(&pdev->dev, true);
>> +		ret = dev_pm_set_dedicated_wake_irq(&pdev->dev,
>> +						port->wakeup_irq);
>> +		if (ret) {
>> +			device_init_wakeup(&pdev->dev, false);
>> +			uart_remove_one_port(drv, uport);
>> +			return ret;
>> +		}
>> +	}
>> +
>>   	return ret;
>>   }
>>   
>> @@ -1330,6 +1354,10 @@ static int qcom_geni_serial_remove(struct platform_device *pdev)
>>   	struct uart_driver *drv = port->uport.private_data;
>>   
>>   	uart_remove_one_port(drv, &port->uport);
>> +
>> +	device_init_wakeup(&pdev->dev, false);
>> +	dev_pm_clear_wake_irq(&pdev->dev);
>> +
>>   	return 0;
>>   }
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project


  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1574432266-20732-1-git-send-email-akashast@codeaurora.org>
2019-11-22 14:18 ` [PATCH v6 1/5] Revert "tty: serial: qcom_geni_serial: Wakeup over UART RX" Akash Asthana
2019-11-22 14:18 ` [PATCH v6 2/5] Revert "tty: serial: qcom_geni_serial: IRQ cleanup" Akash Asthana
2019-11-22 14:18 ` [PATCH v6 3/5] tty: serial: qcom_geni_serial: IRQ cleanup Akash Asthana
2019-11-22 18:46   ` Matthias Kaehlcke
2019-11-25 12:04     ` Akash Asthana
2019-11-22 14:18 ` [PATCH v6 4/5] tty: serial: qcom_geni_serial: Wakeup over UART RX Akash Asthana
2019-11-22 18:22   ` Stephen Boyd
2019-11-25 12:06     ` Akash Asthana
2019-11-22 19:11   ` Matthias Kaehlcke
2019-11-25 12:06     ` Akash Asthana [this message]
2019-11-22 14:18 ` [PATCH v6 5/5] tty: serial: qcom_geni_serial: Move loopback support to TIOCM_LOOP Akash Asthana
2019-11-22 18:07   ` Stephen Boyd
     [not found] ` <0101016e937a3f78-11fa1469-8c73-4f56-a3de-3221dcf6f0e3-000000@us-west-2.amazonses.com>
2019-11-22 18:15   ` [PATCH v6 3/5] tty: serial: qcom_geni_serial: IRQ cleanup Stephen Boyd

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0101016ea274e5c0-c415ca3d-9707-481d-873a-6f23a13642e8-000000@us-west-2.amazonses.com \
    --to=akashast@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mgautam@codeaurora.org \
    --cc=mka@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git