* [PATCH v3] clk: qcom: msm8916: Don't build drivers by default
@ 2019-06-19 11:44 Marc Gonzalez
2019-06-19 13:47 ` Georgi Djakov
0 siblings, 1 reply; 4+ messages in thread
From: Marc Gonzalez @ 2019-06-19 11:44 UTC (permalink / raw)
To: Stephen Boyd, Michael Turquette
Cc: linux-clk, MSM, Georgi Djakov, Amit Kucheria, Bjorn Andersson
QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
built by default. List them in defconfig after dropping the default.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
---
arch/arm64/configs/defconfig | 2 ++
drivers/clk/qcom/Kconfig | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5a8e853833cf..3277944626c2 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -658,6 +658,8 @@ CONFIG_CLK_IMX8MQ=y
CONFIG_CLK_IMX8QXP=y
CONFIG_TI_SCI_CLK=y
CONFIG_COMMON_CLK_QCOM=y
+CONFIG_QCOM_A53PLL=y
+CONFIG_QCOM_CLK_APCS_MSM8916=y
CONFIG_QCOM_CLK_SMD_RPM=y
CONFIG_QCOM_CLK_RPMH=y
CONFIG_IPQ_GCC_8074=y
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index e1ff83cc361e..6461a1aa7325 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -21,7 +21,6 @@ if COMMON_CLK_QCOM
config QCOM_A53PLL
tristate "MSM8916 A53 PLL"
- default ARCH_QCOM
help
Support for the A53 PLL on MSM8916 devices. It provides
the CPU with frequencies above 1GHz.
@@ -31,7 +30,6 @@ config QCOM_A53PLL
config QCOM_CLK_APCS_MSM8916
tristate "MSM8916 APCS Clock Controller"
depends on QCOM_APCS_IPC || COMPILE_TEST
- default ARCH_QCOM
help
Support for the APCS Clock Controller on msm8916 devices. The
APCS is managing the mux and divider which feeds the CPUs.
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] clk: qcom: msm8916: Don't build drivers by default
2019-06-19 11:44 [PATCH v3] clk: qcom: msm8916: Don't build drivers by default Marc Gonzalez
@ 2019-06-19 13:47 ` Georgi Djakov
2019-06-21 11:36 ` Marc Gonzalez
0 siblings, 1 reply; 4+ messages in thread
From: Georgi Djakov @ 2019-06-19 13:47 UTC (permalink / raw)
To: Marc Gonzalez, Stephen Boyd, Michael Turquette
Cc: linux-clk, MSM, Amit Kucheria, Bjorn Andersson
On 19.06.19 14:44, Marc Gonzalez wrote:
> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> built by default. List them in defconfig after dropping the default.
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> ---
> arch/arm64/configs/defconfig | 2 ++
> drivers/clk/qcom/Kconfig | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
Hi Marc,
Sorry, I wasn't very clear. IMHO the defconfig change should be a
separate patch and the v2 of this patch is ok as it is. It would just
make things easier to merge.
Thanks,
Georgi
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 5a8e853833cf..3277944626c2 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -658,6 +658,8 @@ CONFIG_CLK_IMX8MQ=y
> CONFIG_CLK_IMX8QXP=y
> CONFIG_TI_SCI_CLK=y
> CONFIG_COMMON_CLK_QCOM=y
> +CONFIG_QCOM_A53PLL=y
> +CONFIG_QCOM_CLK_APCS_MSM8916=y
> CONFIG_QCOM_CLK_SMD_RPM=y
> CONFIG_QCOM_CLK_RPMH=y
> CONFIG_IPQ_GCC_8074=y
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index e1ff83cc361e..6461a1aa7325 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -21,7 +21,6 @@ if COMMON_CLK_QCOM
>
> config QCOM_A53PLL
> tristate "MSM8916 A53 PLL"
> - default ARCH_QCOM
> help
> Support for the A53 PLL on MSM8916 devices. It provides
> the CPU with frequencies above 1GHz.
> @@ -31,7 +30,6 @@ config QCOM_A53PLL
> config QCOM_CLK_APCS_MSM8916
> tristate "MSM8916 APCS Clock Controller"
> depends on QCOM_APCS_IPC || COMPILE_TEST
> - default ARCH_QCOM
> help
> Support for the APCS Clock Controller on msm8916 devices. The
> APCS is managing the mux and divider which feeds the CPUs.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] clk: qcom: msm8916: Don't build drivers by default
2019-06-19 13:47 ` Georgi Djakov
@ 2019-06-21 11:36 ` Marc Gonzalez
2019-06-23 18:54 ` Amit Kucheria
0 siblings, 1 reply; 4+ messages in thread
From: Marc Gonzalez @ 2019-06-21 11:36 UTC (permalink / raw)
To: Georgi Djakov, Stephen Boyd, Michael Turquette
Cc: linux-clk, MSM, Amit Kucheria, Bjorn Andersson
On 19/06/2019 15:47, Georgi Djakov wrote:
> On 19.06.19 14:44, Marc Gonzalez wrote:
>
>> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
>> built by default. List them in defconfig after dropping the default.
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
>> ---
>> arch/arm64/configs/defconfig | 2 ++
>> drivers/clk/qcom/Kconfig | 2 --
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Sorry, I wasn't very clear. IMHO the defconfig change should be a
> separate patch and the v2 of this patch is ok as it is. It would just
> make things easier to merge.
Oh, I see. Could you give your Ack on patch 2 then?
Would the defconfig change go through the clk tree?
Or maybe through the qcom tree?
Regards.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] clk: qcom: msm8916: Don't build drivers by default
2019-06-21 11:36 ` Marc Gonzalez
@ 2019-06-23 18:54 ` Amit Kucheria
0 siblings, 0 replies; 4+ messages in thread
From: Amit Kucheria @ 2019-06-23 18:54 UTC (permalink / raw)
To: Marc Gonzalez
Cc: Georgi Djakov, Stephen Boyd, Michael Turquette, linux-clk, MSM,
Bjorn Andersson
On Fri, Jun 21, 2019 at 5:06 PM Marc Gonzalez <marc.w.gonzalez@free.fr> wrote:
>
> On 19/06/2019 15:47, Georgi Djakov wrote:
>
> > On 19.06.19 14:44, Marc Gonzalez wrote:
> >
> >> QCOM_A53PLL and QCOM_CLK_APCS_MSM8916 stand out as the only options
> >> built by default. List them in defconfig after dropping the default.
> >>
> >> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> >> ---
> >> arch/arm64/configs/defconfig | 2 ++
> >> drivers/clk/qcom/Kconfig | 2 --
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Sorry, I wasn't very clear. IMHO the defconfig change should be a
> > separate patch and the v2 of this patch is ok as it is. It would just
> > make things easier to merge.
>
> Oh, I see. Could you give your Ack on patch 2 then?
>
> Would the defconfig change go through the clk tree?
> Or maybe through the qcom tree?
This defconfig change could easily go through the qcom tree IMO.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-23 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 11:44 [PATCH v3] clk: qcom: msm8916: Don't build drivers by default Marc Gonzalez
2019-06-19 13:47 ` Georgi Djakov
2019-06-21 11:36 ` Marc Gonzalez
2019-06-23 18:54 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).