From: Tao Zhang <quic_taozha@quicinc.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konradybcio@gmail.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Jinlong Mao <quic_jinlmao@quicinc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<coresight@lists.linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <andersson@kernel.org>
Subject: Re: [PATCH v4 00/11] Add support to configure TPDM DSB subunit
Date: Thu, 1 Jun 2023 16:17:59 +0800 [thread overview]
Message-ID: <13686cd8-c887-32ef-d314-0955be366373@quicinc.com> (raw)
In-Reply-To: <725b6ccd-ff70-a3d2-fe44-797c0509e643@quicinc.com>
On 5/23/2023 3:50 PM, Tao Zhang wrote:
> On 4/28/2023 12:53 AM, Suzuki K Poulose wrote:
>> On 27/04/2023 10:00, Tao Zhang wrote:
>>> Introduction of TPDM DSB subunit
>>> DSB subunit is responsible for creating a dataset element, and is also
>>> optionally responsible for packing it to fit multiple elements on a
>>> single ATB transfer if possible in the configuration. The TPDM Core
>>> Datapath requests timestamps be stored by the TPDA and then delivering
>>> ATB sized data (depending on ATB width and element size, this could
>>> be smaller or larger than a dataset element) to the ATB Mast FSM.
>>>
>>> The DSB subunit must be configured prior to enablement. This series
>>> adds support for TPDM to configure the configure DSB subunit.
>>>
>>> Once this series patches are applied properly, the new tpdm nodes for
>>> should be observed at the tpdm path /sys/bus/coresight/devices/tpdm*
>>> which supports DSB subunit.
>>> e.g.
>>> /sys/devices/platform/soc@0/69d0000.tpdm/tpdm0#ls -l | grep dsb
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_edge_ctrl
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_edge_ctrl_mask
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_mode
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_patt_mask
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_patt_ts
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_patt_type
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_patt_val
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_trig_patt_mask
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_trig_patt_val
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_trig_ts
>>> -rw-r--r-- 1 root root 4096 Jan 1 00:01 dsb_trig_type
>>>
>>> We can use the commands are similar to the below to configure the
>>> TPDMs which support DSB subunit. Enable coresight sink first.
>>> echo 1 > /sys/bus/coresight/devices/tmc_etf0/enable_sink
>>> echo 1 > /sys/bus/coresight/devices/tpdm0/reset
>>> echo 0x3 0x3 0x1 > /sys/bus/coresight/devices/tpdm0/dsb_edge_ctrl_mask
>>> echo 0x6d 0x6d 0 > /sys/bus/coresight/devices/tpdm0/dsb_edge_ctrl
>>> echo 1 > /sys/bus/coresight/devices/tpdm0/dsb_patt_ts
>>> echo 1 > /sys/bus/coresight/devices/tpdm0/dsb_patt_type
>>> echo 0 > /sys/bus/coresight/devices/tpdm0/dsb_trig_ts
>>> echo 0 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm0/dsb_patt_mask
>>> echo 0 0xFFFFFFFF > /sys/bus/coresight/devices/tpdm0/dsb_trig_patt_val
>>>
>>> This patch series depends on patch series "[PATCH v2 0/9] coresight:
>>> Fix CTI module refcount leak by making it a helper device"
>>> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20230425143542.2305069-14-james.clark@arm.com/
>>>
>>
>> There is v6 available for the above and there may be changes in the data
>> structures. But the series is stable now, and may be you could cordinate
>> with James and repost the series at rc1 ?
>
> This patch series has depended on James's v6 patch series. It's a
> description mistake.
>
> The link I posted is James's v6 patch series.
>
> Would you mind continue to review this patch series first?
>
>
> Tao
>
Hi Suzuki,
Do you have more review comments on the rest of the patches(#5-#11) in
this series?
Or do you prefer me to update patches(#1-#4) and resubmit first?
Best,
Tao
>>
>> Suzuki
>>
>> _______________________________________________
>> CoreSight mailing list -- coresight@lists.linaro.org
>> To unsubscribe send an email to coresight-leave@lists.linaro.org
next prev parent reply other threads:[~2023-06-01 8:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 9:00 [PATCH v4 00/11] Add support to configure TPDM DSB subunit Tao Zhang
2023-04-27 9:00 ` [PATCH v4 01/11] dt-bindings: arm: Add support for DSB element size Tao Zhang
2023-04-27 12:59 ` Rob Herring
2023-04-27 9:00 ` [PATCH v4 02/11] coresight-tpda: Add DSB dataset support Tao Zhang
2023-05-23 10:07 ` Suzuki K Poulose
2023-05-23 14:48 ` Suzuki K Poulose
2023-05-25 7:20 ` Tao Zhang
2023-05-25 7:16 ` Tao Zhang
2023-05-25 9:08 ` Suzuki K Poulose
2023-05-26 3:22 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 03/11] coresight-tpdm: Initialize DSB subunit configuration Tao Zhang
2023-05-23 13:42 ` Suzuki K Poulose
2023-05-25 8:12 ` Tao Zhang
2023-05-25 9:09 ` Suzuki K Poulose
2023-05-26 3:46 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 04/11] coresight-tpdm: Add reset node to TPDM node Tao Zhang
2023-05-23 14:53 ` Suzuki K Poulose
2023-05-25 8:36 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 05/11] coresight-tpdm: Add nodes to set trigger timestamp and type Tao Zhang
2023-06-01 9:05 ` Suzuki K Poulose
2023-06-02 2:29 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 06/11] coresight-tpdm: Add node to set dsb programming mode Tao Zhang
2023-06-01 9:23 ` Suzuki K Poulose
2023-06-02 2:58 ` Tao Zhang
2023-06-02 8:25 ` Suzuki K Poulose
2023-06-02 8:31 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 07/11] coresight-tpdm: Add nodes for dsb edge control Tao Zhang
2023-06-01 12:14 ` Suzuki K Poulose
2023-06-02 8:21 ` Tao Zhang
2023-06-02 8:45 ` Suzuki K Poulose
2023-06-02 9:00 ` Suzuki K Poulose
2023-06-05 9:12 ` Tao Zhang
2023-06-02 14:38 ` Tao Zhang
2023-06-02 16:05 ` Suzuki K Poulose
2023-04-27 9:00 ` [PATCH v4 08/11] coresight-tpdm: Add nodes to configure pattern match output Tao Zhang
2023-06-01 13:28 ` Suzuki K Poulose
2023-06-02 8:29 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 09/11] coresight-tpdm: Add nodes for timestamp request Tao Zhang
2023-06-05 10:19 ` Suzuki K Poulose
2023-06-06 10:55 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 10/11] dt-bindings: arm: Add support for DSB MSR register Tao Zhang
2023-04-27 9:00 ` [PATCH v4 11/11] coresight-tpdm: Add nodes for dsb msr support Tao Zhang
2023-06-05 10:24 ` Suzuki K Poulose
2023-06-06 12:45 ` Tao Zhang
2023-04-27 16:53 ` [PATCH v4 00/11] Add support to configure TPDM DSB subunit Suzuki K Poulose
[not found] ` <725b6ccd-ff70-a3d2-fe44-797c0509e643@quicinc.com>
2023-06-01 8:17 ` Tao Zhang [this message]
2023-06-01 8:36 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13686cd8-c887-32ef-d314-0955be366373@quicinc.com \
--to=quic_taozha@quicinc.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).