From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Tao Zhang <quic_taozha@quicinc.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Konrad Dybcio <konradybcio@gmail.com>,
Mike Leach <mike.leach@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Jinlong Mao <quic_jinlmao@quicinc.com>,
Leo Yan <leo.yan@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Tingwei Zhang <quic_tingweiz@quicinc.com>,
Yuanfang Zhang <quic_yuanfang@quicinc.com>,
Trilok Soni <quic_tsoni@quicinc.com>,
Hao Zhang <quic_hazha@quicinc.com>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org
Subject: Re: [PATCH v4 08/11] coresight-tpdm: Add nodes to configure pattern match output
Date: Thu, 1 Jun 2023 14:28:24 +0100 [thread overview]
Message-ID: <6be47f1a-16ca-76ca-b133-ee453c261c21@arm.com> (raw)
In-Reply-To: <1682586037-25973-9-git-send-email-quic_taozha@quicinc.com>
On 27/04/2023 10:00, Tao Zhang wrote:
> Add nodes to configure trigger pattern and trigger pattern mask.
> Each DSB subunit TPDM has maximum of n(n<7) XPR registers to
> configure trigger pattern match output. Eight 32 bit registers
> providing DSB interface trigger output pattern match comparison.
> And each DSB subunit TPDM has maximum of m(m<7) XPMR registers to
> configure trigger pattern mask match output. Eight 32 bit
> registers providing DSB interface trigger output pattern match
> mask.
>
> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
> ---
> .../ABI/testing/sysfs-bus-coresight-devices-tpdm | 30 ++++++++
> drivers/hwtracing/coresight/coresight-tpdm.c | 85 ++++++++++++++++++++++
> drivers/hwtracing/coresight/coresight-tpdm.h | 8 ++
> 3 files changed, 123 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> index a57f000..c04c735 100644
> --- a/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-tpdm
> @@ -92,3 +92,33 @@ Description:
> <integer1> : Start EDCMR register number
> <integer2> : End EDCMR register number
> <integer3> : The value need to be written
> +
> +What: /sys/bus/coresight/devices/<tpdm-name>/dsb_trig_patt_val
> +Date: March 2023
> +KernelVersion 6.3
> +Contact: Jinlong Mao (QUIC) <quic_jinlmao@quicinc.com>, Tao Zhang (QUIC) <quic_taozha@quicinc.com>
> +Description:
> + (Write) Set the trigger pattern value of DSB tpdm.
> + Read the trigger pattern value of DSB tpdm.
> +
> + Expected format is the following:
> + <integer1> <integer2>
> +
> + Where:
> + <integer1> : Index number of XPR register, the range is 0 to 7
> + <integer2> : The value need to be written
I assume the values written to the registers are not special and doesn't
have meaning and thus need not be documented ?
> +
> +What: /sys/bus/coresight/devices/<tpdm-name>/dsb_trig_patt_mask
> +Date: March 2023
> +KernelVersion 6.3
Same as the previous one, 6.5 please
> +Contact: Jinlong Mao (QUIC) <quic_jinlmao@quicinc.com>, Tao Zhang (QUIC) <quic_taozha@quicinc.com>
> +Description:
> + (Write) Set the trigger pattern mask of DSB tpdm.
> + Read the trigger pattern mask of DSB tpdm.
> +
> + Expected format is the following:
> + <integer1> <integer2>
> +
> + Where:
> + <integer1> : Index number of XPMR register, the range is 0 to 7
> + <integer2> : The value need to be written
> diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c
> index a40e458..9387bdf 100644
> --- a/drivers/hwtracing/coresight/coresight-tpdm.c
> +++ b/drivers/hwtracing/coresight/coresight-tpdm.c
> @@ -89,6 +89,13 @@ static void tpdm_enable_dsb(struct tpdm_drvdata *drvdata)
> writel_relaxed(drvdata->dsb->edge_ctrl_mask[i],
> drvdata->base + TPDM_DSB_EDCMR(i));
>
> + for (i = 0; i < TPDM_DSB_MAX_PATT; i++) {
Same as the previous, can we safely assume that write to these
registers won't trigger an Error if not impelemented ?
> + writel_relaxed(drvdata->dsb->trig_patt_val[i],
> + drvdata->base + TPDM_DSB_XPR(i));
> + writel_relaxed(drvdata->dsb->trig_patt_mask[i],
> + drvdata->base + TPDM_DSB_XPMR(i));
> + }
> +
> val = readl_relaxed(drvdata->base + TPDM_DSB_TIER);
> /* Set trigger timestamp */
> if (drvdata->dsb->trig_ts)
> @@ -444,6 +451,82 @@ static ssize_t dsb_edge_ctrl_mask_store(struct device *dev,
> }
> static DEVICE_ATTR_RW(dsb_edge_ctrl_mask);
>
> +static ssize_t dsb_trig_patt_val_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> + ssize_t size = 0;
> + int i = 0;
> +
> + spin_lock(&drvdata->spinlock);
> + for (i = 0; i < TPDM_DSB_MAX_PATT; i++) {
> + size += sysfs_emit_at(buf, size,
> + "Index: 0x%x Value: 0x%x\n", i,
> + drvdata->dsb->trig_patt_val[i]);
Please detect the return of 0 and break. Same below.
> + }
> + spin_unlock(&drvdata->spinlock);
> + return size;
> +}
> +
> +static ssize_t dsb_trig_patt_val_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf,
> + size_t size)
> +{
> + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> + unsigned long index, val;
> +
> + if (sscanf(buf, "%lx %lx", &index, &val) != 2)
> + return -EINVAL;
> + if (index >= TPDM_DSB_MAX_PATT)
> + return -EPERM;
> +
> + spin_lock(&drvdata->spinlock);
> + drvdata->dsb->trig_patt_val[index] = val;
> + spin_unlock(&drvdata->spinlock);
> + return size;
> +}
> +static DEVICE_ATTR_RW(dsb_trig_patt_val);
> +
> +static ssize_t dsb_trig_patt_mask_show(struct device *dev,
> + struct device_attribute *attr,
> + char *buf)
> +{
> + struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
> + ssize_t size = 0;
> + int i = 0;
> +
> + spin_lock(&drvdata->spinlock);
> + for (i = 0; i < TPDM_DSB_MAX_PATT; i++) {
> + size += sysfs_emit_at(buf, size,
> + "Index: 0x%x Value: 0x%x\n", i,
> + drvdata->dsb->trig_patt_mask[i]);
> + }
> + spin_unlock(&drvdata->spinlock);
> + return size;
Suzuki
next prev parent reply other threads:[~2023-06-01 13:29 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 9:00 [PATCH v4 00/11] Add support to configure TPDM DSB subunit Tao Zhang
2023-04-27 9:00 ` [PATCH v4 01/11] dt-bindings: arm: Add support for DSB element size Tao Zhang
2023-04-27 12:59 ` Rob Herring
2023-04-27 9:00 ` [PATCH v4 02/11] coresight-tpda: Add DSB dataset support Tao Zhang
2023-05-23 10:07 ` Suzuki K Poulose
2023-05-23 14:48 ` Suzuki K Poulose
2023-05-25 7:20 ` Tao Zhang
2023-05-25 7:16 ` Tao Zhang
2023-05-25 9:08 ` Suzuki K Poulose
2023-05-26 3:22 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 03/11] coresight-tpdm: Initialize DSB subunit configuration Tao Zhang
2023-05-23 13:42 ` Suzuki K Poulose
2023-05-25 8:12 ` Tao Zhang
2023-05-25 9:09 ` Suzuki K Poulose
2023-05-26 3:46 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 04/11] coresight-tpdm: Add reset node to TPDM node Tao Zhang
2023-05-23 14:53 ` Suzuki K Poulose
2023-05-25 8:36 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 05/11] coresight-tpdm: Add nodes to set trigger timestamp and type Tao Zhang
2023-06-01 9:05 ` Suzuki K Poulose
2023-06-02 2:29 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 06/11] coresight-tpdm: Add node to set dsb programming mode Tao Zhang
2023-06-01 9:23 ` Suzuki K Poulose
2023-06-02 2:58 ` Tao Zhang
2023-06-02 8:25 ` Suzuki K Poulose
2023-06-02 8:31 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 07/11] coresight-tpdm: Add nodes for dsb edge control Tao Zhang
2023-06-01 12:14 ` Suzuki K Poulose
2023-06-02 8:21 ` Tao Zhang
2023-06-02 8:45 ` Suzuki K Poulose
2023-06-02 9:00 ` Suzuki K Poulose
2023-06-05 9:12 ` Tao Zhang
2023-06-02 14:38 ` Tao Zhang
2023-06-02 16:05 ` Suzuki K Poulose
2023-04-27 9:00 ` [PATCH v4 08/11] coresight-tpdm: Add nodes to configure pattern match output Tao Zhang
2023-06-01 13:28 ` Suzuki K Poulose [this message]
2023-06-02 8:29 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 09/11] coresight-tpdm: Add nodes for timestamp request Tao Zhang
2023-06-05 10:19 ` Suzuki K Poulose
2023-06-06 10:55 ` Tao Zhang
2023-04-27 9:00 ` [PATCH v4 10/11] dt-bindings: arm: Add support for DSB MSR register Tao Zhang
2023-04-27 9:00 ` [PATCH v4 11/11] coresight-tpdm: Add nodes for dsb msr support Tao Zhang
2023-06-05 10:24 ` Suzuki K Poulose
2023-06-06 12:45 ` Tao Zhang
2023-04-27 16:53 ` [PATCH v4 00/11] Add support to configure TPDM DSB subunit Suzuki K Poulose
[not found] ` <725b6ccd-ff70-a3d2-fe44-797c0509e643@quicinc.com>
2023-06-01 8:17 ` Tao Zhang
2023-06-01 8:36 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be47f1a-16ca-76ca-b133-ee453c261c21@arm.com \
--to=suzuki.poulose@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andersson@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konradybcio@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=quic_hazha@quicinc.com \
--cc=quic_jinlmao@quicinc.com \
--cc=quic_taozha@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=quic_yuanfang@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).