From: Stephen Boyd <sboyd@kernel.org>
To: evgreen@chromium.org, marc.zyngier@arm.com
Cc: linux-kernel@vger.kernel.org, rplsssn@codeaurora.org,
linux-arm-msm@vger.kernel.org, thierry.reding@gmail.com,
bjorn.andersson@linaro.org, Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH 3/7] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs
Date: Thu, 20 Dec 2018 12:19:39 -0800 [thread overview]
Message-ID: <154533717951.79149.1309452983166815703@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20181219221105.3004-4-ilina@codeaurora.org>
Quoting Lina Iyer (2018-12-19 14:11:01)
> diff --git a/drivers/irqchip/qcom-pdc-data.c b/drivers/irqchip/qcom-pdc-data.c
> new file mode 100644
> index 000000000000..99b4be0af5db
> --- /dev/null
> +++ b/drivers/irqchip/qcom-pdc-data.c
> @@ -0,0 +1,94 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + */
> +
> +#include "qcom-pdc.h"
> +
> +static const struct pdc_gpio_pin_map sdm845_gpio_pdc_map[] = {
> + { 1, 30 },
> + { 3, 31 },
> + { 5, 32 },
> + { 10, 33 },
> + { 11, 34 },
> + { 20, 35 },
> + { 22, 36 },
> + { 24, 37 },
> + { 26, 38 },
> + { 30, 39 },
> + { 31, 117 },
> + { 32, 41 },
> + { 34, 42 },
> + { 36, 43 },
> + { 37, 44 },
> + { 38, 45 },
> + { 39, 46 },
> + { 40, 47 },
> + { 41, 115 },
> + { 43, 49 },
> + { 44, 50 },
> + { 46, 51 },
> + { 48, 52 },
> + { 49, 118 },
> + { 52, 54 },
> + { 53, 55 },
> + { 54, 56 },
> + { 56, 57 },
> + { 57, 58 },
> + { 58, 59 },
> + { 59, 60 },
> + { 60, 61 },
> + { 61, 62 },
> + { 62, 63 },
> + { 63, 64 },
> + { 64, 65 },
> + { 66, 66 },
> + { 68, 67 },
> + { 71, 68 },
> + { 73, 69 },
> + { 77, 70 },
> + { 78, 71 },
> + { 79, 72 },
> + { 80, 73 },
> + { 84, 74 },
> + { 85, 75 },
> + { 86, 76 },
> + { 88, 77 },
> + { 89, 116 },
> + { 91, 79 },
> + { 92, 80 },
> + { 95, 81 },
> + { 96, 82 },
> + { 97, 83 },
> + { 101, 84 },
> + { 103, 85 },
> + { 104, 86 },
> + { 115, 90 },
> + { 116, 91 },
> + { 117, 92 },
> + { 118, 93 },
> + { 119, 94 },
> + { 120, 95 },
> + { 121, 96 },
> + { 122, 97 },
> + { 123, 98 },
> + { 124, 99 },
> + { 125, 100 },
> + { 127, 102 },
> + { 128, 103 },
> + { 129, 104 },
> + { 130, 105 },
> + { 132, 106 },
> + { 133, 107 },
> + { 145, 108 },
> +};
> +
> +static const struct pdc_gpio_pin_data sdm845_gpio_data = {
> + .size = ARRAY_SIZE(sdm845_gpio_pdc_map),
> + .map = sdm845_gpio_pdc_map,
> +};
> +
> +const struct of_device_id pdc_gpio_match_table[] = {
> + { .compatible = "qcom,845-pdc", .data = &sdm845_gpio_data },
Why not qcom,sdm845-pdc?
> + { },
> +};
I wonder why we wouldn't just put this all into the qcom-pdc.c file at
the bottom and then have that IRQCHIP_DECLARE() macros call small
functions that pass the pdc to gpio mapping table to qcom_pdc_init()
that takes a third argument?
I really hope that in the future all the gpios can be wakeup capable so
that we don't need to have the table at all!
next prev parent reply other threads:[~2018-12-20 20:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 22:10 [PATCH 0/7] qcom: support wakeup capable GPIOs Lina Iyer
2018-12-19 22:10 ` [PATCH 1/7] gpio: Add support for hierarchical IRQ domains Lina Iyer
2019-01-18 18:12 ` Doug Anderson
2018-12-19 22:11 ` [PATCH 2/7] irqdomain: add bus token DOMAIN_BUS_WAKEUP Lina Iyer
2018-12-19 22:11 ` [PATCH 3/7] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs Lina Iyer
2018-12-20 20:19 ` Stephen Boyd [this message]
2019-01-07 18:48 ` Lina Iyer
2019-01-11 22:55 ` Stephen Boyd
2019-01-11 23:34 ` Lina Iyer
2018-12-19 22:11 ` [PATCH 4/7] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO Lina Iyer
2018-12-29 0:07 ` Rob Herring
2019-01-07 18:51 ` Lina Iyer
2019-01-08 14:49 ` Rob Herring
2019-01-09 17:31 ` Lina Iyer
2019-01-09 19:36 ` Rob Herring
2019-01-11 23:20 ` Stephen Boyd
2019-01-23 20:52 ` Stephen Boyd
2019-01-31 21:53 ` Stephen Boyd
2019-02-01 7:09 ` Stephen Boyd
2019-02-06 17:07 ` Lina Iyer
2019-02-06 18:47 ` Stephen Boyd
2019-02-12 16:05 ` Lina Iyer
2018-12-19 22:11 ` [PATCH 5/7] drivers: pinctrl: msm: setup GPIO irqchip hierarchy Lina Iyer
2018-12-20 20:03 ` Stephen Boyd
2019-01-07 18:54 ` Lina Iyer
2019-01-16 23:13 ` Lina Iyer
2019-01-23 21:00 ` Stephen Boyd
2018-12-19 22:11 ` [PATCH 6/7] arm64: dts: msm: add PDC device bindings for sdm845 Lina Iyer
2018-12-20 18:14 ` Doug Anderson
2019-01-07 18:52 ` Lina Iyer
2019-01-17 23:36 ` Doug Anderson
2018-12-19 22:11 ` [PATCH 7/7] arm64: dts: msm: setup PDC as wakeup parent for GPIOs for SDM845 Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154533717951.79149.1309452983166815703@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rplsssn@codeaurora.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).