From: Doug Anderson <dianders@chromium.org>
To: Lina Iyer <ilina@codeaurora.org>
Cc: Stephen Boyd <sboyd@kernel.org>,
Evan Green <evgreen@chromium.org>,
Marc Zyngier <marc.zyngier@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Raju P L S S S N <rplsssn@codeaurora.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 6/7] arm64: dts: msm: add PDC device bindings for sdm845
Date: Thu, 17 Jan 2019 15:36:53 -0800 [thread overview]
Message-ID: <CAD=FV=V+yeN7hYnMN8-4B5GBH7d1eXun2zxJ7GhCGJOUPvkFLg@mail.gmail.com> (raw)
In-Reply-To: <20190107185218.GI14960@codeaurora.org>
Hi,
On Mon, Jan 7, 2019 at 10:52 AM Lina Iyer <ilina@codeaurora.org> wrote:
> >> + compatible = "qcom,sdm845-pdc";
> >> + reg = <0xb220000 0x30000>;
> >
> >nit: apparently common practice for Quaclomm dts is to pad the address
> >in the "reg" field to all 8 digits. So the above should be:
> >
> >reg = <0x0b220000 0x30000>;
> >
> >NOTE: it's important to _not_ pad the unit address in the node name
> >(so you got that right). Only update the "reg". For context:
> >
> Ok.
>
> Will take care of these in the next spin.
This will now need to be adjusted to:
reg = <0 0x0b220000 0 0x30000>;
This fixes things up to deal with the patch ("arm64: dts: qcom:
sdm845: Increase address and size cells for soc"), AKA:
- https://patchwork.kernel.org/patch/10767511/
- https://lkml.kernel.org/r/20190117042940.25487-2-bjorn.andersson@linaro.org
Thanks!
-Doug
next prev parent reply other threads:[~2019-01-17 23:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 22:10 [PATCH 0/7] qcom: support wakeup capable GPIOs Lina Iyer
2018-12-19 22:10 ` [PATCH 1/7] gpio: Add support for hierarchical IRQ domains Lina Iyer
2019-01-18 18:12 ` Doug Anderson
2018-12-19 22:11 ` [PATCH 2/7] irqdomain: add bus token DOMAIN_BUS_WAKEUP Lina Iyer
2018-12-19 22:11 ` [PATCH 3/7] drivers: irqchip: add PDC irqdomain for wakeup capable GPIOs Lina Iyer
2018-12-20 20:19 ` Stephen Boyd
2019-01-07 18:48 ` Lina Iyer
2019-01-11 22:55 ` Stephen Boyd
2019-01-11 23:34 ` Lina Iyer
2018-12-19 22:11 ` [PATCH 4/7] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO Lina Iyer
2018-12-29 0:07 ` Rob Herring
2019-01-07 18:51 ` Lina Iyer
2019-01-08 14:49 ` Rob Herring
2019-01-09 17:31 ` Lina Iyer
2019-01-09 19:36 ` Rob Herring
2019-01-11 23:20 ` Stephen Boyd
2019-01-23 20:52 ` Stephen Boyd
2019-01-31 21:53 ` Stephen Boyd
2019-02-01 7:09 ` Stephen Boyd
2019-02-06 17:07 ` Lina Iyer
2019-02-06 18:47 ` Stephen Boyd
2019-02-12 16:05 ` Lina Iyer
2018-12-19 22:11 ` [PATCH 5/7] drivers: pinctrl: msm: setup GPIO irqchip hierarchy Lina Iyer
2018-12-20 20:03 ` Stephen Boyd
2019-01-07 18:54 ` Lina Iyer
2019-01-16 23:13 ` Lina Iyer
2019-01-23 21:00 ` Stephen Boyd
2018-12-19 22:11 ` [PATCH 6/7] arm64: dts: msm: add PDC device bindings for sdm845 Lina Iyer
2018-12-20 18:14 ` Doug Anderson
2019-01-07 18:52 ` Lina Iyer
2019-01-17 23:36 ` Doug Anderson [this message]
2018-12-19 22:11 ` [PATCH 7/7] arm64: dts: msm: setup PDC as wakeup parent for GPIOs for SDM845 Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V+yeN7hYnMN8-4B5GBH7d1eXun2zxJ7GhCGJOUPvkFLg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=rplsssn@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).