From: Stephen Boyd <sboyd@kernel.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/7] dt-bindings: clock: combine qcom,sdm845-dispcc and qcom,sc7180-dispcc
Date: Tue, 22 Sep 2020 12:02:55 -0700 [thread overview]
Message-ID: <160080137590.310579.8319855170599098111@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20200911153412.21672-4-jonathan@marek.ca>
Quoting Jonathan Marek (2020-09-11 08:34:03)
> These two bindings are almost identical, so combine them into one. This
> will make it easier to add the sm8150 and sm8250 dispcc bindings.
Why not just add the sm8150 and sm8250 to the sc7180 binding?
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> ...om,sdm845-dispcc.yaml => qcom,dispcc.yaml} | 18 ++--
> .../bindings/clock/qcom,sc7180-dispcc.yaml | 86 -------------------
> 2 files changed, 12 insertions(+), 92 deletions(-)
> rename Documentation/devicetree/bindings/clock/{qcom,sdm845-dispcc.yaml => qcom,dispcc.yaml} (86%)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
> similarity index 86%
> rename from Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
> rename to Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
> index ead44705333b..7d5b25dfe0b1 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
> @@ -1,32 +1,37 @@
> # SPDX-License-Identifier: GPL-2.0-only
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/clock/qcom,sdm845-dispcc.yaml#
> +$id: http://devicetree.org/schemas/clock/qcom,dispcc.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Qualcomm Display Clock & Reset Controller Binding for SDM845
> +title: Qualcomm Display Clock & Reset Controller Binding
>
> maintainers:
> - Taniya Das <tdas@codeaurora.org>
>
> description: |
> Qualcomm display clock control module which supports the clocks, resets and
> - power domains on SDM845.
> + power domains on SDM845/SC7180.
>
> - See also dt-bindings/clock/qcom,dispcc-sdm845.h.
> + See also:
> + dt-bindings/clock/qcom,dispcc-sdm845.h
> + dt-bindings/clock/qcom,dispcc-sc7180.h
Sort please.
>
> properties:
> compatible:
> - const: qcom,sdm845-dispcc
> + enum:
> + - qcom,sdm845-dispcc
> + - qcom,sc7180-dispcc
Sort please.
>
> # NOTE: sdm845.dtsi existed for quite some time and specified no clocks.
> # The code had to use hardcoded mechanisms to find the input clocks.
> # New dts files should have these clocks.
> clocks:
> + minItems: 8
> items:
> - description: Board XO source
> - description: GPLL0 source from GCC
> - - description: GPLL0 div source from GCC
> + - description: GPLL0 div source from GCC (sdm845 only)
They're not the same. Why are we combining them?
> - description: Byte clock from DSI PHY0
> - description: Pixel clock from DSI PHY0
> - description: Byte clock from DSI PHY1
> @@ -35,6 +40,7 @@ properties:
> - description: VCO DIV clock from DP PHY
>
> clock-names:
> + minItems: 8
> items:
> - const: bi_tcxo
> - const: gcc_disp_gpll0_clk_src
next prev parent reply other threads:[~2020-09-22 19:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:34 [PATCH v3 0/7] SM8150 and SM8250 dispcc drivers Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 1/7] dt-bindings: clock: sdm845-dispcc: same name for dp_phy clocks as sc7180 Jonathan Marek
2020-09-22 22:57 ` Rob Herring
2020-09-11 15:34 ` [PATCH v3 2/7] arm64: dts: qcom: " Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 3/7] dt-bindings: clock: combine qcom,sdm845-dispcc and qcom,sc7180-dispcc Jonathan Marek
2020-09-22 19:02 ` Stephen Boyd [this message]
2020-09-11 15:34 ` [PATCH v3 4/7] dt-bindings: clock: Introduce QCOM SM8150 display clock bindings Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 5/7] dt-bindings: clock: Introduce QCOM SM8250 " Jonathan Marek
2020-09-22 19:04 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 6/7] clk: qcom: Add display clock controller driver for SM8150 Jonathan Marek
2020-09-22 19:04 ` Stephen Boyd
2020-09-23 16:24 ` Jonathan Marek
2020-09-24 6:15 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 7/7] clk: qcom: Add display clock controller driver for SM8250 Jonathan Marek
2020-09-22 19:00 ` Stephen Boyd
2020-09-23 16:10 ` Jonathan Marek
2020-09-24 6:16 ` Stephen Boyd
2020-09-27 19:11 ` Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160080137590.310579.8319855170599098111@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).