From: Stephen Boyd <sboyd@kernel.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 6/7] clk: qcom: Add display clock controller driver for SM8150
Date: Wed, 23 Sep 2020 23:15:55 -0700 [thread overview]
Message-ID: <160092815523.310579.15502532225598451868@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <3370cff3-9296-74fc-8e7d-ff93c3978351@marek.ca>
Quoting Jonathan Marek (2020-09-23 09:24:04)
> On 9/22/20 3:04 PM, Stephen Boyd wrote:
> > Quoting Jonathan Marek (2020-09-11 08:34:06)
> >> Add support for the display clock controller found on SM8150
> >> based devices. This would allow display drivers to probe and
> >> control their clocks.
> >>
> >> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> >> ---
> >> drivers/clk/qcom/Kconfig | 9 +
> >> drivers/clk/qcom/Makefile | 1 +
> >> drivers/clk/qcom/dispcc-sm8150.c | 1152 ++++++++++++++++++++++++++++++
> >> 3 files changed, 1162 insertions(+)
> >> create mode 100644 drivers/clk/qcom/dispcc-sm8150.c
> >
> > If the bindings are the same for these two drivers I wonder if there is
> > anything different between the two. Maybe the two drivers can be one
> > driver?
> >
>
> Possibly, the biggest difference seems to be the plls (trion vs lucid,
> different config), which could be resolved in the probe() function. If
> you think combining the drivers is the right thing to do then I can do that.
If that's the main difference then it sounds OK to merge the two.
next prev parent reply other threads:[~2020-09-24 6:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:34 [PATCH v3 0/7] SM8150 and SM8250 dispcc drivers Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 1/7] dt-bindings: clock: sdm845-dispcc: same name for dp_phy clocks as sc7180 Jonathan Marek
2020-09-22 22:57 ` Rob Herring
2020-09-11 15:34 ` [PATCH v3 2/7] arm64: dts: qcom: " Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 3/7] dt-bindings: clock: combine qcom,sdm845-dispcc and qcom,sc7180-dispcc Jonathan Marek
2020-09-22 19:02 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 4/7] dt-bindings: clock: Introduce QCOM SM8150 display clock bindings Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 5/7] dt-bindings: clock: Introduce QCOM SM8250 " Jonathan Marek
2020-09-22 19:04 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 6/7] clk: qcom: Add display clock controller driver for SM8150 Jonathan Marek
2020-09-22 19:04 ` Stephen Boyd
2020-09-23 16:24 ` Jonathan Marek
2020-09-24 6:15 ` Stephen Boyd [this message]
2020-09-11 15:34 ` [PATCH v3 7/7] clk: qcom: Add display clock controller driver for SM8250 Jonathan Marek
2020-09-22 19:00 ` Stephen Boyd
2020-09-23 16:10 ` Jonathan Marek
2020-09-24 6:16 ` Stephen Boyd
2020-09-27 19:11 ` Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160092815523.310579.15502532225598451868@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).