From: Stephen Boyd <sboyd@kernel.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 7/7] clk: qcom: Add display clock controller driver for SM8250
Date: Wed, 23 Sep 2020 23:16:45 -0700 [thread overview]
Message-ID: <160092820545.310579.6383587246524246608@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <2f429321-49c1-98b9-63e6-fd9c885af59c@marek.ca>
Quoting Jonathan Marek (2020-09-23 09:10:04)
> On 9/22/20 3:00 PM, Stephen Boyd wrote:
> > Quoting Jonathan Marek (2020-09-11 08:34:07)
> >> diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8250.c
> >> new file mode 100644
> >> index 000000000000..7c0f384a3a42
> >> --- /dev/null
> >> +++ b/drivers/clk/qcom/dispcc-sm8250.c
> >> @@ -0,0 +1,1100 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> +/*
> >> + * Copyright (c) 2018-2020, The Linux Foundation. All rights reserved.
> >> + */
> >> +
> > [...]
> >> +
> >> +static const struct clk_parent_data disp_cc_parent_data_6[] = {
> >> + { .fw_name = "bi_tcxo" },
> >> + { .fw_name = "dsi0_phy_pll_out_dsiclk" },
> >> + { .fw_name = "dsi1_phy_pll_out_dsiclk" },
> >
> > Can we remove clk postfix on these clk names?
> >
>
> This is consistent with the names used in both sdm845 and sc7180
> drivers. If this should change then those should be changed too?
If DT isn't using it already then it sounds OK to change the other
SoCs. Otherwise fix it just for this one.
next prev parent reply other threads:[~2020-09-24 6:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:34 [PATCH v3 0/7] SM8150 and SM8250 dispcc drivers Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 1/7] dt-bindings: clock: sdm845-dispcc: same name for dp_phy clocks as sc7180 Jonathan Marek
2020-09-22 22:57 ` Rob Herring
2020-09-11 15:34 ` [PATCH v3 2/7] arm64: dts: qcom: " Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 3/7] dt-bindings: clock: combine qcom,sdm845-dispcc and qcom,sc7180-dispcc Jonathan Marek
2020-09-22 19:02 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 4/7] dt-bindings: clock: Introduce QCOM SM8150 display clock bindings Jonathan Marek
2020-09-11 15:34 ` [PATCH v3 5/7] dt-bindings: clock: Introduce QCOM SM8250 " Jonathan Marek
2020-09-22 19:04 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 6/7] clk: qcom: Add display clock controller driver for SM8150 Jonathan Marek
2020-09-22 19:04 ` Stephen Boyd
2020-09-23 16:24 ` Jonathan Marek
2020-09-24 6:15 ` Stephen Boyd
2020-09-11 15:34 ` [PATCH v3 7/7] clk: qcom: Add display clock controller driver for SM8250 Jonathan Marek
2020-09-22 19:00 ` Stephen Boyd
2020-09-23 16:10 ` Jonathan Marek
2020-09-24 6:16 ` Stephen Boyd [this message]
2020-09-27 19:11 ` Jonathan Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160092820545.310579.6383587246524246608@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).