* [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions
@ 2020-10-22 13:26 Srinivasa Rao Mandadapu
2020-10-26 15:01 ` Srinivas Kandagatla
0 siblings, 1 reply; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2020-10-22 13:26 UTC (permalink / raw)
To: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, plai,
bgoswami, perex, tiwai, srinivas.kandagatla, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel
Cc: V Sujith Kumar Reddy, Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Update SC7180 lpass_variant structure with proper I2S bitwidth
field bit positions, as bitwidth denotes 0 to 1 bits,
but previously used only 0 bit.
Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support for SC7180 lpass variant" from Rohit kumar <rohitkr@codeaurora.org>:")
Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
---
sound/soc/qcom/lpass-sc7180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
index c6292f9e..bc998d5 100644
--- a/sound/soc/qcom/lpass-sc7180.c
+++ b/sound/soc/qcom/lpass-sc7180.c
@@ -188,7 +188,7 @@ static struct lpass_variant sc7180_data = {
.micmode = REG_FIELD_ID(0x1000, 4, 8, 3, 0x1000),
.micmono = REG_FIELD_ID(0x1000, 3, 3, 3, 0x1000),
.wssrc = REG_FIELD_ID(0x1000, 2, 2, 3, 0x1000),
- .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 3, 0x1000),
+ .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 3, 0x1000),
.rdma_dyncclk = REG_FIELD_ID(0xC000, 21, 21, 5, 0x1000),
.rdma_bursten = REG_FIELD_ID(0xC000, 20, 20, 5, 0x1000),
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions
2020-10-22 13:26 [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions Srinivasa Rao Mandadapu
@ 2020-10-26 15:01 ` Srinivas Kandagatla
2020-10-26 16:04 ` Srinivasa Rao Mandadapu
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Kandagatla @ 2020-10-26 15:01 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu, agross, bjorn.andersson, lgirdwood,
broonie, robh+dt, plai, bgoswami, perex, tiwai, rohitkr,
linux-arm-msm, alsa-devel, devicetree, linux-kernel
Cc: V Sujith Kumar Reddy
On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote:
> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>
> Update SC7180 lpass_variant structure with proper I2S bitwidth
> field bit positions, as bitwidth denotes 0 to 1 bits,
> but previously used only 0 bit.
>
> Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support for SC7180 lpass variant" from Rohit kumar <rohitkr@codeaurora.org>:")
this should be 12 chars long, for this particular fix it should be!
Fixes: 24caf8d9eb108 ("ASoC: qcom: lpass-sc7180: Add platform driver for
lpass audio")
>
No empty line after Fixes tag!
> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
> ---
> sound/soc/qcom/lpass-sc7180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> index c6292f9e..bc998d5 100644
> --- a/sound/soc/qcom/lpass-sc7180.c
> +++ b/sound/soc/qcom/lpass-sc7180.c
> @@ -188,7 +188,7 @@ static struct lpass_variant sc7180_data = {
> .micmode = REG_FIELD_ID(0x1000, 4, 8, 3, 0x1000),
> .micmono = REG_FIELD_ID(0x1000, 3, 3, 3, 0x1000),
> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 3, 0x1000),
> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 3, 0x1000),
> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 3, 0x1000),
>
> .rdma_dyncclk = REG_FIELD_ID(0xC000, 21, 21, 5, 0x1000),
> .rdma_bursten = REG_FIELD_ID(0xC000, 20, 20, 5, 0x1000),
>
--srini
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions
2020-10-26 15:01 ` Srinivas Kandagatla
@ 2020-10-26 16:04 ` Srinivasa Rao Mandadapu
0 siblings, 0 replies; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2020-10-26 16:04 UTC (permalink / raw)
To: Srinivas Kandagatla, agross, bjorn.andersson, lgirdwood, broonie,
robh+dt, plai, bgoswami, perex, tiwai, rohitkr, linux-arm-msm,
alsa-devel, devicetree, linux-kernel
Cc: V Sujith Kumar Reddy
Thanks for your time srinivas!!!
On 10/26/2020 8:31 PM, Srinivas Kandagatla wrote:
>
>
> On 22/10/2020 14:26, Srinivasa Rao Mandadapu wrote:
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Update SC7180 lpass_variant structure with proper I2S bitwidth
>> field bit positions, as bitwidth denotes 0 to 1 bits,
>> but previously used only 0 bit.
>>
>> Fixes: commit cba62c8b49bead ("Merge series "ASoC: qcom: Add support
>> for SC7180 lpass variant" from Rohit kumar <rohitkr@codeaurora.org>:")
> this should be 12 chars long, for this particular fix it should be!
>
> Fixes: 24caf8d9eb108 ("ASoC: qcom: lpass-sc7180: Add platform driver
> for lpass audio")
>>
>
> No empty line after Fixes tag!
>
> Will coorect it in next patch.
>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>> sound/soc/qcom/lpass-sc7180.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/qcom/lpass-sc7180.c
>> b/sound/soc/qcom/lpass-sc7180.c
>> index c6292f9e..bc998d5 100644
>> --- a/sound/soc/qcom/lpass-sc7180.c
>> +++ b/sound/soc/qcom/lpass-sc7180.c
>> @@ -188,7 +188,7 @@ static struct lpass_variant sc7180_data = {
>> .micmode = REG_FIELD_ID(0x1000, 4, 8, 3, 0x1000),
>> .micmono = REG_FIELD_ID(0x1000, 3, 3, 3, 0x1000),
>> .wssrc = REG_FIELD_ID(0x1000, 2, 2, 3, 0x1000),
>> - .bitwidth = REG_FIELD_ID(0x1000, 0, 0, 3, 0x1000),
>> + .bitwidth = REG_FIELD_ID(0x1000, 0, 1, 3, 0x1000),
>> .rdma_dyncclk = REG_FIELD_ID(0xC000, 21, 21, 5, 0x1000),
>> .rdma_bursten = REG_FIELD_ID(0xC000, 20, 20, 5, 0x1000),
>>
> --srini
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-26 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-22 13:26 [PATCH] Asoc: qcom: lpass-sc7180: Fix MI2S bitwidth field bit positions Srinivasa Rao Mandadapu
2020-10-26 15:01 ` Srinivas Kandagatla
2020-10-26 16:04 ` Srinivasa Rao Mandadapu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).