[PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()

[PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()

[Ye Bin]

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 drivers/scsi/ufs/ufs-qcom.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index 9b711d6aac54..2a3dd21da6a6 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -1071,13 +1071,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)
 		if (res) {
 			host->dev_ref_clk_ctrl_mmio =
 					devm_ioremap_resource(dev, res);
-			if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
-				dev_warn(dev,
-					"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
-					__func__,
-					PTR_ERR(host->dev_ref_clk_ctrl_mmio));
+			if (IS_ERR(host->dev_ref_clk_ctrl_mmio))
 				host->dev_ref_clk_ctrl_mmio = NULL;
-			}
 			host->dev_ref_clk_en_mask = BIT(5);
 		}
 	}

Re: [PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()

[Manivannan Sadhasivam]

On Fri, Apr 09, 2021 at 03:55:22PM +0800, Ye Bin wrote:
> There is a error message within devm_ioremap_resource
> 
> already, so remove the dev_err call to avoid redundant
> 
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Thanks,
Mani

> ---
>  drivers/scsi/ufs/ufs-qcom.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 9b711d6aac54..2a3dd21da6a6 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1071,13 +1071,8 @@ static int ufs_qcom_init(struct ufs_hba *hba)
>  		if (res) {
>  			host->dev_ref_clk_ctrl_mmio =
>  					devm_ioremap_resource(dev, res);
> -			if (IS_ERR(host->dev_ref_clk_ctrl_mmio)) {
> -				dev_warn(dev,
> -					"%s: could not map dev_ref_clk_ctrl_mmio, err %ld\n",
> -					__func__,
> -					PTR_ERR(host->dev_ref_clk_ctrl_mmio));
> +			if (IS_ERR(host->dev_ref_clk_ctrl_mmio))
>  				host->dev_ref_clk_ctrl_mmio = NULL;
> -			}
>  			host->dev_ref_clk_en_mask = BIT(5);
>  		}
>  	}
> 

Re: [PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()

[Martin K. Petersen]

On Fri, 9 Apr 2021 15:55:22 +0800, Ye Bin wrote:

> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
      https://git.kernel.org/mkp/scsi/c/790f9a48abd0

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH -next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()

[patchwork-bot+linux-arm-msm]

Hello:

This patch was applied to qcom/linux.git (refs/heads/for-next):

On Fri, 9 Apr 2021 15:55:22 +0800 you wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
> 
> [...]

Here is the summary with links:
  - [-next] scsi: ufs-qcom: Remove redundant dev_err call in ufs_qcom_init()
    https://git.kernel.org/qcom/c/790f9a48abd0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html