From: Veerabhadrarao Badiganti <firstname.lastname@example.org> To: Doug Anderson <email@example.com> Cc: Ulf Hansson <firstname.lastname@example.org>, Adrian Hunter <email@example.com>, Asutosh Das <firstname.lastname@example.org>, Sahitya Tummala <email@example.com>, Sayali Lokhande <firstname.lastname@example.org>, email@example.com, Ram Prakash Gupta <firstname.lastname@example.org>, Linux MMC List <email@example.com>, LKML <firstname.lastname@example.org>, linux-arm-msm <email@example.com>, Rob Herring <firstname.lastname@example.org>, Mark Rutland <email@example.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <firstname.lastname@example.org> Subject: Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Add CQE reg map Date: Wed, 12 Feb 2020 17:30:00 +0530 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAD=FV=X6-aWM_fSfLE0ySuM04FvQCTKpM-A87k3xMXBMRzNXFQ@mail.gmail.com> On 2/11/2020 10:12 PM, Doug Anderson wrote: > Hi, > > On Tue, Feb 11, 2020 at 7:29 AM Veerabhadrarao Badiganti > <firstname.lastname@example.org> wrote: >> CQE feature has been enabled on sdhci-msm. Add CQE reg map >> that needs to be supplied for supporting CQE feature. >> >> Change-Id: I788c4bd5b7cbca16bc1030a410cc5550ed7204e1 >> Signed-off-by: Veerabhadrarao Badiganti <email@example.com> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> index 7ee639b..eaa0998 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> @@ -27,6 +27,11 @@ Required properties: >> - reg: Base address and length of the register in the following order: >> - Host controller register map (required) >> - SD Core register map (required for msm-v4 and below) >> + - CQE register map (Optional, needed only for eMMC and msm-v4.2 above) > I did a quick search and it appears that SD cards implementing 6.0 of > the spec can also use CQE. Is that correct? If so, maybe remove the > part about "eMMC"? On qcom platforms, only SDHC instance meant for eMMC has the CQE support. So mentioned that its needed only for eMMC. > > Maybe also change "needed" to "useful" to make it clear that this > entry isn't actually required for all msm-v4.2 controllers? sure. > >> +- reg-names: When CQE register map is supplied, below reg-names are required >> + - "hc_mem" for Host controller register map >> + - "core_mem" for SD cpre regoster map > s/regoster/register > > >> + - "cqhci_mem" for CQE register map > I'm at least slightly confused. You say that reg-names are there only > if CQE register map is supplied. ...and that requires 4.2 and above. > ...but "core_mem" is only there on 4.0 and below. So there should > never be a "core_mem" entry? core_mem is present till <v5.0 cqhci_mem is present on >=v4.2 Say, for version v4.2 both are present; .... and for v5.0 only cqhci_mem is present. Both hc reg-map and core reg-map are being accessed through index. So no need to list the reg names 'hc_mem' & 'core_mem' in general. But coming to cqhci reg-map we can't access it with fixed index, since its index varies between 1/2 based on controller version. So we are accessing it through reg-names. Since reg-names has to be associated with corresponding reg maps, other two reg-names (hc_mem & core_mem) also need to br listed when cqhci_mem is listed. That is the reason, I mentioned it like these are needed only cqe reg map is supplied. If it is creating confusion, i will remove that statement. > Trying to specify that sanely in free-form text seems like it's gonna > be hard and not worth it. You should probably transition to yaml > first? > > > I will also note that Rob isn't a huge fan of "reg-names". In a > different conversation I think you mentioned you had a reason for > having it. I guess just be prepared to defend yourself against Rob if > you feel strongly about keeping reg-names. Sure. Its the same reason mentioned in above comment. > > -Doug
next prev parent reply other threads:[~2020-02-12 12:00 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-11 15:29 Veerabhadrarao Badiganti 2020-02-11 16:42 ` Doug Anderson 2020-02-12 12:00 ` Veerabhadrarao Badiganti [this message] 2020-02-12 23:21 ` Doug Anderson 2020-02-14 11:45 ` [PATCH V2] " Veerabhadrarao Badiganti 2020-02-19 20:08 ` Rob Herring 2020-02-24 11:44 ` Veerabhadrarao Badiganti 2020-02-24 11:57 ` [PATCH V3] " Veerabhadrarao Badiganti 2020-02-27 20:54 ` Doug Anderson 2020-02-28 15:10 ` Rob Herring 2020-03-04 15:34 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH V1] dt-bindings: mmc: sdhci-msm: Add CQE reg map' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).