From: Doug Anderson <dianders@google.com>
To: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Asutosh Das <asutoshd@codeaurora.org>,
Sahitya Tummala <stummala@codeaurora.org>,
Sayali Lokhande <sayalil@codeaurora.org>,
cang@codeaurora.org, Ram Prakash Gupta <rampraka@codeaurora.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH V3] dt-bindings: mmc: sdhci-msm: Add CQE reg map
Date: Thu, 27 Feb 2020 12:54:41 -0800 [thread overview]
Message-ID: <CAD=FV=WjSC7h0Q1aQpF74KDpgjOPSKrUR5gBo1ZsFn_o4m5TyQ@mail.gmail.com> (raw)
In-Reply-To: <1582545470-11530-1-git-send-email-vbadigan@codeaurora.org>
Hi,
On Mon, Feb 24, 2020 at 3:58 AM Veerabhadrarao Badiganti
<vbadigan@codeaurora.org> wrote:
>
> CQE feature has been enabled on sdhci-msm. Add CQE reg map
> and reg names that need to be supplied for supporting CQE feature.
>
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
> ---
> Changes since V2:
> - Dropped _mem suffix to reg names.
>
> Changes since V1:
> - Updated description for more clarity & Fixed typos.
> ---
> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I assume you'll have a follow-up fixing the driver since commit
a4080225f51d ("mmc: cqhci: support for command queue enabled host")
refers to "cqhci_mem".
Also something to keep in mind for future patches (no action needed
for this patch): most maintainers frown on making v2 of a patch
"In-Reply-To" v1 of a patch. I notice that your v3 was in-reply-to v2
and v2 was in-reply-to v1. You probably don't want to do this. One
such reference to people not liking it [1] specifically said "they
should not be replies to old versions of that patch; otherwise the
threading looks really weird and confusing."
[1] https://lore.kernel.org/r/CAJWu+oocs3T8orMNt6AmdVgWONzZg0vD=E8EdvzE9rOi_XatUw@mail.gmail.com
-Doug
next prev parent reply other threads:[~2020-02-27 20:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 15:29 [PATCH V1] dt-bindings: mmc: sdhci-msm: Add CQE reg map Veerabhadrarao Badiganti
2020-02-11 16:42 ` Doug Anderson
2020-02-12 12:00 ` Veerabhadrarao Badiganti
2020-02-12 23:21 ` Doug Anderson
2020-02-14 11:45 ` [PATCH V2] " Veerabhadrarao Badiganti
2020-02-19 20:08 ` Rob Herring
2020-02-24 11:44 ` Veerabhadrarao Badiganti
2020-02-24 11:57 ` [PATCH V3] " Veerabhadrarao Badiganti
2020-02-27 20:54 ` Doug Anderson [this message]
2020-02-28 15:10 ` Rob Herring
2020-03-04 15:34 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WjSC7h0Q1aQpF74KDpgjOPSKrUR5gBo1ZsFn_o4m5TyQ@mail.gmail.com' \
--to=dianders@google.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rampraka@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sayalil@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).