From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <abhinavk@codeaurora.org>
Cc: Stephen Boyd <sboyd@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
<freedreno@lists.freedesktop.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2 2/4] drm/msm/dpu: drop pe argument from _dpu_hw_sspp_setup_scaler3
Date: Tue, 7 Dec 2021 11:43:52 -0800 [thread overview]
Message-ID: <1f7b374f-6231-ddde-0518-9f43e12d580f@quicinc.com> (raw)
In-Reply-To: <20211201225140.2481577-3-dmitry.baryshkov@linaro.org>
+ Dan C for awareness as this is a follow up of our discussion on
https://lore.kernel.org/linux-arm-msm/c1537b326b654f05be247ca61d21e9f0@codeaurora.org/T/
On 12/1/2021 2:51 PM, Dmitry Baryshkov wrote:
> The _dpu_hw_sspp_setup_scaler3 (hw_sspp->setup_scaler) does not use pe
> argument. Let's remove it while we are cleaning scaled configuration.
>
Thanks for pushing this.
This was originally reported by Dan Carpenter.
Hence, please add the Reported-by tag for Dan on this (Dan Carpenter
<dan.carpenter@oracle.com> )
Apart from that,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 2 --
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 --
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 +-
> 3 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> index d77eb7da5daf..7235605bfc9e 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c
> @@ -413,13 +413,11 @@ static void dpu_hw_sspp_setup_pe_config(struct dpu_hw_pipe *ctx,
>
> static void _dpu_hw_sspp_setup_scaler3(struct dpu_hw_pipe *ctx,
> struct dpu_hw_pipe_cfg *sspp,
> - struct dpu_hw_pixel_ext *pe,
> void *scaler_cfg)
> {
> u32 idx;
> struct dpu_hw_scaler3_cfg *scaler3_cfg = scaler_cfg;
>
> - (void)pe;
> if (_sspp_subblk_offset(ctx, DPU_SSPP_SCALER_QSEED3, &idx) || !sspp
> || !scaler3_cfg)
> return;
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
> index e8939d7387cb..ad2002d75739 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
> @@ -334,12 +334,10 @@ struct dpu_hw_sspp_ops {
> * setup_scaler - setup scaler
> * @ctx: Pointer to pipe context
> * @pipe_cfg: Pointer to pipe configuration
> - * @pe_cfg: Pointer to pixel extension configuration
> * @scaler_cfg: Pointer to scaler configuration
> */
> void (*setup_scaler)(struct dpu_hw_pipe *ctx,
> struct dpu_hw_pipe_cfg *pipe_cfg,
> - struct dpu_hw_pixel_ext *pe_cfg,
> void *scaler_cfg);
>
> /**
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index 4c373abbe89c..c7b065b14c5c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -688,7 +688,7 @@ static void _dpu_plane_setup_scaler(struct dpu_plane *pdpu,
> if (pdpu->pipe_hw->ops.setup_scaler &&
> pstate->multirect_index != DPU_SSPP_RECT_1)
> pdpu->pipe_hw->ops.setup_scaler(pdpu->pipe_hw,
> - pipe_cfg, &pixel_ext,
> + pipe_cfg,
> &scaler3_cfg);
> }
>
>
next prev parent reply other threads:[~2021-12-07 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 22:51 [PATCH v2 0/4] drm/msm/dpu: cleanup plane state Dmitry Baryshkov
2021-12-01 22:51 ` [PATCH v2 1/4] drm/msm/dpu: drop scaler config from " Dmitry Baryshkov
2021-12-07 19:30 ` Abhinav Kumar
2021-12-01 22:51 ` [PATCH v2 2/4] drm/msm/dpu: drop pe argument from _dpu_hw_sspp_setup_scaler3 Dmitry Baryshkov
2021-12-07 19:43 ` Abhinav Kumar [this message]
2021-12-01 22:51 ` [PATCH v2 3/4] drm/msm/dpu: simplify DPU_SSPP features checks Dmitry Baryshkov
2021-12-07 19:45 ` [Freedreno] " Abhinav Kumar
2021-12-01 22:51 ` [PATCH v2 4/4] drm/msm/dpu: fix CDP setup to account for multirect index Dmitry Baryshkov
2021-12-07 20:06 ` Abhinav Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f7b374f-6231-ddde-0518-9f43e12d580f@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).