From: Marc Gonzalez <marc.w.gonzalez@free.fr>
To: Sibi Sankar <sibis@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: MSM <linux-arm-msm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state
Date: Fri, 5 Apr 2019 16:59:10 +0200 [thread overview]
Message-ID: <ac4c39f0-3ab2-7930-7d37-c132e5a7a764@free.fr> (raw)
Message-ID: <20190405145910.WBz-ozecV8hOpr5Y6CdX2S1Ph33isL_Tr1Z4dduP-R0@z> (raw)
In-Reply-To: <20190327123832.11566-2-sibis@codeaurora.org>
On 27/03/2019 13:38, Sibi Sankar wrote:
> Remoteproc q6v5-mss does set_performace_state with INT_MAX on
Remoteproc q6v5-mss calls set_performance_state()
> rpmpd. This is currently ignored since it is greater than the
> max supported state. Fixup rpmpd state to max if the required
> state is greater than all the supported states.
>
> Fixes: 075d3db8d10d ("Add support for the .set_performace_state() and
> .opp_to_performance_state()")
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
AFAIU, the Fixes tag should be on a single line, and quote the commit subject.
(And no blank line between Fixes and Signed-off-by tags.)
Fixes: 075d3db8d10d ("soc: qcom: rpmpd: Add support for get/set performance state")
> ---
> drivers/soc/qcom/rpmpd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> index 005326050c23..235d01870dd8 100644
> --- a/drivers/soc/qcom/rpmpd.c
> +++ b/drivers/soc/qcom/rpmpd.c
> @@ -226,7 +226,7 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
> struct rpmpd *pd = domain_to_rpmpd(domain);
>
> if (state > MAX_RPMPD_STATE)
> - goto out;
> + state = MAX_RPMPD_STATE;
>
> mutex_lock(&rpmpd_lock);
>
With these two nits taken care of:
Reviewed-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Regards.
next prev parent reply other threads:[~2019-04-05 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190327123832.11566-1-sibis@codeaurora.org>
2019-04-05 14:49 ` [PATCH v3 0/9] RPMPD for QCS404 and MSM8998 Marc Gonzalez
2019-04-05 14:49 ` Marc Gonzalez
[not found] ` <20190327123832.11566-2-sibis@codeaurora.org>
2019-04-05 14:59 ` Marc Gonzalez [this message]
2019-04-05 14:59 ` [PATCH v3 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state Marc Gonzalez
[not found] ` <20190327123832.11566-9-sibis@codeaurora.org>
2019-04-05 15:08 ` [PATCH v3 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains Marc Gonzalez
2019-04-05 15:08 ` Marc Gonzalez
2019-04-08 8:30 ` Sibi Sankar
2019-04-08 8:30 ` Sibi Sankar
2019-04-08 8:54 ` Marc Gonzalez
2019-04-08 8:54 ` Marc Gonzalez
2019-04-08 9:02 ` Sibi Sankar
2019-04-08 9:02 ` Sibi Sankar
[not found] ` <20190327123832.11566-7-sibis@codeaurora.org>
2019-04-08 8:10 ` [PATCH v3 6/9] arm64: dts: qcom: qcs404: Add rpmpd node Sibi Sankar
2019-04-08 8:10 ` Sibi Sankar
[not found] ` <20190327123832.11566-10-sibis@codeaurora.org>
2019-04-08 8:12 ` [PATCH v3 9/9] arm64: dts: qcom: msm8998: " Sibi Sankar
2019-04-08 8:12 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4c39f0-3ab2-7930-7d37-c132e5a7a764@free.fr \
--to=marc.w.gonzalez@free.fr \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).