From: Sibi Sankar <sibis@codeaurora.org>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: MSM <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH v3 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains
Date: Mon, 08 Apr 2019 14:00:05 +0530 [thread overview]
Message-ID: <a5e9aef9c8d972424f14d5af96a9af58@codeaurora.org> (raw)
Message-ID: <20190408083005.QJZV0Tz6EHOuuLEc7QLCMdTysBTawn6h1mYHsvDtAaw@z> (raw)
In-Reply-To: <3b3bd18b-4491-c290-a421-7be8df371925@free.fr>
On 2019-04-05 20:38, Marc Gonzalez wrote:
> On 27/03/2019 13:38, Sibi Sankar wrote:
>
>> Add the shared cx/mx and sensor sub-system's cx and mx
>> power-domains found on MSM8998.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> drivers/soc/qcom/rpmpd.c | 36 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>>
>> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
>> index 238a9e02e890..706a3f63038e 100644
>> --- a/drivers/soc/qcom/rpmpd.c
>> +++ b/drivers/soc/qcom/rpmpd.c
>> @@ -19,9 +19,12 @@
>> /* Resource types */
>> #define RPMPD_SMPA 0x61706d73 /* smpa */
>> #define RPMPD_LDOA 0x616f646c /* ldoa */
>> +#define RPMPD_RWCX 0x78637772 /* rwcx */
>> #define RPMPD_RWMX 0x786d7772 /* rwmx */
>> #define RPMPD_RWLC 0x636c7772 /* rwlc */
>> #define RPMPD_RWLM 0x6d6c7772 /* rwlm */
>> +#define RPMPD_RWSC 0x63737772 /* rwsc */
>> +#define RPMPD_RWSM 0x6d737772 /* rwsm */
>
> I do not see any value in the comments. Maybe remove them?
comments were included to add value
though, however I guess the comments
were definitely not clear enough.
The magic values for the resources
are calculated as follows:
ascii to hex in reverse order
eg: smpa -> 0x61706d73
0x61 0x70 0x6d 0x73
a p m s
>
> I will take a closer look at patches 7-9 on Monday.
Thanks for taking time to review
this series.
>
> Regards.
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-04-08 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190327123832.11566-1-sibis@codeaurora.org>
2019-04-05 14:49 ` [PATCH v3 0/9] RPMPD for QCS404 and MSM8998 Marc Gonzalez
2019-04-05 14:49 ` Marc Gonzalez
[not found] ` <20190327123832.11566-2-sibis@codeaurora.org>
2019-04-05 14:59 ` [PATCH v3 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state Marc Gonzalez
2019-04-05 14:59 ` Marc Gonzalez
[not found] ` <20190327123832.11566-9-sibis@codeaurora.org>
2019-04-05 15:08 ` [PATCH v3 8/9] soc: qcom: rpmpd: Add MSM8998 power-domains Marc Gonzalez
2019-04-05 15:08 ` Marc Gonzalez
2019-04-08 8:30 ` Sibi Sankar [this message]
2019-04-08 8:30 ` Sibi Sankar
2019-04-08 8:54 ` Marc Gonzalez
2019-04-08 8:54 ` Marc Gonzalez
2019-04-08 9:02 ` Sibi Sankar
2019-04-08 9:02 ` Sibi Sankar
[not found] ` <20190327123832.11566-7-sibis@codeaurora.org>
2019-04-08 8:10 ` [PATCH v3 6/9] arm64: dts: qcom: qcs404: Add rpmpd node Sibi Sankar
2019-04-08 8:10 ` Sibi Sankar
[not found] ` <20190327123832.11566-10-sibis@codeaurora.org>
2019-04-08 8:12 ` [PATCH v3 9/9] arm64: dts: qcom: msm8998: " Sibi Sankar
2019-04-08 8:12 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5e9aef9c8d972424f14d5af96a9af58@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).