Linux-ARM-MSM Archive on lore.kernel.org
 help / color / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Taniya Das <tdas@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG
Date: Tue, 30 Jul 2019 08:40:37 -0700
Message-ID: <20190730154038.8BF53206B8@mail.kernel.org> (raw)
In-Reply-To: <63d15392-f296-cd13-7821-61d59d568347@codeaurora.org>

Quoting Taniya Das (2019-07-30 03:51:07)
> 
> 
> On 7/17/2019 4:52 AM, Stephen Boyd wrote:
> > Quoting Taniya Das (2019-07-15 21:22:02)
> >> Hello Stephen,
> >>
> >> Thanks for the review.
> >>
> >> On 7/16/2019 4:14 AM, Stephen Boyd wrote:
> >>> Quoting Taniya Das (2019-05-12 20:44:46)
> >>>> On 5/10/2019 11:24 PM, Stephen Boyd wrote:
> >>>>> Why is the clk name changing to not have a _src after the "root" of the
> >>>>> clk name? As long as I can remember, RCGs have a "_src" postfix.
> >>>>>
> >>>>
> >>>> Yes, the RCGs would have _src, so we do want the init data also to be
> >>>> generated with _src postfix. So that we do not have to manually clean up
> >>>> the generated code.
> >>>>
> >>>
> >>> Please manually cleanup the generated code, or fix the code
> >>> generator to do what you want.
> >>>
> >>
> >> Fixing the code manually is not what we intend to do and it is time
> >> consuming with too many DFS controlled clocks. This really helps us
> >> align to internal code.
> >>
> > 
> > And you can't fix the code generator to drop the _src part of whatever
> > is spit out for the DFS lines?
> > 
> 
> Sure, will drop this.
> 

Actually, I'm OK with this patch, but I'd like to see it in a larger
series that introduces another clk driver using this macro. The reason I
like it is that I can search for the same string name and find the clk
that has DFS enabled on it, instead of finding the branch which doesn't
have DFS. Sorry for the back and forth, I got confused about what was
going on.


      reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 18:24 [PATCH v1 0/3] clk: qcom: Misc updates for Root Clock Generators Taniya Das
2019-05-08 18:24 ` [PATCH v1 1/3] clk: qcom: rcg: Return failure for RCG update Taniya Das
2019-07-15 22:52   ` Stephen Boyd
2019-05-08 18:24 ` [PATCH v1 2/3] clk: qcom: rcg2: Add support for hardware control mode Taniya Das
2019-07-15 22:52   ` Stephen Boyd
2019-07-16  4:19     ` Taniya Das
2019-07-16 23:18       ` Stephen Boyd
2019-07-30 10:50         ` Taniya Das
2019-07-30 15:38           ` Stephen Boyd
2019-05-08 18:24 ` [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG Taniya Das
2019-05-09 17:27   ` Stephen Boyd
2019-05-10  2:58     ` Taniya Das
2019-05-10 17:54       ` Stephen Boyd
2019-05-13  3:44         ` Taniya Das
2019-07-15 22:44           ` Stephen Boyd
2019-07-16  4:22             ` Taniya Das
2019-07-16 23:22               ` Stephen Boyd
2019-07-30 10:51                 ` Taniya Das
2019-07-30 15:40                   ` Stephen Boyd [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190730154038.8BF53206B8@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=rnayak@codeaurora.org \
    --cc=tdas@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-MSM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-msm/0 linux-arm-msm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-msm linux-arm-msm/ https://lore.kernel.org/linux-arm-msm \
		linux-arm-msm@vger.kernel.org
	public-inbox-index linux-arm-msm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-arm-msm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git