* [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg
@ 2020-04-15 5:47 Bjorn Andersson
2020-04-21 7:02 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2020-04-15 5:47 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Venkata Narendra Kumar Gutta, Vinod Koul
Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel
The pdc node suffers from both too narrow compatible and insufficient
cells in the reg, fix these.
Fixes: 60378f1a171e ("arm64: dts: qcom: sm8250: Add sm8250 dts file")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 891d83b2afea..2a7eaefd221d 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -314,8 +314,8 @@ intc: interrupt-controller@17a00000 {
};
pdc: interrupt-controller@b220000 {
- compatible = "qcom,sm8250-pdc";
- reg = <0x0b220000 0x30000>, <0x17c000f0 0x60>;
+ compatible = "qcom,sm8250-pdc", "qcom,pdc";
+ reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x60>;
qcom,pdc-ranges = <0 480 94>, <94 609 31>,
<125 63 1>, <126 716 12>;
#interrupt-cells = <2>;
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg
2020-04-15 5:47 [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg Bjorn Andersson
@ 2020-04-21 7:02 ` Vinod Koul
2020-04-21 8:10 ` Maulik Shah
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2020-04-21 7:02 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Venkata Narendra Kumar Gutta, Rob Herring,
linux-arm-msm, devicetree, linux-kernel
On 14-04-20, 22:47, Bjorn Andersson wrote:
> The pdc node suffers from both too narrow compatible and insufficient
> cells in the reg, fix these.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
Tested-by: Vinod Koul <vkoul@kernel.org>
> Fixes: 60378f1a171e ("arm64: dts: qcom: sm8250: Add sm8250 dts file")
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 891d83b2afea..2a7eaefd221d 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -314,8 +314,8 @@ intc: interrupt-controller@17a00000 {
> };
>
> pdc: interrupt-controller@b220000 {
> - compatible = "qcom,sm8250-pdc";
> - reg = <0x0b220000 0x30000>, <0x17c000f0 0x60>;
> + compatible = "qcom,sm8250-pdc", "qcom,pdc";
> + reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x60>;
> qcom,pdc-ranges = <0 480 94>, <94 609 31>,
> <125 63 1>, <126 716 12>;
> #interrupt-cells = <2>;
> --
> 2.24.0
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg
2020-04-21 7:02 ` Vinod Koul
@ 2020-04-21 8:10 ` Maulik Shah
0 siblings, 0 replies; 3+ messages in thread
From: Maulik Shah @ 2020-04-21 8:10 UTC (permalink / raw)
To: Vinod Koul, Bjorn Andersson
Cc: Andy Gross, Venkata Narendra Kumar Gutta, Rob Herring,
linux-arm-msm, devicetree, linux-kernel
Hi,
We can drop the second reg,
, <0 0x17c000f0 0 0x60>
The change [1] to read second reg and configure it, is not yet gone in
pdc irqchip driver.
Otherthan this, the patch looks good to me.
Thanks,
Maulik
On 4/21/2020 12:32 PM, Vinod Koul wrote:
> On 14-04-20, 22:47, Bjorn Andersson wrote:
>> The pdc node suffers from both too narrow compatible and insufficient
>> cells in the reg, fix these.
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> Tested-by: Vinod Koul <vkoul@kernel.org>
>
>> Fixes: 60378f1a171e ("arm64: dts: qcom: sm8250: Add sm8250 dts file")
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 891d83b2afea..2a7eaefd221d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -314,8 +314,8 @@ intc: interrupt-controller@17a00000 {
>> };
>>
>> pdc: interrupt-controller@b220000 {
>> - compatible = "qcom,sm8250-pdc";
>> - reg = <0x0b220000 0x30000>, <0x17c000f0 0x60>;
>> + compatible = "qcom,sm8250-pdc", "qcom,pdc";
>> + reg = <0 0x0b220000 0 0x30000>, <0 0x17c000f0 0 0x60>;
>> qcom,pdc-ranges = <0 480 94>, <94 609 31>,
>> <125 63 1>, <126 716 12>;
>> #interrupt-cells = <2>;
>> --
>> 2.24.0
[1] https://patchwork.kernel.org/patch/11145353/
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-21 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 5:47 [PATCH] arm64: dts: qcom: sm8250: Fix PDC compatible and reg Bjorn Andersson
2020-04-21 7:02 ` Vinod Koul
2020-04-21 8:10 ` Maulik Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).