* [PATCH v2 0/2] Add MSM8939 APCS support @ 2021-05-03 8:13 Shawn Guo 2021-05-03 8:13 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible Shawn Guo 2021-05-03 8:13 ` [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support Shawn Guo 0 siblings, 2 replies; 8+ messages in thread From: Shawn Guo @ 2021-05-03 8:13 UTC (permalink / raw) To: Jassi Brar Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, devicetree, linux-arm-msm, linux-kernel, Shawn Guo It's a series to add MSM8939 APCS support into qcom mailbox driver. Changes for v2: - Add MSM8939 APCS compatible. - Reword commit log. - Add Bjorn's Reviewed-by tag. v1: https://lkml.org/lkml/2020/10/12/1770 Shawn Guo (2): dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible mailbox: qcom: Add MSM8939 APCS support .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible 2021-05-03 8:13 [PATCH v2 0/2] Add MSM8939 APCS support Shawn Guo @ 2021-05-03 8:13 ` Shawn Guo 2021-05-06 15:23 ` Rob Herring 2021-05-03 8:13 ` [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support Shawn Guo 1 sibling, 1 reply; 8+ messages in thread From: Shawn Guo @ 2021-05-03 8:13 UTC (permalink / raw) To: Jassi Brar Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, devicetree, linux-arm-msm, linux-kernel, Shawn Guo Add compatible for the Qualcomm MSM8939 APCS block to the Qualcomm APCS bindings. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index 5dc1173d03fd..96b29aa6c338 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -19,6 +19,7 @@ properties: - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - qcom,msm8916-apcs-kpss-global + - qcom,msm8939-apcs-kpss-global - qcom,msm8994-apcs-kpss-global - qcom,msm8996-apcs-hmss-global - qcom,msm8998-apcs-hmss-global -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible 2021-05-03 8:13 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible Shawn Guo @ 2021-05-06 15:23 ` Rob Herring 0 siblings, 0 replies; 8+ messages in thread From: Rob Herring @ 2021-05-06 15:23 UTC (permalink / raw) To: Shawn Guo Cc: Benjamin Li, linux-kernel, devicetree, Jassi Brar, Bjorn Andersson, Sivaprakash Murugesan, Rob Herring, linux-arm-msm On Mon, 03 May 2021 16:13:33 +0800, Shawn Guo wrote: > Add compatible for the Qualcomm MSM8939 APCS block to the Qualcomm APCS > bindings. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support 2021-05-03 8:13 [PATCH v2 0/2] Add MSM8939 APCS support Shawn Guo 2021-05-03 8:13 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible Shawn Guo @ 2021-05-03 8:13 ` Shawn Guo 2021-05-23 6:00 ` Shawn Guo 1 sibling, 1 reply; 8+ messages in thread From: Shawn Guo @ 2021-05-03 8:13 UTC (permalink / raw) To: Jassi Brar Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, devicetree, linux-arm-msm, linux-kernel, Shawn Guo MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect). Although only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk' devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO rather than PLATFORM_DEVID_NONE for platform_device_register_data() call. Otherwise, the second A53PLL clock registration will fail due to duplicate device name. [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' ... [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk Signed-off-by: Shawn Guo <shawn.guo@linaro.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index f25324d03842..1699ec38bc3b 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -132,7 +132,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) if (apcs_data->clk_name) { apcs->clk = platform_device_register_data(&pdev->dev, apcs_data->clk_name, - PLATFORM_DEVID_NONE, + PLATFORM_DEVID_AUTO, NULL, 0); if (IS_ERR(apcs->clk)) dev_err(&pdev->dev, "failed to register APCS clk\n"); @@ -158,6 +158,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = { { .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data }, { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq8074_apcs_data }, { .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data }, + { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data }, { .compatible = "qcom,msm8994-apcs-kpss-global", .data = &msm8994_apcs_data }, { .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data }, { .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8998_apcs_data }, -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support 2021-05-03 8:13 ` [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support Shawn Guo @ 2021-05-23 6:00 ` Shawn Guo 2021-06-21 4:27 ` Jassi Brar 0 siblings, 1 reply; 8+ messages in thread From: Shawn Guo @ 2021-05-23 6:00 UTC (permalink / raw) To: Jassi Brar Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, devicetree, linux-arm-msm, linux-kernel On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote: > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big > cores) and CCI (Cache Coherent Interconnect). Although only APCS of > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk' > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO > rather than PLATFORM_DEVID_NONE for platform_device_register_data() > call. Otherwise, the second A53PLL clock registration will fail due > to duplicate device name. > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' > ... > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Hi Jassi, Any comment on this patch? Shawn > --- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > index f25324d03842..1699ec38bc3b 100644 > --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c > +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c > @@ -132,7 +132,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) > if (apcs_data->clk_name) { > apcs->clk = platform_device_register_data(&pdev->dev, > apcs_data->clk_name, > - PLATFORM_DEVID_NONE, > + PLATFORM_DEVID_AUTO, > NULL, 0); > if (IS_ERR(apcs->clk)) > dev_err(&pdev->dev, "failed to register APCS clk\n"); > @@ -158,6 +158,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = { > { .compatible = "qcom,ipq6018-apcs-apps-global", .data = &ipq6018_apcs_data }, > { .compatible = "qcom,ipq8074-apcs-apps-global", .data = &ipq8074_apcs_data }, > { .compatible = "qcom,msm8916-apcs-kpss-global", .data = &msm8916_apcs_data }, > + { .compatible = "qcom,msm8939-apcs-kpss-global", .data = &msm8916_apcs_data }, > { .compatible = "qcom,msm8994-apcs-kpss-global", .data = &msm8994_apcs_data }, > { .compatible = "qcom,msm8996-apcs-hmss-global", .data = &msm8996_apcs_data }, > { .compatible = "qcom,msm8998-apcs-hmss-global", .data = &msm8998_apcs_data }, > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support 2021-05-23 6:00 ` Shawn Guo @ 2021-06-21 4:27 ` Jassi Brar 2021-06-21 6:33 ` Shawn Guo 0 siblings, 1 reply; 8+ messages in thread From: Jassi Brar @ 2021-06-21 4:27 UTC (permalink / raw) To: Shawn Guo Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, Devicetree List, linux-arm-msm, Linux Kernel Mailing List On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@linaro.org> wrote: > > On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote: > > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big > > cores) and CCI (Cache Coherent Interconnect). Although only APCS of > > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock > > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk' > > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO > > rather than PLATFORM_DEVID_NONE for platform_device_register_data() > > call. Otherwise, the second A53PLL clock registration will fail due > > to duplicate device name. > > > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' > > ... > > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > Hi Jassi, > > Any comment on this patch? > 1) I was not on the CC list, so I don't have this patch in my mbox. 2) Shouldn't this patch be broken into a fix and an enablement patch? cheers. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support 2021-06-21 4:27 ` Jassi Brar @ 2021-06-21 6:33 ` Shawn Guo 2021-06-21 14:49 ` Jassi Brar 0 siblings, 1 reply; 8+ messages in thread From: Shawn Guo @ 2021-06-21 6:33 UTC (permalink / raw) To: Jassi Brar Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, Devicetree List, linux-arm-msm, Linux Kernel Mailing List On Sun, Jun 20, 2021 at 11:27:49PM -0500, Jassi Brar wrote: > On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@linaro.org> wrote: > > > > On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote: > > > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big > > > cores) and CCI (Cache Coherent Interconnect). Although only APCS of > > > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock > > > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk' > > > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO > > > rather than PLATFORM_DEVID_NONE for platform_device_register_data() > > > call. Otherwise, the second A53PLL clock registration will fail due > > > to duplicate device name. > > > > > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' > > > ... > > > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk > > > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > Hi Jassi, > > > > Any comment on this patch? > > > 1) I was not on the CC list, so I don't have this patch in my mbox. That's strange. The patch series was sent with your address <jassisinghbrar@gmail.com> on "To:" field. And that can be seen on patch archive [1]. > 2) Shouldn't this patch be broken into a fix and an enablement patch? MSM8939 is the only platform that I know has multiple clusters and uses APCS driver. So the change becomes a fix only when MSM8939 is enabled. But if you prefer to separate the change, I will do so. Shawn [1] https://lore.kernel.org/patchwork/patch/1420808/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support 2021-06-21 6:33 ` Shawn Guo @ 2021-06-21 14:49 ` Jassi Brar 0 siblings, 0 replies; 8+ messages in thread From: Jassi Brar @ 2021-06-21 14:49 UTC (permalink / raw) To: Shawn Guo Cc: Rob Herring, Sivaprakash Murugesan, Bjorn Andersson, Benjamin Li, Devicetree List, linux-arm-msm, Linux Kernel Mailing List On Mon, Jun 21, 2021 at 1:33 AM Shawn Guo <shawn.guo@linaro.org> wrote: > > On Sun, Jun 20, 2021 at 11:27:49PM -0500, Jassi Brar wrote: > > On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@linaro.org> wrote: > > > > > > On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote: > > > > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big > > > > cores) and CCI (Cache Coherent Interconnect). Although only APCS of > > > > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock > > > > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk' > > > > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO > > > > rather than PLATFORM_DEVID_NONE for platform_device_register_data() > > > > call. Otherwise, the second A53PLL clock registration will fail due > > > > to duplicate device name. > > > > > > > > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' > > > > ... > > > > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk > > > > > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> > > > > > > Hi Jassi, > > > > > > Any comment on this patch? > > > > > 1) I was not on the CC list, so I don't have this patch in my mbox. > > That's strange. The patch series was sent with your address > <jassisinghbrar@gmail.com> on "To:" field. And that can be seen on > patch archive [1]. > Sorry, yes you are right. But I still can't find it in my inbox (and neither in spam).... perhaps I nuked it by mistake. anyways... > > 2) Shouldn't this patch be broken into a fix and an enablement patch? > > MSM8939 is the only platform that I know has multiple clusters and uses > APCS driver. So the change becomes a fix only when MSM8939 is enabled. > But if you prefer to separate the change, I will do so. > Yes, please. thanks. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-06-21 14:49 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-05-03 8:13 [PATCH v2 0/2] Add MSM8939 APCS support Shawn Guo 2021-05-03 8:13 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible Shawn Guo 2021-05-06 15:23 ` Rob Herring 2021-05-03 8:13 ` [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support Shawn Guo 2021-05-23 6:00 ` Shawn Guo 2021-06-21 4:27 ` Jassi Brar 2021-06-21 6:33 ` Shawn Guo 2021-06-21 14:49 ` Jassi Brar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).