* [PATCH 1/2] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
2021-06-02 1:00 [PATCH 0/2] move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
@ 2021-06-02 1:00 ` Tian Tao
2021-06-02 10:14 ` Mark Rutland
2021-06-02 1:00 ` [PATCH 2/2] perf: qcom_l2_pmu: " Tian Tao
2021-06-02 17:06 ` [PATCH 0/2] " Will Deacon
2 siblings, 1 reply; 6+ messages in thread
From: Tian Tao @ 2021-06-02 1:00 UTC (permalink / raw)
To: will, agross, bjorn.andersson, mark.rutland
Cc: linux-arm-msm, linux-arm-kernel, Tian Tao
request_irq() after setting IRQ_NOAUTOEN as below
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/perf/arm_pmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
index e57b348..eb3a802 100644
--- a/drivers/perf/arm_pmu.c
+++ b/drivers/perf/arm_pmu.c
@@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
}
irq_flags = IRQF_PERCPU |
- IRQF_NOBALANCING |
+ IRQF_NOBALANCING | IRQF_NO_AUTOEN |
IRQF_NO_THREAD;
- irq_set_status_flags(irq, IRQ_NOAUTOEN);
-
err = request_nmi(irq, handler, irq_flags, "arm-pmu",
per_cpu_ptr(&cpu_armpmu, cpu));
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
2021-06-02 1:00 ` [PATCH 1/2] arm_pmu: " Tian Tao
@ 2021-06-02 10:14 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2021-06-02 10:14 UTC (permalink / raw)
To: Tian Tao; +Cc: will, agross, bjorn.andersson, linux-arm-msm, linux-arm-kernel
On Wed, Jun 02, 2021 at 09:00:41AM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
> can be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
I see that the patch above was merged in v5.13-rc1 as commit:
cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
With that in mind:
Acked-by: Mark Rutland <mark.rutland@arm.com>
... I expect Will will pick this up.
Thanks,
Mark.
> ---
> drivers/perf/arm_pmu.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
> index e57b348..eb3a802 100644
> --- a/drivers/perf/arm_pmu.c
> +++ b/drivers/perf/arm_pmu.c
> @@ -644,11 +644,9 @@ int armpmu_request_irq(int irq, int cpu)
> }
>
> irq_flags = IRQF_PERCPU |
> - IRQF_NOBALANCING |
> + IRQF_NOBALANCING | IRQF_NO_AUTOEN |
> IRQF_NO_THREAD;
>
> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
> -
> err = request_nmi(irq, handler, irq_flags, "arm-pmu",
> per_cpu_ptr(&cpu_armpmu, cpu));
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
2021-06-02 1:00 [PATCH 0/2] move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-06-02 1:00 ` [PATCH 1/2] arm_pmu: " Tian Tao
@ 2021-06-02 1:00 ` Tian Tao
2021-06-02 10:16 ` Mark Rutland
2021-06-02 17:06 ` [PATCH 0/2] " Will Deacon
2 siblings, 1 reply; 6+ messages in thread
From: Tian Tao @ 2021-06-02 1:00 UTC (permalink / raw)
To: will, agross, bjorn.andersson, mark.rutland
Cc: linux-arm-msm, linux-arm-kernel, Tian Tao
request_irq() after setting IRQ_NOAUTOEN as below
irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can
be replaced by request_irq() with IRQF_NO_AUTOEN flag.
this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
is being merged: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/perf/qcom_l2_pmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
index fc54a80..b60e301 100644
--- a/drivers/perf/qcom_l2_pmu.c
+++ b/drivers/perf/qcom_l2_pmu.c
@@ -869,14 +869,14 @@ static int l2_cache_pmu_probe_cluster(struct device *dev, void *data)
irq = platform_get_irq(sdev, 0);
if (irq < 0)
return irq;
- irq_set_status_flags(irq, IRQ_NOAUTOEN);
cluster->irq = irq;
cluster->l2cache_pmu = l2cache_pmu;
cluster->on_cpu = -1;
err = devm_request_irq(&pdev->dev, irq, l2_cache_handle_irq,
- IRQF_NOBALANCING | IRQF_NO_THREAD,
+ IRQF_NOBALANCING | IRQF_NO_THREAD |
+ IRQF_NO_AUTOEN,
"l2-cache-pmu", cluster);
if (err) {
dev_err(&pdev->dev,
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
2021-06-02 1:00 ` [PATCH 2/2] perf: qcom_l2_pmu: " Tian Tao
@ 2021-06-02 10:16 ` Mark Rutland
0 siblings, 0 replies; 6+ messages in thread
From: Mark Rutland @ 2021-06-02 10:16 UTC (permalink / raw)
To: Tian Tao; +Cc: will, agross, bjorn.andersson, linux-arm-msm, linux-arm-kernel
On Wed, Jun 02, 2021 at 09:00:42AM +0800, Tian Tao wrote:
> request_irq() after setting IRQ_NOAUTOEN as below
> irq_set_status_flags(irq, IRQ_NOAUTOEN); request_irq(dev, irq...); can
> be replaced by request_irq() with IRQF_NO_AUTOEN flag.
>
> this patch is made base on "add IRQF_NO_AUTOEN for request_irq" which
> is being merged: https://lore.kernel.org/patchwork/patch/1388765/
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
As with patch 1, I see that the patch above was merged in v5.13-rc1 as commit:
cbe16f35bee6880b ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
With that in mind:
Acked-by: Mark Rutland <mark.rutland@arm.com>
I expect Will will pick this up.
Thanks,
Mark.
> ---
> drivers/perf/qcom_l2_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/qcom_l2_pmu.c b/drivers/perf/qcom_l2_pmu.c
> index fc54a80..b60e301 100644
> --- a/drivers/perf/qcom_l2_pmu.c
> +++ b/drivers/perf/qcom_l2_pmu.c
> @@ -869,14 +869,14 @@ static int l2_cache_pmu_probe_cluster(struct device *dev, void *data)
> irq = platform_get_irq(sdev, 0);
> if (irq < 0)
> return irq;
> - irq_set_status_flags(irq, IRQ_NOAUTOEN);
> cluster->irq = irq;
>
> cluster->l2cache_pmu = l2cache_pmu;
> cluster->on_cpu = -1;
>
> err = devm_request_irq(&pdev->dev, irq, l2_cache_handle_irq,
> - IRQF_NOBALANCING | IRQF_NO_THREAD,
> + IRQF_NOBALANCING | IRQF_NO_THREAD |
> + IRQF_NO_AUTOEN,
> "l2-cache-pmu", cluster);
> if (err) {
> dev_err(&pdev->dev,
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] move to use request_irq by IRQF_NO_AUTOEN flag
2021-06-02 1:00 [PATCH 0/2] move to use request_irq by IRQF_NO_AUTOEN flag Tian Tao
2021-06-02 1:00 ` [PATCH 1/2] arm_pmu: " Tian Tao
2021-06-02 1:00 ` [PATCH 2/2] perf: qcom_l2_pmu: " Tian Tao
@ 2021-06-02 17:06 ` Will Deacon
2 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2021-06-02 17:06 UTC (permalink / raw)
To: bjorn.andersson, mark.rutland, agross, Tian Tao
Cc: catalin.marinas, kernel-team, Will Deacon, linux-arm-msm,
linux-arm-kernel
On Wed, 2 Jun 2021 09:00:40 +0800, Tian Tao wrote:
> patch #1 and #2 both use IRQF_NO_AUTOEN instead of
> irq_set_status_flags(irq, IRQ_NOAUTOEN). this change is just to simplify
> the code, no actual functional changes.
>
> Tian Tao (2):
> arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
> perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
>
> [...]
Applied to will (for-next/perf), thanks!
[1/2] arm_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
https://git.kernel.org/will/c/3c1f2eb5475a
[2/2] perf: qcom_l2_pmu: move to use request_irq by IRQF_NO_AUTOEN flag
https://git.kernel.org/will/c/0d0f144a8f5f
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
^ permalink raw reply [flat|nested] 6+ messages in thread