From: Adam Serbinski <adam@serbinski.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Patrick Lai <plai@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/6] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding documentation
Date: Wed, 12 Feb 2020 06:01:46 -0500 [thread overview]
Message-ID: <2989c09149976a28d13d4b4eb10b7c7e@serbinski.com> (raw)
In-Reply-To: <579e0ae1-f257-7af3-eac9-c8e3ab3b52c7@linaro.org>
On 2020-02-12 04:59, Srinivas Kandagatla wrote:
> On 12/02/2020 01:52, Adam Serbinski wrote:
>> This patch adds documentation of bindings required for PCM ports on
>> AFE.
>>
>> Signed-off-by: Adam Serbinski <adam@serbinski.com>
>> CC: Andy Gross <agross@kernel.org>
>> CC: Mark Rutland <mark.rutland@arm.com>
>> CC: Liam Girdwood <lgirdwood@gmail.com>
>> CC: Patrick Lai <plai@codeaurora.org>
>> CC: Banajit Goswami <bgoswami@codeaurora.org>
>> CC: Jaroslav Kysela <perex@perex.cz>
>> CC: Takashi Iwai <tiwai@suse.com>
>> CC: alsa-devel@alsa-project.org
>> CC: linux-arm-msm@vger.kernel.org
>> CC: devicetree@vger.kernel.org
>> CC: linux-kernel@vger.kernel.org
>> ---
>> .../devicetree/bindings/sound/qcom,q6afe.txt | 42
>> +++++++++++++++++++
>> 1 file changed, 42 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt
>> b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt
>> index d74888b9f1bb..6b1b17d31a2a 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,q6afe.txt
>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6afe.txt
>> @@ -51,6 +51,24 @@ configuration of each dai. Must contain the
>> following properties.
>> Definition: Must be list of serial data lines used by this dai.
>> should be one or more of the 0-3 sd lines.
>> + - qcom,pcm-quantype
>> + Usage: required for pcm interface
>> + Value type: <u32>
>> + Definition: PCM quantization type
>> + 0 - ALAW, no padding
>> + 1 - MULAW, no padding
>> + 2 - Linear, no padding
>> + 3 - ALAW, padding
>> + 4 - MULAW, padding
>> + 5 - Linear, padding
>> +
>> + - qcom,pcm-slot-mapping
>> + Usage: required for pcm interface
>
> Are these not specific to 8k and 16k mode ?
> We should probably list values for both modes here.
No, this is just the offset that the audio sample is placed in with
respect to a maximum of 4 slots, 16 bits wide, beginning with the sync
pulse.
When switching between 8 and 16k sample rate, it is just the sync pulse
rate that is changed. The audio sample will be delivered in the same
slot, just at a different frequency.
>> + Value type: <prop-encoded-array>
>> + Definition: Slot mapping for audio channels. Array size is the
>> number
>> + of slots, minimum 1, maximum 4. The value is 0 for no mapping
>> + to the slot, or the channel number from 1 to 32.
>> +
>> - qcom,tdm-sync-mode:
>> Usage: required for tdm interface
>> Value type: <prop-encoded-array>
>> @@ -174,5 +192,29 @@ q6afe@4 {
>> reg = <23>;
>> qcom,sd-lines = <1>;
>> };
>> +
>> + pri-pcm-rx@105 {
>> + reg = <105>;
>> + qcom,pcm-quantype = <2>;
>> + qcom,pcm-slot-mapping = <1>;
>> + };
>> +
>> + pri-pcm-tx@106 {
>> + reg = <106>;
>> + qcom,pcm-quantype = <2>;
>> + qcom,pcm-slot-mapping = <1>;
>> + };
>> +
>> + quat-pcm-rx@111 {
>> + reg = <111>;
>> + qcom,pcm-quantype = <5>;
>> + qcom,pcm-slot-mapping = <0 0 1>;
>> + };
>> +
>> + quat-pcm-tx@112 {
>> + reg = <112>;
>> + qcom,pcm-quantype = <5>;
>> + qcom,pcm-slot-mapping = <0 0 1>;
>> + };
>> };
>> };
>>
next prev parent reply other threads:[~2020-02-12 11:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200212015222.8229-1-adam@serbinski.com>
2020-02-12 1:52 ` [PATCH v3 1/6] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding Adam Serbinski
2020-02-12 1:52 ` [PATCH v3 2/6] ASoC: qdsp6: q6afe: add support to pcm ports Adam Serbinski
2020-02-12 1:52 ` [PATCH v3 3/6] ASoC: qdsp6: q6afe-dai: add support to pcm port dais Adam Serbinski
2020-02-12 9:52 ` Srinivas Kandagatla
2020-02-12 9:53 ` Srinivas Kandagatla
2020-02-12 1:52 ` [PATCH v3 4/6] ASoC: qdsp6: q6routing: add pcm port routing Adam Serbinski
2020-02-12 1:52 ` [PATCH v3 5/6] ASoC: qcom: apq8096: add support for primary and quaternary I2S/PCM Adam Serbinski
2020-02-12 1:52 ` [PATCH v3 6/6] ASoC: qdsp6: dt-bindings: Add q6afe pcm dt binding documentation Adam Serbinski
2020-02-12 9:59 ` Srinivas Kandagatla
2020-02-12 11:01 ` Adam Serbinski [this message]
2020-02-12 11:43 ` Srinivas Kandagatla
2020-02-12 12:07 ` Adam Serbinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2989c09149976a28d13d4b4eb10b7c7e@serbinski.com \
--to=adam@serbinski.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).