From: Fenglin Wu <quic_fenglinw@quicinc.com>
To: Stephen Boyd <sboyd@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <collinsd@codeaurora.org>, <subbaram@codeaurora.org>,
Yimin Peng <yiminp@codeaurora.org>, <tglx@linutronix.de>,
<maz@kernel.org>
Subject: Re: [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt type flags
Date: Thu, 14 Oct 2021 11:17:53 +0800 [thread overview]
Message-ID: <33b810b9-0b5a-c284-c571-a30add06267f@quicinc.com> (raw)
In-Reply-To: <163415386095.936959.16722730558107515093@swboyd.mtv.corp.google.com>
On 10/14/2021 3:37 AM, Stephen Boyd wrote:
> Quoting Fenglin Wu (2021-10-12 23:27:22)
>> copy IRQCHIP driver maintainers as requested in another patch.
>>
>> On 10/13/2021 1:42 AM, Stephen Boyd wrote:
>>> Quoting Fenglin Wu (2021-09-16 23:33:02)
>>>> From: Yimin Peng <yiminp@codeaurora.org>
>>>>
>>>> Have the qpnpint_irq_set_type function clear unwanted high/low
>>>> trigger bits when updating the interrupt flags.
>>> Why?
>> There was a requirement to update the PMIC module interrupt type
>> dynamically
>> (such as from low level trigger to high level trigger), hence it's required
>> to clear the unnecessary trigger type when setting it.
> Can you clearly describe the problem in the commit text? Is this a bug
> fix?
sure, will do.
>>>> Signed-off-by: Yimin Peng <yiminp@codeaurora.org>
>>>> Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
>>>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
>>>> ---
>>> Does this need a Fixes tag?
>> Maybe no need to a Fixes tag because this is part of the initial code when
>> interrupt handling is added?
> Was it always broken? Or trigger types haven't been changing at runtime
> because most users are requesting irqs and forgetting about it? Are you
> using gpio-keys or something like that now? Adding a Fixes tag doesn't
> hurt.
You are right, it was reported by someone when using a PMIC GPIO and update
the interrupt at runtime, I am not sure if it's gpio-keys but that can be a
realistic case.
I will add a Fixes tag for it.
next prev parent reply other threads:[~2021-10-14 3:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 6:32 [RESEND PATCH v1 0/9] A bunch of fix and optimization patches in spmi-pmic-arb.c Fenglin Wu
2021-09-17 6:32 ` [RESEND PATCH v1 1/9] spmi: pmic-arb: add a print in cleanup_irq Fenglin Wu
2021-10-12 17:46 ` Stephen Boyd
2021-10-13 4:15 ` Fenglin Wu
2021-10-13 19:35 ` Stephen Boyd
2021-10-14 2:26 ` Fenglin Wu
2021-10-15 1:09 ` Stephen Boyd
2021-10-15 1:27 ` Fenglin Wu
2021-10-18 0:16 ` Fenglin Wu
2021-09-17 6:32 ` [RESEND PATCH v1 2/9] spmi: pmic-arb: do not ack and clear peripheral interrupts " Fenglin Wu
2021-09-17 6:32 ` [RESEND PATCH v1 3/9] spmi: pmic-arb: check apid against limits before calling irq handler Fenglin Wu
2021-10-12 18:02 ` Stephen Boyd
2021-10-13 5:31 ` Fenglin Wu
2021-10-13 19:25 ` Stephen Boyd
2021-10-14 3:11 ` Fenglin Wu
2021-10-15 1:15 ` Stephen Boyd
2021-10-15 1:54 ` Fenglin Wu
2021-09-17 6:32 ` [RESEND PATCH v1 4/9] spmi: pmic-arb: add support to dispatch interrupt based on IRQ status Fenglin Wu
2021-09-17 6:33 ` [RESEND PATCH v1 5/9] spmi: pmic-arb: correct duplicate APID to PPID mapping logic Fenglin Wu
2021-10-12 17:44 ` Stephen Boyd
2021-10-13 5:37 ` Fenglin Wu
2021-09-17 6:33 ` [RESEND PATCH v1 6/9] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes Fenglin Wu
2021-09-17 6:33 ` [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt type flags Fenglin Wu
2021-10-12 17:42 ` Stephen Boyd
2021-10-13 6:27 ` Fenglin Wu
2021-10-13 19:37 ` Stephen Boyd
2021-10-14 3:17 ` Fenglin Wu [this message]
2021-09-17 6:33 ` [RESEND PATCH v1 8/9] spmi: pmic-arb: make interrupt support optional Fenglin Wu
2021-10-12 17:41 ` Stephen Boyd
2021-10-13 8:36 ` Fenglin Wu
2021-10-13 19:38 ` Stephen Boyd
2021-10-14 3:20 ` Fenglin Wu
2021-10-15 1:17 ` Stephen Boyd
2021-10-15 1:30 ` Fenglin Wu
2021-09-17 6:33 ` [RESEND PATCH v1 9/9] spmi: pmic-arb: increase SPMI transaction timeout delay Fenglin Wu
-- strict thread matches above, loose matches on Subject: below --
2021-09-01 8:18 [RESEND PATCH v1 0/9] A bunch of fix and optimization patches in spmi-pmic-arb.c Fenglin Wu
2021-09-01 8:18 ` [RESEND PATCH v1 7/9] spmi: pmic-arb: support updating interrupt type flags Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33b810b9-0b5a-c284-c571-a30add06267f@quicinc.com \
--to=quic_fenglinw@quicinc.com \
--cc=collinsd@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=yiminp@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).