From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jack Pham <jackp@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
balbi@kernel.org, gregkh@linuxfoundation.org, agross@kernel.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
wcheng@codeaurora.org
Subject: Re: [PATCH 1/2] usb: dwc3: dwc3-qcom: Find USB connector and register role switch
Date: Thu, 1 Jul 2021 03:08:01 +0100 [thread overview]
Message-ID: <85110545-0369-f7b3-724f-866d3ce1438b@linaro.org> (raw)
In-Reply-To: <20210701011153.GF25299@jackp-linux.qualcomm.com>
On 01/07/2021 02:12, Jack Pham wrote:
> I'm afraid I'm not too familiar with weak symbols. Would that still work
> if dwc3 & dwc3-qcom are built as modules? Also is it supported with
> Clang/LLVM?
__weak would work fine, until you tried to have two strong implementations.
Your linker should choke if dwc3-meson-g12a, dwc3-qcom and dwc3-drd
linked together with both wrappers implementing normal linkage.
However, I do think its possible to use role switching to have dwc3-drd
trigger dwc3-qcom.
The role switch code is resilient to deferral so we don't have to solve
the problem we had with get_drvdata() in the notifier solution and it
gets us out of the business of having dwc3-qcom relay the role-switch
onto the core - or indeed care about what sort of connector is attached.
dwc3-qcom shouldn't have to know or care what sort of connector is
attached to it, ecros, gpio-typec, tcpm or a raw type-c driver and like
Bjorn said, it shouldn't be the case that the wrapper relays onto the core.
Anyway I'm playing with that prototype now
next prev parent reply other threads:[~2021-07-01 2:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 14:44 [PATCH 0/2] dwc3-qcom: Prepare the ground for pm8150b tcpm Bryan O'Donoghue
2021-06-29 14:44 ` [PATCH 1/2] usb: dwc3: dwc3-qcom: Find USB connector and register role switch Bryan O'Donoghue
2021-06-29 15:48 ` Bjorn Andersson
2021-06-29 19:23 ` Bryan O'Donoghue
2021-06-29 20:02 ` Jack Pham
2021-06-29 20:16 ` Bryan O'Donoghue
2021-06-29 20:30 ` Bjorn Andersson
2021-06-29 21:57 ` Bryan O'Donoghue
2021-06-30 2:21 ` Bryan O'Donoghue
2021-07-01 1:12 ` Jack Pham
2021-07-01 2:08 ` Bryan O'Donoghue [this message]
2021-06-29 20:18 ` Bjorn Andersson
2021-06-29 14:44 ` [PATCH 2/2] usb: dwc3: dwc3-qcom: Fix typo in the dwc3 vbus override API Bryan O'Donoghue
2021-06-29 15:51 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85110545-0369-f7b3-724f-866d3ce1438b@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).